Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0] [MIG] partner_firstname: Migration to 11.0 #487

Merged
merged 122 commits into from
Oct 27, 2017
Merged

[11.0] [MIG] partner_firstname: Migration to 11.0 #487

merged 122 commits into from
Oct 27, 2017

Conversation

etobella
Copy link
Member

@etobella etobella commented Oct 9, 2017

Migration to 11.0

nbessi and others added 30 commits October 9, 2017 11:58
@nbessi @etobella
[ADD] partner_firstname addons
045141d
@guewen @etobella
[REV] remove the previous revision, the merge proposal has been merge…
9f64b0f 
…d too early
@nbessi @etobella
[ADD] partner_firstname module
c74f431
@nbessi @etobella
[FIX] heading coding definition
28ad896
@nbessi @etobella
[FIX] partner_firstname can't create partner as lastname is required
e55aaed
@gurneyalex @etobella
[IMP] small improvements in module description and docstrings
52cbb73
@nbessi @etobella
[FIX] user creation from res_user form
4e2e2ab
@nbessi @etobella
[MRG] Typo
af492eb
@yvaucher @etobella
[FIX] partner_firstname name not editable in user view
2eaa49d
@yvaucher @etobella
[IMP] partner_firstname - less steps in partner vals(e)
bde32e0
@yvaucher @etobella
[FIX] partner_firstname - adapt partner form inherit to new partner form
aed00f2
@yvaucher @etobella
[IMP] partner_firstname - giving some meaning to a comment
4f3d2c9
@vrenaville @etobella
[FIX] firstname lastname fix if empty
6b0ddd4
@vrenaville @etobella
[FIX] search
6bd6eba
@vrenaville @etobella
[FIX] typo : fix instruction length
cad7208
@yvaucher @etobella
[FIX] partner_firstname - error when lastname being empty with demo d…
af80ae4 
…ata, migrated data or imported data
@guewen @etobella
[FIX] use a tuple instead of a list
8498816
@guewen @etobella
[FIX] missing propagation of the context
8e6999e
@guewen @etobella
[FIX] missing propagation of the context OCA#2
972a38a
@hbrunn @etobella
[IMP] don't show first/last name fields for companies
d186798
@hbrunn @etobella
[FIX] get required attributes right for companies and non-companies
14f833c
@hbrunn @etobella
[ADD] Dutch translation
13f6b5a
@hbrunn @etobella
[ADD] translation template
bfbd51d
@vrenaville @etobella
[FIX] layout for contact view (display Firstname and Lastname label) …
fb08e74 
…+ add Is a company on contact view of a partner
@etobella
[FIX] Create Sql constraint anyway
0641647 
[CHG] Improve the _write_name method
* trying to coerce to the correct lastname if the firstname is untouched
* resetting the firstname if contact is a company
[FIX] Avoid to replicate the firstname into the name when duplicating a partner
[FIX] Avoid to replicate the firstname into the name when duplicating a user
[CHG] Restore the required attribute of the field name in user form
[CHG] Beautify the inner form for children contacts (placing fields as in the main form)
[FIX] Allow edition of the field name in the inner form if child is a company
@etobella
[ADD] Tests For partner-firstname
b95d6e1
@etobella
[CHG] Some Refactoring Of The Code
ac30d5d
@etobella
Add more controls to avoid to update the name or the lastname fields …
82aa187 
…only with whitespace
@Olivier-LAURENT @etobella
[FIX] avoid traceback when calling the fnct_inv method with a null fi…
72c5cda 
…eld_value
@Olivier-LAURENT @etobella
[FIX] some tests failed if user's language is not english
410e2f3 
[CHG] improve some assertions
@HviorForgeFlow
Copy link
Member

LGTM 👍

@etobella
Copy link
Member Author

@yajo runbot is green now.

@JordiBForgeFlow JordiBForgeFlow mentioned this pull request Oct 13, 2017
Merged
1 task
njeudy
njeudy reviewed Oct 27, 2017
View reviewed changes
Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code check and real tests: Ok for me

njeudy
njeudy approved these changes Oct 27, 2017
View reviewed changes
Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code check and real tests: Ok for me

@JordiBForgeFlow JordiBForgeFlow merged commit 7ed6045 into OCA:11.0 Oct 27, 2017
@cliffkujala
Copy link

cliffkujala commented Jun 10, 2018 •
edited
Loading

Not specifically a v11.0 problem, but the README file for partner_firstname links to non HTTPS images so it throws a mixed content warning when viewing the App in the backend. Problem starts at line 108.

Should be:

.. image:: https://odoo-community.org/logo.png
   :alt: Odoo Community Association
   :target: https://odoo-community.org

This module is maintained by the OCA.

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

To contribute to this module, please visit https://odoo-community.org.

But it is all http:// below line 108.

yajo added a commit that referenced this pull request Jun 11, 2018
@yajo
[FIX] partner_firstname: Mixed content error, move to HTTPS
9c09dbc 
Fix #487 (comment)
@pedrobaeza
Copy link
Member

@cliffkujala Fixed.

gdgellatly pushed a commit to odoonz/partner-contact that referenced this pull request Oct 29, 2018
@yajo @gdgellatly
[FIX] partner_firstname: Mixed content error, move to HTTPS
7cfd1bb 
Fix OCA#487 (comment)
gdgellatly pushed a commit to odoonz/partner-contact that referenced this pull request Nov 6, 2018
@yajo @gdgellatly
[FIX] partner_firstname: Mixed content error, move to HTTPS
18c8471 
Fix OCA#487 (comment)
yajo added a commit that referenced this pull request Nov 22, 2018
@yajo
[FIX] partner_firstname: Mixed content error, move to HTTPS
60a8ec7 
Fix #487 (comment)
victormmtorres pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 25, 2019
@yajo
[FIX] partner_firstname: Mixed content error, move to HTTPS
54e6da1 
Fix OCA#487 (comment)
rven pushed a commit to rven/partner-contact that referenced this pull request Sep 30, 2019
@yajo @rven
[FIX] partner_firstname: Mixed content error, move to HTTPS
7f8ed63 
Fix OCA#487 (comment)
rven pushed a commit to rven/partner-contact that referenced this pull request Oct 26, 2019
@yajo @rven
[FIX] partner_firstname: Mixed content error, move to HTTPS
454c709 
Fix OCA#487 (comment)
ermannognan pushed a commit to ermannognan/partner-contact that referenced this pull request Nov 25, 2019
@yajo @ermannognan
[FIX] partner_firstname: Mixed content error, move to HTTPS
eac933b 
Fix OCA#487 (comment)
luistorresm pushed a commit to vauxoo-dev/partner-contact that referenced this pull request Oct 12, 2020
@yajo @luistorresm
[FIX] partner_firstname: Mixed content error, move to HTTPS
e758153 
Fix OCA#487 (comment)
BT-dherreros pushed a commit to brain-tec/partner-contact that referenced this pull request Oct 18, 2021
@yajo @BT-dherreros
[FIX] partner_firstname: Mixed content error, move to HTTPS
3c2d93b 
Fix OCA#487 (comment)
BT-dherreros pushed a commit to brain-tec/partner-contact that referenced this pull request Oct 18, 2021
@yajo @BT-dherreros
[FIX] partner_firstname: Mixed content error, move to HTTPS
e908486 
Fix OCA#487 (comment)
BT-dherreros pushed a commit to brain-tec/partner-contact that referenced this pull request Oct 18, 2021
@yajo @BT-dherreros
[FIX] partner_firstname: Mixed content error, move to HTTPS
0e38da4 
Fix OCA#487 (comment)
bjornbillen pushed a commit to bjornbillen/partner-contact that referenced this pull request Nov 12, 2021
@yajo @bjornbillen
[FIX] partner_firstname: Mixed content error, move to HTTPS
bc8a141 
Fix OCA#487 (comment)
bjornbillen pushed a commit to bjornbillen/partner-contact that referenced this pull request Feb 8, 2022
@yajo @bjornbillen
[FIX] partner_firstname: Mixed content error, move to HTTPS
0642b6f 
Fix OCA#487 (comment)
FrancoMaxime pushed a commit to acsone/partner-contact that referenced this pull request Aug 24, 2022
@yajo @FrancoMaxime
[FIX] partner_firstname: Mixed content error, move to HTTPS
619dee0 
Fix OCA#487 (comment)
baimont pushed a commit to acsone/partner-contact that referenced this pull request Oct 6, 2022
@yajo @baimont
[FIX] partner_firstname: Mixed content error, move to HTTPS
c9977b3 
Fix OCA#487 (comment)
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Feb 3, 2023
@yajo @victor-champonnois
[FIX] partner_firstname: Mixed content error, move to HTTPS
b4f88e6 
Fix OCA#487 (comment)
moitabenfdz pushed a commit to DynAppsNV/partner-contact that referenced this pull request Nov 16, 2023
@yajo @moitabenfdz
[FIX] partner_firstname: Mixed content error, move to HTTPS
c440b1a 
Fix OCA#487 (comment)
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@yajo @edlopen
[FIX] partner_firstname: Mixed content error, move to HTTPS
ef5f1e4 
Fix OCA#487 (comment)
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
@yajo @edlopen
[FIX] partner_firstname: Mixed content error, move to HTTPS
634755c 
Fix OCA#487 (comment)
SonoDavid pushed a commit to DynAppsNV/partner-contact that referenced this pull request Oct 14, 2024
@yajo
[FIX] partner_firstname: Mixed content error, move to HTTPS
5650709 
Fix OCA#487 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@rgarnau rgarnau rgarnau approved these changes

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

@njeudy njeudy njeudy approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.