[11.0][mig][base_location_geonames_import] #494

JordiBForgeFlow · 2017-10-13T12:11:29Z

Migration to 11.0.
Relevant changes:

The module now creates res.city if the country requires it (flag 'enforce_cities' is set for that country)

Depends on

base_location [11.0] [mig] base_location: Migration to 11.0 #488

I discussed with @pedrobaeza The possibility to import only cities. But after reviewing, it can be very confusing to do so in this module, and in any case we could discuss about creating a separate base_address_city_geonames_import that does not depend on base_location, but only on base_address_city.

rgarnau

LGTM 👍

etobella

LGTM 👍
Just a minor comment

etobella · 2017-10-31T15:53:48Z

base_location_geonames_import/__init__.py

@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-


Coding is no longer necessary, as it can be checked in the migration document to 11.0

But here it appears:
https://github.com/OCA/maintainer-tools/blob/master/template/module/models/__init__.py

Because for Python 2.7 is still needed...

Oh, yes!! 😂

MiquelRForgeFlow · 2017-11-06T10:41:50Z

base_location_geonames_import/__manifest__.py

+#                     <alexis.delattre@akretion.com>)
+# Copyright 2014 Lorenzo Battistini <lorenzo.battistini@agilebg.com>
+# Copyright 2016 Pedro M. Baeza <pedro.baeza@tecnativa.com>
+# Copyright 2017 Efient Business and IT Consulting Services, S.L.


MiquelRForgeFlow

LGTM

jesusVMayor

LGTM

pedrobaeza · 2017-11-13T12:49:18Z

Any possible improvement in speed?

AaronHForgeFlow

It works correctly 👍 Couldn't find a way to make it faster.

yajo · 2017-11-15T14:01:42Z

Can you rebase now that #488 is merged? (BTW I don't understand how bots were ✔️ )

JordiBForgeFlow · 2017-11-17T18:18:17Z

@pedrobaeza @yajo Ready to be merged.

pedrobaeza · 2017-11-17T18:28:31Z

There are some duplicated commits at the beginning. please squash them.

JordiBForgeFlow · 2017-11-17T18:36:04Z

@pedrobaeza I am not sure to understand which ones you mean. I found a few Transifex commits that were one after each other and I squashed them.

pedrobaeza · 2017-11-17T18:39:59Z

Wow, it seems that right now everything has blown away with lots of commits that doesn't belong to this...

yajo · 2017-11-20T08:39:48Z

Yeah, it seems something weird happened in the branch, please check that 😕

…state). Add POT file and FR translation.

JordiBForgeFlow · 2017-11-21T13:34:09Z

@pedrobaeza Will you do the honors to merge?

pedrobaeza · 2017-11-21T13:35:38Z

Yes, of course.

pedrobaeza · 2017-11-21T13:36:40Z

I see that your name is not correct yet (Efient instead of Eficent). Do you want to fix it?

JordiBForgeFlow · 2017-11-21T14:44:21Z

@pedrobaeza fixed!

… imported country Monaco country is very little and it allows to save some downloaded bytes plus making a test for entries deletion

For avoiding constant problems with this test, as Monaco data changes a lot, what we are testing now is the existence of the data, not the exact match of them.

Add option to put city name all upper case

* Tests * New menu location * Wizard options fixed

* Speed improvement applying cache for not doing duplicated searches over states. * Tests change to SavepointCase, which only passes over setUp one time.

* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer

JordiBForgeFlow requested review from etobella, MiquelRForgeFlow and HviorForgeFlow October 13, 2017 12:11

pedrobaeza mentioned this pull request Oct 13, 2017

Migration to version 11.0 #482

Closed

53 tasks

JordiBForgeFlow force-pushed the 11.0-mig-base_location_geonames_import branch from 10a0c9f to 9a36ea1 Compare October 16, 2017 14:14

rafaelbn added this to the 11.0 milestone Oct 16, 2017

rafaelbn added the work in progress label Oct 16, 2017

JordiBForgeFlow force-pushed the 11.0-mig-base_location_geonames_import branch 3 times, most recently from fe3f925 to 3f0e97c Compare October 19, 2017 13:08

rgarnau approved these changes Oct 19, 2017

View reviewed changes

etobella mentioned this pull request Oct 23, 2017

[11.0] [MIG] l10n_es_toponyms OCA/l10n-spain#668

Merged

2 tasks

etobella approved these changes Oct 31, 2017

View reviewed changes

MiquelRForgeFlow reviewed Nov 6, 2017

View reviewed changes

jesusVMayor approved these changes Nov 13, 2017

View reviewed changes

AaronHForgeFlow approved these changes Nov 14, 2017

View reviewed changes

yajo added needs review and removed work in progress labels Nov 15, 2017

JordiBForgeFlow force-pushed the 11.0-mig-base_location_geonames_import branch from 3f0e97c to c4851d0 Compare November 17, 2017 17:50

JordiBForgeFlow force-pushed the 11.0-mig-base_location_geonames_import branch from c4851d0 to 8eeaf2b Compare November 17, 2017 18:34

Alexis de Lattre added 2 commits November 20, 2017 09:52

Add module base_location_geonames_import

b22bc85

Add support for states (if states are already present in res.country.…

7a0aaeb

…state). Add POT file and FR translation.

JordiBForgeFlow force-pushed the 11.0-mig-base_location_geonames_import branch 2 times, most recently from 205025d to ec11e6e Compare November 21, 2017 13:47

pedrobaeza and others added 22 commits November 21, 2017 17:57

[IMP] base_location_geonames_import: Better README

d8f4929

[UPD] prefix versions with 8.0

96060cf

[MIG] Make modules uninstallable

1bad12c

Added option to convert retreived names to Title Case.

9efa63b

OCA requirements

7b9f585

[MIG] base_location_geonames_import: Initial migration to 9.0

729fbbb

[IMP] base_location_geonames_import: Make tests more efficient

278ef71

[FIX] base_location_geonames_import: Don't alias Warning

3ed9efe

[IMP] base_location_geonames_import: Convert tests to Python + switch…

8e6b57f

… imported country Monaco country is very little and it allows to save some downloaded bytes plus making a test for entries deletion

[IMP] base_location_geonames_import: Switch author

34c570b

[FIX] base_location_geonames_import: Fix test

42d56b8

[FIX] base_location_geonames_import: Fix tests

9aabbd7

[MIG] Make modules uninstallable

b994944

[MIG] Rename manifest files

40e9681

[FIX] base_location_geonames_import: Test logic changed

0ee493a

For avoiding constant problems with this test, as Monaco data changes a lot, what we are testing now is the existence of the data, not the exact match of them.

Port base_location_geonames_import to v10

714c1e4

Add option to put city name all upper case

[FIX+IMP] base_location_geonames_import

d3d5a7a

* Tests * New menu location * Wizard options fixed

[IMP] base_location_geonames_import

3a53893

* Speed improvement applying cache for not doing duplicated searches over states. * Tests change to SavepointCase, which only passes over setUp one time.

[FIX] Fix usage in Readme.md

fe25017

[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)

f8fa487

* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer

OCA Transbot updated translations from Transifex

5ff8ad4

migration to 11.0

bb1ca1e

pedrobaeza force-pushed the 11.0-mig-base_location_geonames_import branch from ec11e6e to bb1ca1e Compare November 21, 2017 16:57

pedrobaeza merged commit dbfc9d1 into OCA:11.0 Nov 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][mig][base_location_geonames_import] #494

[11.0][mig][base_location_geonames_import] #494

JordiBForgeFlow commented Oct 13, 2017 •

edited by yajo

Loading

rgarnau left a comment

etobella left a comment

etobella Oct 31, 2017

MiquelRForgeFlow Nov 6, 2017

pedrobaeza Nov 6, 2017

MiquelRForgeFlow Nov 6, 2017 •

edited

Loading

MiquelRForgeFlow Nov 6, 2017

MiquelRForgeFlow left a comment •

edited

Loading

jesusVMayor left a comment

pedrobaeza commented Nov 13, 2017

AaronHForgeFlow left a comment

yajo commented Nov 15, 2017

JordiBForgeFlow commented Nov 17, 2017

pedrobaeza commented Nov 17, 2017

JordiBForgeFlow commented Nov 17, 2017

pedrobaeza commented Nov 17, 2017

yajo commented Nov 20, 2017

JordiBForgeFlow commented Nov 21, 2017

pedrobaeza commented Nov 21, 2017

pedrobaeza commented Nov 21, 2017

JordiBForgeFlow commented Nov 21, 2017

[11.0][mig][base_location_geonames_import] #494

[11.0][mig][base_location_geonames_import] #494

Conversation

JordiBForgeFlow commented Oct 13, 2017 • edited by yajo Loading

rgarnau left a comment

Choose a reason for hiding this comment

etobella left a comment

Choose a reason for hiding this comment

etobella Oct 31, 2017

Choose a reason for hiding this comment

MiquelRForgeFlow Nov 6, 2017

Choose a reason for hiding this comment

pedrobaeza Nov 6, 2017

Choose a reason for hiding this comment

MiquelRForgeFlow Nov 6, 2017 • edited Loading

Choose a reason for hiding this comment

MiquelRForgeFlow Nov 6, 2017

Choose a reason for hiding this comment

MiquelRForgeFlow left a comment • edited Loading

Choose a reason for hiding this comment

jesusVMayor left a comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 13, 2017

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

yajo commented Nov 15, 2017

JordiBForgeFlow commented Nov 17, 2017

pedrobaeza commented Nov 17, 2017

JordiBForgeFlow commented Nov 17, 2017

pedrobaeza commented Nov 17, 2017

yajo commented Nov 20, 2017

JordiBForgeFlow commented Nov 21, 2017

pedrobaeza commented Nov 21, 2017

pedrobaeza commented Nov 21, 2017

JordiBForgeFlow commented Nov 21, 2017

JordiBForgeFlow commented Oct 13, 2017 •

edited by yajo

Loading

MiquelRForgeFlow Nov 6, 2017 •

edited

Loading

MiquelRForgeFlow left a comment •

edited

Loading