Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX] Prevent flake8 error for non-critical bare except. #506

Merged
merged 2 commits into from
Oct 29, 2017

Conversation

NL66278
Copy link
Contributor

@NL66278 NL66278 commented Oct 23, 2017

I am getting Travis errors on flake8 because of a bare except in the base_location_nuts module. The bare except in this particulare case should not be any problem. Added just a #noqa comment to ignore it.

@pedrobaeza
Copy link
Member

Can't we be more specific about the exception? Maybe it's ValueError

@yajo yajo closed this Oct 25, 2017
@yajo yajo reopened this Oct 25, 2017
@yajo
Copy link
Member

yajo commented Oct 25, 2017

Oops, butterfingers... Yep, I agree with @pedrobaeza

@rafaelbn rafaelbn added this to the 10.0 milestone Oct 26, 2017
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-tracking this

@pedrobaeza pedrobaeza merged commit 4b981ac into OCA:10.0 Oct 29, 2017
agaldona pushed a commit to avanzosc/partner-contact that referenced this pull request Nov 14, 2017
oihane pushed a commit to avanzosc/partner-contact that referenced this pull request Dec 4, 2017
yajo pushed a commit to avanzosc/partner-contact that referenced this pull request Dec 5, 2017
qtheuret pushed a commit to qtheuret/partner-contact that referenced this pull request Jan 3, 2018
tschanzt pushed a commit to camptocamp/partner-contact that referenced this pull request Apr 17, 2018
@NL66278 NL66278 deleted the 10.0-no-bare-except branch November 19, 2018 16:53
Tardo pushed a commit to Tecnativa/partner-contact that referenced this pull request May 14, 2019
chienandalu pushed a commit to Tecnativa/partner-contact that referenced this pull request Nov 28, 2019
kos94ok-3D pushed a commit to kos94ok-3D/partner-contact that referenced this pull request Mar 17, 2021
kv1612 pushed a commit to kv1612/partner-contact that referenced this pull request Oct 19, 2021
* [BSCOS-1038] Display factor pricelist on partners view

* fixup! [BSCOS-1038] Display factor pricelist on partners view

* fixup! fixup! [BSCOS-1038] Display factor pricelist on partners view

* fixup! fixup! fixup! [BSCOS-1038] Display factor pricelist on partners view
gaso pushed a commit to gaso/partner-contact that referenced this pull request Nov 29, 2021
pedrobaeza pushed a commit to gaso/partner-contact that referenced this pull request Sep 2, 2022
Vincenzo9191 pushed a commit to Vincenzo9191/partner-contact that referenced this pull request Nov 11, 2022
SoporteOperu pushed a commit to pegonzalezspesol/partner-contact that referenced this pull request Jan 11, 2023
FrancescoCosma pushed a commit to Vincenzo9191/partner-contact that referenced this pull request Jan 19, 2023
…except. (OCA#506)

OCA Transbot updated translations from Transifex
edlopen pushed a commit to moduon/partner-contact that referenced this pull request May 27, 2024
salvorapi pushed a commit to salvorapi/partner-contact that referenced this pull request Jul 5, 2024
anusriNPS pushed a commit to PyTech-SRL/partner-contact that referenced this pull request Jul 15, 2024
salvorapi pushed a commit to salvorapi/partner-contact that referenced this pull request Jul 22, 2024
salvorapi pushed a commit to salvorapi/partner-contact that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants