-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][FIX] Prevent flake8 error for non-critical bare except. #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't we be more specific about the exception? Maybe it's |
Oops, butterfingers... Yep, I agree with @pedrobaeza |
pedrobaeza
approved these changes
Oct 29, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast-tracking this
agaldona
pushed a commit
to avanzosc/partner-contact
that referenced
this pull request
Nov 14, 2017
oihane
pushed a commit
to avanzosc/partner-contact
that referenced
this pull request
Dec 4, 2017
yajo
pushed a commit
to avanzosc/partner-contact
that referenced
this pull request
Dec 5, 2017
qtheuret
pushed a commit
to qtheuret/partner-contact
that referenced
this pull request
Jan 3, 2018
tschanzt
pushed a commit
to camptocamp/partner-contact
that referenced
this pull request
Apr 17, 2018
Tardo
pushed a commit
to Tecnativa/partner-contact
that referenced
this pull request
May 14, 2019
chienandalu
pushed a commit
to Tecnativa/partner-contact
that referenced
this pull request
Nov 28, 2019
kos94ok-3D
pushed a commit
to kos94ok-3D/partner-contact
that referenced
this pull request
Mar 17, 2021
kv1612
pushed a commit
to kv1612/partner-contact
that referenced
this pull request
Oct 19, 2021
* [BSCOS-1038] Display factor pricelist on partners view * fixup! [BSCOS-1038] Display factor pricelist on partners view * fixup! fixup! [BSCOS-1038] Display factor pricelist on partners view * fixup! fixup! fixup! [BSCOS-1038] Display factor pricelist on partners view
gaso
pushed a commit
to gaso/partner-contact
that referenced
this pull request
Nov 29, 2021
pedrobaeza
pushed a commit
to gaso/partner-contact
that referenced
this pull request
Sep 2, 2022
Vincenzo9191
pushed a commit
to Vincenzo9191/partner-contact
that referenced
this pull request
Nov 11, 2022
SoporteOperu
pushed a commit
to pegonzalezspesol/partner-contact
that referenced
this pull request
Jan 11, 2023
FrancescoCosma
pushed a commit
to Vincenzo9191/partner-contact
that referenced
this pull request
Jan 19, 2023
…except. (OCA#506) OCA Transbot updated translations from Transifex
edlopen
pushed a commit
to moduon/partner-contact
that referenced
this pull request
May 27, 2024
salvorapi
pushed a commit
to salvorapi/partner-contact
that referenced
this pull request
Jul 5, 2024
anusriNPS
pushed a commit
to PyTech-SRL/partner-contact
that referenced
this pull request
Jul 15, 2024
salvorapi
pushed a commit
to salvorapi/partner-contact
that referenced
this pull request
Jul 22, 2024
salvorapi
pushed a commit
to salvorapi/partner-contact
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting Travis errors on flake8 because of a bare except in the base_location_nuts module. The bare except in this particulare case should not be any problem. Added just a #noqa comment to ignore it.