-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig partner contact birthdate #509
Conversation
OCA#315) [MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10
Setting as WIP until partner_contact_personal_information_page is merged |
Module partner_contact_personal_information_page is in issue #511 |
Ok 👍 |
inverse="_birthdate_inverse", | ||
store=True) | ||
|
||
@api.one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using api.one and not api.multi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add oca-decorators
to the python dependencies, then switch to oca.decorators.foreach
"""Store a string of the new date in the old field.""" | ||
self.birthdate = self.birthdate_date | ||
|
||
@api.one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using api.one and not api.multi?
# Copyright (C) 2014-2015 Grupo ESOC <www.grupoesoc.es> | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
# © 2017-Apertoso N.V. (<http://www.apertoso.be>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change does not warrant the addition of your copyright IMO. Same goes for all the files.
Are you going to work on this PR anymore? We are in the code sprint and we need it as dependency |
error tells partner_contact_personal_information_page isnt available, but it is in the repo? |
birthdate_date = fields.Date("Birthdate") | ||
|
||
# Make the old Char field to reflect the new Date field | ||
birthdate = fields.Char( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jprobineau , In V11 Odoo has removed this field. Is there any interest to reintroduce it here?
Superseeded by #617 |
No description provided.