Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig partner contact birthdate #509

Closed

Conversation

jprobineau
Copy link

No description provided.

Jairo Llopis and others added 30 commits October 31, 2017 11:41
Really I'm just renaming partner_contact_base.
The new name is more self-explanatory.
This reverts commit e170541.
This reverts commit e170541.
@pedrobaeza pedrobaeza mentioned this pull request Oct 31, 2017
53 tasks
@yajo yajo added this to the 11.0 milestone Oct 31, 2017
@yajo
Copy link
Member

yajo commented Oct 31, 2017

Setting as WIP until partner_contact_personal_information_page is merged

@jprobineau
Copy link
Author

Module partner_contact_personal_information_page is in issue #511

@simoneversienti
Copy link

Ok 👍

inverse="_birthdate_inverse",
store=True)

@api.one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using api.one and not api.multi?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add oca-decorators to the python dependencies, then switch to oca.decorators.foreach

"""Store a string of the new date in the old field."""
self.birthdate = self.birthdate_date

@api.one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using api.one and not api.multi?

# Copyright (C) 2014-2015 Grupo ESOC <www.grupoesoc.es>
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
# © 2017-Apertoso N.V. (<http://www.apertoso.be>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not warrant the addition of your copyright IMO. Same goes for all the files.

@pedrobaeza
Copy link
Member

Are you going to work on this PR anymore? We are in the code sprint and we need it as dependency

@ghost
Copy link

ghost commented Jul 28, 2018

error tells partner_contact_personal_information_page isnt available, but it is in the repo?

birthdate_date = fields.Date("Birthdate")

# Make the old Char field to reflect the new Date field
birthdate = fields.Char(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jprobineau , In V11 Odoo has removed this field. Is there any interest to reintroduce it here?

@pedrobaeza
Copy link
Member

Superseeded by #617

@pedrobaeza pedrobaeza closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.