Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] 11.0 - partner auto salesman #542

Closed

Conversation

JayVora-SerpentCS
Copy link
Contributor

Migrated the Auto salesman module.

@JayVora-SerpentCS JayVora-SerpentCS mentioned this pull request Jan 3, 2018
53 tasks
@pedrobaeza
Copy link
Member

Please respect commit history following migration guide.

Joao Alfredo Gama Batista and others added 5 commits January 3, 2018 19:15
@JayVora-SerpentCS
Copy link
Contributor Author

@pedrobaeza Corrected it myself

@pedrobaeza
Copy link
Member

OK, it seems so. Now tasks to do:

  • Squash together adjacent "OCA Transbot..." commits
  • Check Travis status.

@JayVora-SerpentCS JayVora-SerpentCS force-pushed the 11.0-partner_auto_salesman branch 2 times, most recently from 297c047 to 543c453 Compare January 4, 2018 06:47
@JayVora-SerpentCS
Copy link
Contributor Author

Merged Transbot commits and travis goes green! Thanks @pedrobaeza

@@ -0,0 +1,15 @@
OpenERP, Open Source Management Solution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this file is not needed, and in any case this is not the AGPL license text.

Installation
============

There are no special instructions regarding installation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove section then.

Configuration
=============

No configuration is needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove too

Known issues / Roadmap
======================

* No known issues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -0,0 +1,4 @@
# -*- coding: utf-8 -*-
# See LICENSE file for full copyright and licensing details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,16 @@
# -*- coding: utf-8 -*-
# See LICENSE file for full copyright and licensing details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

'version': '11.0.0.1.0',
'category': 'Customer Relationship Management',
'complexity': "easy",
'description': """Fill the salesman field with the current user id""",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, we have a README

@@ -0,0 +1,4 @@
# -*- coding: utf-8 -*-
# See LICENSE file for full copyright and licensing details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@@ -0,0 +1,14 @@
# -*- coding: utf-8 -*-
# See LICENSE file for full copyright and licensing details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@JayVora-SerpentCS
Copy link
Contributor Author

Ping @yajo

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general terms, this addon is not strictly needed.

You can set default values in a per user basis through the debug menu in i.e. the partners view:

captura de pantalla de 2018-02-08 08-36-23
captura de pantalla de 2018-02-08 08-37-07

But I guess it can have sense under some circumstances.

In any case, there's still something remaining.

class Partner(models.Model):
_inherit = 'res.partner'

user_id = fields.Many2one('res.users',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field already exists upstream, so don't redefine everything; just the things that change (actually, the default value).

'category': 'Customer Relationship Management',
'complexity': "easy",
'author': "Savoir-faire Linux,Odoo Community Association (OCA)",
'website': 'http://www.savoirfairelinux.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,4 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From 11.0 onwards (python 3.x) no more coding lines needed.

Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment and those of others.

@NL66278
Copy link
Contributor

NL66278 commented Apr 28, 2020

No action on comments.

@NL66278 NL66278 closed this Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants