-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] 11.0 - partner auto salesman #542
[MIG] 11.0 - partner auto salesman #542
Conversation
Please respect commit history following migration guide. |
939b386
to
47fabb7
Compare
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
47fabb7
to
40bb0db
Compare
@pedrobaeza Corrected it myself |
OK, it seems so. Now tasks to do:
|
297c047
to
543c453
Compare
Merged Transbot commits and travis goes green! Thanks @pedrobaeza |
@@ -0,0 +1,15 @@ | |||
OpenERP, Open Source Management Solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this file is not needed, and in any case this is not the AGPL license text.
partner_auto_salesman/README.rst
Outdated
Installation | ||
============ | ||
|
||
There are no special instructions regarding installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove section then.
partner_auto_salesman/README.rst
Outdated
Configuration | ||
============= | ||
|
||
No configuration is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove too
partner_auto_salesman/README.rst
Outdated
Known issues / Roadmap | ||
====================== | ||
|
||
* No known issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
partner_auto_salesman/__init__.py
Outdated
@@ -0,0 +1,4 @@ | |||
# -*- coding: utf-8 -*- | |||
# See LICENSE file for full copyright and licensing details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use headers from template please
@@ -0,0 +1,16 @@ | |||
# -*- coding: utf-8 -*- | |||
# See LICENSE file for full copyright and licensing details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
'version': '11.0.0.1.0', | ||
'category': 'Customer Relationship Management', | ||
'complexity': "easy", | ||
'description': """Fill the salesman field with the current user id""", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove, we have a README
@@ -0,0 +1,4 @@ | |||
# -*- coding: utf-8 -*- | |||
# See LICENSE file for full copyright and licensing details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
@@ -0,0 +1,14 @@ | |||
# -*- coding: utf-8 -*- | |||
# See LICENSE file for full copyright and licensing details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
543c453
to
a1a2545
Compare
Ping @yajo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class Partner(models.Model): | ||
_inherit = 'res.partner' | ||
|
||
user_id = fields.Many2one('res.users', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field already exists upstream, so don't redefine everything; just the things that change (actually, the default value).
'category': 'Customer Relationship Management', | ||
'complexity': "easy", | ||
'author': "Savoir-faire Linux,Odoo Community Association (OCA)", | ||
'website': 'http://www.savoirfairelinux.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO Please change URL as described in https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L10
@@ -0,0 +1,4 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From 11.0 onwards (python 3.x) no more coding lines needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment and those of others.
No action on comments. |
Migrated the Auto salesman module.