Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 mig partner email check #543

Merged
merged 4 commits into from
Apr 23, 2019
Merged

11.0 mig partner email check #543

merged 4 commits into from
Apr 23, 2019

Conversation

denislour
Copy link
Contributor

Migrate partner_email_check to version 11.0 from version 10.0.

@oca-clabot
Copy link

Hey @denislour, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • huy (no github login found)

Appreciation of efforts,
OCA CLAbot

@denislour denislour force-pushed the 11.0-mig-partner_email_check branch 3 times, most recently from 09fe32f to 17cabff Compare January 4, 2018 03:56
@denislour
Copy link
Contributor Author

@yajo, I included commits from previous branches.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jan 4, 2018
hieulucky111
hieulucky111 reviewed May 11, 2018
View reviewed changes
partner_email_check/README.rst
@@ -0,0 +1,56 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the guideline: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

hieulucky111
hieulucky111 approved these changes May 11, 2018
View reviewed changes
Copy link

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor adjustments, LGTM over all.

rafaelbn
rafaelbn reviewed May 16, 2018
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test this one. Rebuilding for testing

partner_email_check/__manifest__.py Outdated
'version': '11.0.1.0.0',
'summary': 'Validate email address field',
'author': "Komit, Odoo Community Association (OCA)",
'website': 'http://komit-consulting.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change URL as described in https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py#L9

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated link: https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py#L10

@angelmoya
Copy link
Member

Also you can remove copyright info on "__init__.py"

After some remarks LGTM

@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 28, 2018
Closed
53 tasks
NL66278
NL66278 reviewed Mar 13, 2019
View reviewed changes
partner_email_check/__init__.py Outdated
@@ -0,0 +1,4 @@
# Copyright 2017 Komit <http://komit-consulting.com>
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https: on the license lines of all files.

NL66278
NL66278 reviewed Mar 13, 2019
View reviewed changes
partner_email_check/models/res_partner.py Outdated
def email_check(self, email):
if validate_email(email):
return True
else:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the else. If you do not return on the previous line, you can raise an error.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278
Copy link
Contributor

NL66278 commented Apr 22, 2019

@denislour Please take up the comments, or answer them. Then I will be able to merge the PR.

@denislour
Copy link
Contributor Author

@NL66278 Sr for my delay, I updated this PR.

@NL66278 NL66278 merged commit 7ab16dd into OCA:11.0 Apr 23, 2019
@rafaelbn
Copy link
Member

Very nice feature to include in Odoo core in v13 @fgi-odoo

Like: https://github.com/odoo/odoo/tree/12.0/addons/phone_validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn left review comments

@NL66278 NL66278 NL66278 left review comments

@jcdrubay jcdrubay jcdrubay left review comments

@congdpt congdpt congdpt approved these changes

@hieulucky111 hieulucky111 hieulucky111 approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.