Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 mig base partner merge #545

Closed

Conversation

JayVora-SerpentCS
Copy link
Contributor

Module Migrated to 11.0

@JayVora-SerpentCS JayVora-SerpentCS mentioned this pull request Jan 9, 2018
53 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jan 9, 2018
Copy link

@tschanzt tschanzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor stuff:

  • The utf-8 header isn't needed anymore for python3.
  • Remove the .pot file, since they aren't stored in the module anymore.

Otherwise i tested it and it works. 👍

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from @tschanzt remarks, LGTM

Author
------

Yannick Vaucher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add email <yannick.vaucher@camptocamp.com> and "Do not contact contributors directly about support or help with technical issues." see https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove coding headers

'summary': "Partner merge wizard without dependency on CRM",
'category': 'Generic Modules/Base',
'author': "Camptocamp,Odoo Community Association (OCA)",
'license': 'AGPL-3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 'website': 'https://github.com/OCA/partner-contact',

<field name="context">{'active_test': False}</field>
</record>

<record model='ir.ui.view' id='base_partner_merge_automatic_wizard_form'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls do not mixup quotes: use double quotes all around

<button name="%(action_partner_deduplicate)d" string="Deduplicate the other Contacts" class="oe_highlight"
type="action"/>
</group>
<p class="oe_grey" attrs="{'invisible': [('state', '!=', ('option'))]}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not wrap option w/ parenthesis: [('state', '!=', 'option')]

<field name='arch' type='xml'>
<form string='Automatic Merge Wizard'>
<sheet>
<group attrs="{'invisible': [('state', '!=', 'finished')]}" col="1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a name to this group

Odoo will propose you to merge only those having
all these fields in common. (not one of the fields).
</p>
<group attrs="{'invisible': ['|', ('state', 'not in', ('selection', 'finished')), ('number_group', '=', 0)]}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here and all the other groups

# Copyright 2016 Camptocamp SA
# Copyright 2017 Jarsa Sistemas
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
from odoo.addons.crm.wizard.base_partner_merge import * # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we import only 2 things: MergePartnerLine and MergePartnerAutomatic -> remove the wildcard

@simahawk
Copy link
Contributor

@JayVora-SerpentCS ping :)

@JayVora-SerpentCS
Copy link
Contributor Author

checking

@yvaucher
Copy link
Member

LGTM, I'll merge and squash the last commits in one.

@yvaucher
Copy link
Member

Merged at 66d236f

@yvaucher yvaucher closed this Jun 28, 2018
@yvaucher
Copy link
Member

Thank you @JayVora-SerpentCS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.