-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig base partner merge #545
11.0 mig base partner merge #545
Conversation
…unt_report_company
…rge.automatic.wizard should not have explicit access rules
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
base_partner_merge makes use of message_post(), which is defined in mail addon.
[9.0][PORT] base_partner_merge
00f5a58
to
bbbc039
Compare
bbbc039
to
a31d8b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor stuff:
- The utf-8 header isn't needed anymore for python3.
- Remove the .pot file, since they aren't stored in the module anymore.
Otherwise i tested it and it works. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from @tschanzt remarks, LGTM
base_partner_merge/README.rst
Outdated
Author | ||
------ | ||
|
||
Yannick Vaucher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add email <yannick.vaucher@camptocamp.com>
and "Do not contact contributors directly about support or help with technical issues." see https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
base_partner_merge/__init__.py
Outdated
@@ -0,0 +1,5 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove coding headers
base_partner_merge/__manifest__.py
Outdated
'summary': "Partner merge wizard without dependency on CRM", | ||
'category': 'Generic Modules/Base', | ||
'author': "Camptocamp,Odoo Community Association (OCA)", | ||
'license': 'AGPL-3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add 'website': 'https://github.com/OCA/partner-contact',
<field name="context">{'active_test': False}</field> | ||
</record> | ||
|
||
<record model='ir.ui.view' id='base_partner_merge_automatic_wizard_form'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls do not mixup quotes: use double quotes all around
<button name="%(action_partner_deduplicate)d" string="Deduplicate the other Contacts" class="oe_highlight" | ||
type="action"/> | ||
</group> | ||
<p class="oe_grey" attrs="{'invisible': [('state', '!=', ('option'))]}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not wrap option
w/ parenthesis: [('state', '!=', 'option')]
<field name='arch' type='xml'> | ||
<form string='Automatic Merge Wizard'> | ||
<sheet> | ||
<group attrs="{'invisible': [('state', '!=', 'finished')]}" col="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a name to this group
Odoo will propose you to merge only those having | ||
all these fields in common. (not one of the fields). | ||
</p> | ||
<group attrs="{'invisible': ['|', ('state', 'not in', ('selection', 'finished')), ('number_group', '=', 0)]}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here and all the other groups
# Copyright 2016 Camptocamp SA | ||
# Copyright 2017 Jarsa Sistemas | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
from odoo.addons.crm.wizard.base_partner_merge import * # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems we import only 2 things: MergePartnerLine
and MergePartnerAutomatic
-> remove the wildcard
@JayVora-SerpentCS ping :) |
checking |
LGTM, I'll merge and squash the last commits in one. |
Merged at 66d236f |
Thank you @JayVora-SerpentCS |
Module Migrated to 11.0