Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][11.0] Migration of partner_affiliate to v11 #579

Merged
merged 4 commits into from
Apr 24, 2018
Merged

[MIG][11.0] Migration of partner_affiliate to v11 #579

merged 4 commits into from
Apr 24, 2018

Conversation

BT-rmartin
Copy link

No description provided.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Apr 12, 2018
@pedrobaeza pedrobaeza mentioned this pull request Apr 12, 2018
53 tasks
@pedrobaeza
Copy link
Member

Please check runbot warning:

2018-04-12 09:31:05,858 168 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view res.partner.form (): use the hasclass(*classes) function to filter elements by their classes
2018-04-12 09:31:05,966 168 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view res.partner.form (partner_affiliate.view_partner_form_add_affiliate): use the hasclass(*classes) function to filter elements by their classes

"""Add relation affiliate_ids."""
_inherit = "res.partner"

child_ids = fields.One2many(domain=[('is_company', '=', False)])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though not mandatory, its good to specify string attribute

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am even in the favour of writing full details of the field like you did for affilate_ids.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot functionaly 👍

Thanks!

Please @JayVora-SerpentCS @pedrobaeza take a look

@BT-rmartin
Copy link
Author

Two reviewers approved it. In order to be merged, is any other review needed?
@JayVora-SerpentCS @pedrobaeza @rafaelbn

@rafaelbn rafaelbn merged commit e2d52e6 into OCA:11.0 Apr 24, 2018
BT-rmartin referenced this pull request in brain-tec/partner-contact May 28, 2018
[FIX] disable position editing on contact

- This is just to see all positions
- If we want to add position go to one company and add contact linked to this partner

[ADD] setup.py [ci skip]

[MIG][11.0] Migration of partner_affiliate to v11 (#579)

* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

[ADD] setup.py

[IMP] base_location: Include onchange for state

Incredibly not included in Odoo core.

[IMP] base_location: name_search improvement (#585)

Fixing travis errors
tarteo pushed a commit to tarteo/partner-contact that referenced this pull request Oct 24, 2018
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors
victormmtorres pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 25, 2019
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors
StephanRozendaal pushed a commit to StephanRozendaal/partner-contact that referenced this pull request Dec 12, 2019
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors
StephanRozendaal pushed a commit to StephanRozendaal/partner-contact that referenced this pull request Dec 12, 2019
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
manuelcalerosolis pushed a commit to Tecnativa/partner-contact that referenced this pull request Mar 24, 2020
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
AMhadhbi pushed a commit to AMhadhbi/partner-contact that referenced this pull request Feb 6, 2021
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
AMhadhbi pushed a commit to AMhadhbi/partner-contact that referenced this pull request Feb 6, 2021
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
emagdalenaC2i pushed a commit to Change2improve/partner-contact that referenced this pull request Feb 6, 2022
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
FernandoRomera pushed a commit to MallorcaSoft/partner-contact that referenced this pull request Dec 16, 2022
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request Feb 3, 2023
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
edlopen pushed a commit to moduon/partner-contact that referenced this pull request Mar 1, 2024
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
Deriman-Alonso pushed a commit to Deriman-Alonso/partner-contact that referenced this pull request Apr 19, 2024
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
Deriman-Alonso pushed a commit to Deriman-Alonso/partner-contact that referenced this pull request Jul 8, 2024
* [MIG] Migration of partner_affiliate to v11

* Fixing use of @Class and do not inheriting address from parent company

* Improving legibility and details of fields

* Fixing travis errors

remove obsolete .pot files [ci skip]

[UPD] Update partner_affiliate.pot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants