[MIG] partner_contact_lang: Migration to 11.0 #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cristinamartinrod please make the agreed changes |
tafaRU
reviewed
Oct 9, 2018
| self.partner.lang = 'en_US' | ||
| self.assertEqual(self.contact.lang, 'en_US') | ||
| self.assertEqual(self.partner.lang, 'en_US') |
There was a problem hiding this comment.
why did you change the unit test?
There was a problem hiding this comment.
This one is incorrect right now and it's not testing what the module does. I'll change it.
=========================== Manage language in contacts =========================== Odoo by default propagate language field to the created contacts from their form, but it doesn't allow to change it once created. This module fills this gap, and also provides other facilities for the contact language management: * Put the language of the parent company when the contact doesn't have a language and this parent company is assigned. * When the company changes the language, it fills with the same language all the contacts that don't have any. Usage ===== Go to any partner that is a company and has contacts. Click on one contact and you will be able to edit the language.
pedrobaeza
force-pushed
the
11.0-mig-partner_contact_lang
branch
from
d88f195 to
2881438
Compare
tafaRU
approved these changes
Oct 10, 2018
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Odoo by default propagate language field to the created contacts from their form, but it doesn't allow to change it once created. This module fills this gap, and also provides other facilities for the
contact language management:
cc @Tecnativa