Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0] [MIG] partner_capital #661

Closed
wants to merge 6 commits into from
Closed

[11.0] [MIG] partner_capital #661

wants to merge 6 commits into from

Conversation

remihb
Copy link

@remihb remihb commented Nov 22, 2018

No description provided.

@oca-clabot
Copy link

Hey @remihb, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 11.0 milestone Nov 22, 2018
@pedrobaeza
Copy link
Member

Please squash together adjacent "OCA Transbot.." commits using https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@pedrobaeza pedrobaeza mentioned this pull request Nov 22, 2018
Closed
53 tasks
@remihb remihb force-pushed the 11.0-mig-partner_capital branch from 62be2fe to 990cfb2 Compare November 22, 2018 16:24
@oca-clabot
Copy link

Hey @remihb, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@remihb
Copy link
Author

remihb commented Nov 22, 2018

Does the 'oca-travis' commits have to be squash too ?

@pedrobaeza
Copy link
Member

I think they are good now, thanks. Please check CLA part.

NL66278
NL66278 reviewed Sep 28, 2020
View reviewed changes
partner_capital/readme/DESCRIPTION.rst
@@ -0,0 +1 @@
Bla test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more details might be added here...

NL66278
NL66278 requested changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM but one change is needed. Also consider to change license lines in headers from http to https. And please sign CLA if not already done.

partner_capital/__manifest__.py
@@ -0,0 +1,23 @@
# Copyright 2015 Antonio Espinosa <antonio.espinosa@tecnativa.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the license key to this file to pass pylint checks.

@NL66278
Copy link
Contributor

NL66278 commented Oct 15, 2020

Requested changes not taken up, while travis failing.

@NL66278 NL66278 closed this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NL66278 NL66278 NL66278 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
8 participants
@remihb @oca-clabot @pedrobaeza @NL66278 @yajo @oca-transbot @chienandalu @oca-travis