[11.0][mig] partner_academic_title #719
Conversation
…ble to remove spaces in the separator definition by overriding the method _get_separator.
luismontalba
changed the title
luismontalba
force-pushed
the
11.0-mig-partner_academic_title
branch
from
f3362fa to
b14ad35
Compare
luismontalba
changed the title
luismontalba
force-pushed
the
11.0-mig-partner_academic_title
branch
from
b14ad35 to
982658e
Compare
|
@tbaden commits squashed |
| <!-- Copyright 2015-2017 ACSONE SA/NV | ||
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). --> | ||
| <odoo> | ||
| <data noupdate="1"> |
There was a problem hiding this comment.
data element is no longer needed. noupdate attribute can be added to odoo element. Please remove data and decrease indents of records.
| @@ -0,0 +1,16 @@ | |||
| # Copyright 2015-2017 ACSONE SA/NV (<http://acsone.eu>) | |||
There was a problem hiding this comment.
Put https: on copyright and license lines.
| return ', ' | ||
|
|
||
| @api.depends('academic_title_ids', 'academic_title_ids.sequence') | ||
| @api.one |
There was a problem hiding this comment.
@api.one is deprecated. Use self.ensure_one() as first line in method.
There was a problem hiding this comment.
Changes done, but ensure_one() causes an error when building the runbot instance because the method is applied on a set of records. Maybe iterating with something like "for rec in self" inside the function?
There was a problem hiding this comment.
Yes that would be the solution. I had not taken into account the possibility that this could be called for multiple records. for rec in self or for this in self as i prefer (but that is purely personal taste), is fine.
| display_title = "" | ||
| separator = self._get_separator() | ||
| title_ids = self.academic_title_ids.sorted(lambda r: r.sequence) | ||
| for title in title_ids: |
There was a problem hiding this comment.
More pythonic (and readable) to do something like separator.join([title.name for title in title_ids])
| <!-- Copyright 2015-2017 ACSONE SA/NV | ||
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). --> | ||
| <odoo> | ||
| <data> |
There was a problem hiding this comment.
Get rid of data tag here as well.
| class PartnerAcademicTitle(models.Model): | ||
| _name = 'partner.academic.title' | ||
|
|
||
| name = fields.Char(required=True, |
There was a problem hiding this comment.
Please use the same identation style here as for the field definitions in res_partner.py
luismontalba
force-pushed
the
11.0-mig-partner_academic_title
branch
4 times, most recently
from
d638bdb to
2bedb90
Compare
|
@NL66278 changes done, can I squash my commits? |
|
This PR has the |
luismontalba
force-pushed
the
11.0-mig-partner_academic_title
branch
from
2bedb90 to
8d0defe
Compare
|
OK, I didn't see the approval. Commits squashed |
Migration to 11.0.
This module was written to adds possibility to define some academic titles and
to add multiple titles on partners. there is a sequence on titles to display
them in an order on the partner.