Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13.0 mig base vat sanitized #821

Merged
merged 7 commits into from
Dec 17, 2019
Merged

13.0 mig base vat sanitized #821

merged 7 commits into from
Dec 17, 2019

Conversation

StephanRozendaal
Copy link
Contributor

No description provided.

@StephanRozendaal StephanRozendaal mentioned this pull request Dec 5, 2019
Open
47 tasks
@StephanRozendaal StephanRozendaal force-pushed the 13.0-mig-base_vat_sanitized branch from 7aad0f9 to 63c29b7 Compare December 5, 2019 11:01
alexis-via and others added 7 commits December 5, 2019 12:25
@alexis-via @StephanRozendaal
Add module base_vat_sanitized
bdafc25 
OCA Transbot updated translations from Transifex
@alexis-via @StephanRozendaal
Port base_vat_sanitized to v10
6951e6f 
OCA Transbot updated translations from Transifex
@astirpe @StephanRozendaal
[11.0][MIG] Port base_vat_sanitized to V11
8448aad 
OCA Transbot updated translations from Transifex

[UPD] Update base_vat_sanitized.pot

Translated using Weblate (German)

Currently translated at 100,0% (3 of 3 strings)

Translation: partner-contact-11.0/partner-contact-11.0-base_vat_sanitized
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_vat_sanitized/de/
@astirpe @StephanRozendaal
[12.0][MIG] base_vat_sanitized
2981b30 
[UPD] README.rst

[UPD] Update base_vat_sanitized.pot

Translated using Weblate (Portuguese (Brazil))

Currently translated at 66.7% (2 of 3 strings)

Translation: partner-contact-12.0/partner-contact-12.0-base_vat_sanitized
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_vat_sanitized/pt_BR/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-base_vat_sanitized
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_vat_sanitized/
@OCA-git-bot @StephanRozendaal
[ADD] icon.png
74937dc 
[UPD] README.rst

Translated using Weblate (Portuguese)

Currently translated at 100.0% (3 of 3 strings)

Translation: partner-contact-12.0/partner-contact-12.0-base_vat_sanitized
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_vat_sanitized/pt/

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (3 of 3 strings)

Translation: partner-contact-12.0/partner-contact-12.0-base_vat_sanitized
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_vat_sanitized/pt_BR/

Translated using Weblate (Croatian)

Currently translated at 100.0% (3 of 3 strings)

Translation: partner-contact-12.0/partner-contact-12.0-base_vat_sanitized
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_vat_sanitized/hr/
@StephanRozendaal
[IMP] : black, isort
14be541
@StephanRozendaal
[MIG] base_vat_sanitized: Migration to 13.0
07869c3
@StephanRozendaal StephanRozendaal force-pushed the 13.0-mig-base_vat_sanitized branch from 63c29b7 to 07869c3 Compare December 5, 2019 11:25
lfreeke
lfreeke approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@lfreeke lfreeke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test 👍

astirpe
astirpe approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@astirpe astirpe mentioned this pull request Dec 13, 2019
Merged
4 tasks
CasVissers-360ERP
CasVissers-360ERP approved these changes Dec 17, 2019
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astirpe
Copy link
Member

astirpe commented Dec 17, 2019

@pedrobaeza is it ok to merge this one?

@pedrobaeza
Copy link
Member

/ocabot merge

@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 17, 2019
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-821-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 17, 2019
@OCA-git-bot
Merge PR #821 into 13.0
5474662 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 07869c3 into OCA:13.0 Dec 17, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4bff332. Thanks a lot for contributing to OCA. ❤️

@alexis-via
Copy link
Contributor

I think it was a mistake to port this module, because the feature is now native in v13. The native code that handles this feature is located in the base_vat module, in models/res_partner.py at the very end of the file: it inherits write and create and calls the compact method of the stdnum lib, cf https://github.com/odoo/odoo/blob/13.0/addons/base_vat/models/res_partner.py#L466

So, what shall we do ?
I think we should remove the module, but maybe some people have already installed it, so maybe we should just add a note in the README and keep it like that.
At least, we won't use it in OCA/edi. The only thing to handle is data migration for those who upgrade from v12... but I guess it is something to handle in openupgrade.

@alexis-via
Copy link
Contributor

I made a small PR to add a note in the README about it #862

@astirpe astirpe mentioned this pull request May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfreeke lfreeke lfreeke approved these changes

@astirpe astirpe astirpe approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
7 participants
@StephanRozendaal @OCA-git-bot @astirpe @pedrobaeza @alexis-via @lfreeke @CasVissers-360ERP