Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] partner_contact_age_range: Migration to 14.0 #999

Merged
merged 4 commits into from
Jan 10, 2021
Merged

[14.0][MIG] partner_contact_age_range: Migration to 14.0 #999

merged 4 commits into from
Jan 10, 2021

Conversation

newtratip
Copy link
Member

@newtratip newtratip commented Oct 21, 2020 •
edited
Loading

Standard Migration

depends on

Update test script, Ready for review.

@newtratip newtratip mentioned this pull request Oct 21, 2020
Open
45 tasks
@rousseldenis rousseldenis added this to the 14.0 milestone Oct 21, 2020
@newtratip newtratip force-pushed the 14.0-mig-partner_contact_age_range branch from 0957677 to 0143da7 Compare October 21, 2020 08:31
@newtratip newtratip force-pushed the 14.0-mig-partner_contact_age_range branch 2 times, most recently from fb2e8dd to 84a5a5b Compare October 30, 2020 09:06
@newtratip newtratip force-pushed the 14.0-mig-partner_contact_age_range branch from 84a5a5b to 29bbb42 Compare October 30, 2020 09:11
tonygalmiche
tonygalmiche approved these changes Nov 4, 2020
View reviewed changes
Copy link

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : Functional review only with runbot

image

skeller1
skeller1 approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@skeller1 skeller1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM code and functional review locally

Maybe adding a constraint for negative age_from or age_to validation would be nice, but not blocking.
Thank you for your migration

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HaraldPanten
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-999-by-HaraldPanten-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 10, 2021
@OCA-git-bot
Merge PR #999 into 14.0
5695188 
Signed-off-by HaraldPanten
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-999-by-HaraldPanten-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1e376b0 into OCA:14.0 Jan 10, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8695123. Thanks a lot for contributing to OCA. ❤️

@newtratip newtratip deleted the 14.0-mig-partner_contact_age_range branch January 10, 2021 14:43
CLaurelB pushed a commit to vauxoo-dev/partner-contact that referenced this pull request Mar 6, 2024
@OCA-git-bot
Merge PR OCA#999 into 15.0
8b0157c 
Signed-off-by leemannd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@skeller1 skeller1 skeller1 approved these changes

@tonygalmiche tonygalmiche tonygalmiche approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@newtratip @OCA-git-bot @HaraldPanten @tonygalmiche @skeller1 @rousseldenis @ajayjaviya @oca-travis