Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] Advanced Payroll WIP #174

Draft
wants to merge 3 commits into
base: 18.0
Choose a base branch
from
Draft

[18.0] Advanced Payroll WIP #174

wants to merge 3 commits into from

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Dec 16, 2024

@dreispt dreispt marked this pull request as draft December 16, 2024 10:39
@dreispt dreispt force-pushed the 18-dr-wip branch 13 times, most recently from 42789aa to 78de250 Compare January 5, 2025 21:12
@nimarosa
Copy link
Contributor

nimarosa commented Jan 6, 2025

Hello @dreispt, some of this are great additions to payroll.

I suggest you if you want to be merged to separate the modules in different PRs.

Also, regarding the module salary_table, we are currently using the server-tools time conditions module to save such params and can be used in salary rules. Maybe you can take a look to it, the module is still in v14 for payroll. Maybe you find interesting proposing a migration (it should no be difficult)

@dreispt
Copy link
Member Author

dreispt commented Jan 6, 2025

@nimarosa Thank you for your comments, and please keep an eye here and continue providing feedback.
In particular I worry if some of the names chosen are too context specific, and better ones could be used.

This is a WIP and unstable.
More features/modules will be coming.
In its final form each commit will have its own PR.

Regarding the salary table, I quickly reviewed the 14.0 implementation, and it seems to only cover the case for global parameters.
The features required are more generic. Examples are given in the README.
Let me know if this makes sense.

Thanks

@nimarosa nimarosa added this to the 18.0 milestone Jan 6, 2025
@nimarosa
Copy link
Contributor

nimarosa commented Jan 6, 2025

Hello @dreispt,

Let me review in detail the modules you are proposing and I give you feedback and my opinion, I think some functionalities can be added directly to payroll, but I have to see it in detail.

Thanks for your contributions, I look forward to new changes.

@dreispt dreispt force-pushed the 18-dr-wip branch 7 times, most recently from bec32c6 to 0b4c8e3 Compare February 1, 2025 23:54
@dreispt dreispt force-pushed the 18-dr-wip branch 2 times, most recently from 9b61e04 to 3d6b4ea Compare February 23, 2025 18:02
@dreispt dreispt force-pushed the 18-dr-wip branch 3 times, most recently from 5d290de to 14877ba Compare February 26, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants