[17.0][MIG] pos_partner_firstname: Migration to 17.0 #1126

etobella · 2024-01-10T12:04:07Z

Refactoring to adapt to OWL 2.0

Changes applied to avoid an extra connection to server

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/it/

…es_order from POS frontend Otherwise they would get access error on ir.config_parameter Steps: - Create a user POS manager without administration rights - Using that user, open POS frontend

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

…to lastname

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_firstname/fr/

flotho · 2024-01-10T14:02:49Z

Hi @etobella , thanks for this.
Did you have a look to #1122 ?
Regards

etobella · 2024-01-10T14:17:46Z

Yes I checked it, but at the end I made it in my own way using their comments, as the approach was much better 😄

flotho · 2024-01-10T14:20:00Z

Hum thanks @etobella ,
@DorianMAG , could you have a look to the @etobella proposal ?

etobella · 2024-01-10T14:23:20Z

Also, I removed a connection to the server that was unnecessary 😄

cvinh

If we want to add a new partner with only firstname or lastname (not both)
We have an error
TypeError: this.showPopup is not a function
at PartnerDetailsEdit.saveChanges

etobella · 2024-01-12T10:16:51Z

It works now. Thanks for the review!

etobella · 2024-01-15T10:28:38Z

Actually, it has no sense to require both on PoS but only one on backend, I will keep the logic of backend.

One option would be to keep the same logic using a configuration parameter on backend and frontend. WDYT?

cvinh · 2024-01-15T16:34:30Z

Actually, it has no sense to require both on PoS but only one on backend, I will keep the logic of backend.

One option would be to keep the same logic using a configuration parameter on backend and frontend. WDYT?

I agree. BTW in v16, firstname AND lastname are mandatory... @robyf70 do you know if it was a requirement for anyone ?
@alexis-via

robyf70 · 2024-01-15T16:50:23Z

Actually, it has no sense to require both on PoS but only one on backend, I will keep the logic of backend.
One option would be to keep the same logic using a configuration parameter on backend and frontend. WDYT?

I agree. BTW in v16, firstname AND lastname are mandatory... @robyf70 do you know if it was a requirement for anyone ? @alexis-via

This module was done to give the possibility to create a contact as person from the PoS as well

cvinh · 2024-01-15T16:52:09Z

pos_partner_firstname/static/src/app/PartnerDetailsEdit.esm.js

+                return this.popup.add(ErrorPopup, {
+                    title: _t("Missing information"),
+                    body: _t("Customer firstname or lastname are required"),
+                });


It should be 'Customer firstname or lastname is required'

cvinh · 2024-01-15T17:02:11Z

Actually, it has no sense to require both on PoS but only one on backend, I will keep the logic of backend.
One option would be to keep the same logic using a configuration parameter on backend and frontend. WDYT?

I agree. BTW in v16, firstname AND lastname are mandatory... @robyf70 do you know if it was a requirement for anyone ? @alexis-via

This module was done to give the possibility to create a contact as person from the PoS as well

Thanks @robyf70 we noticed that firstname AND lastname were mandatory in previous versions. The idea is to follow partner_firstname logical which allows partner with firstname OR lastname
@etobella if there's a configuration parameter then it's logical to add it in partner_firstname and inherit it
IMHO I'm approving as it is

Refactoring to OWL 2.0 Disabling an extra connection to server

etobella · 2024-01-17T17:00:34Z

Well, adding the constrain might seem a good idea, but we must remember that some countries do not have lastname, so it makes sense to not make it required

cvinh

Functional test ok

etobella · 2024-01-24T08:19:55Z

/ocabot merge nobump

OCA-git-bot · 2024-01-24T08:20:03Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1126-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-24T08:25:51Z

Congratulations, your PR was merged at 712663c. Thanks a lot for contributing to OCA. ❤️

robyf70 and others added 30 commits January 10, 2024 11:52

[NEW][10.0] POS partner firstname support

ea2ab07

porting pos_partner_firstname to 12

408740e

[UPD] Update pos_partner_firstname.pot

9ff0e0f

[UPD] README.rst

0d8bad9

[ADD] icon.png

f825821

Added translation using Weblate (Catalan)

9a315c2

Added translation using Weblate (Spanish)

6c971d2

Added translation using Weblate (Catalan)

24a8ddd

Translated using Weblate (Catalan)

a5fbddf

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Translated using Weblate (Spanish)

684393d

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

[FIX] new line on customer name label

1077118

[UPD] Update pos_partner_firstname.pot

0722d04

Update translation files

f9878e6

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

Added translation using Weblate (Italian)

d2f1ac3

Translated using Weblate (Italian)

2418546

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/it/

FIX pos_partner_firstname allowing non admin users to get partner_nam…

89bc17f

…es_order from POS frontend Otherwise they would get access error on ir.config_parameter Steps: - Create a user POS manager without administration rights - Using that user, open POS frontend

pos_partner_firstname 12.0.1.1.0

ea6babf

Translated using Weblate (Catalan)

6e5ec2e

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/ca/

Translated using Weblate (Spanish)

5591bc3

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/es/

Added translation using Weblate (French (Switzerland))

263b568

Translated using Weblate (French (Switzerland))

274a8ab

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

Translated using Weblate (French (Switzerland))

64b8f12

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

Translated using Weblate (French (Switzerland))

a937ffe

Currently translated at 100.0% (4 of 4 strings) Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/fr_CH/

IMP pos_partner_firstname allowing to use tab to move from firstname …

8a53fbb

…to lastname

[UPD] Update pos_partner_firstname.pot

f443c5e

pos_partner_firstname 12.0.1.1.1

aa34f0d

Update translation files

04a4b19

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

[UPD] Update pos_partner_firstname.pot

47d17e9

Update translation files

09bc4e1

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_partner_firstname/

[IMP] pos_partner_firstname: isort, black, prettier.

b2dd96c

Alexis de Lattre and others added 2 commits January 10, 2024 11:52

Translated using Weblate (French)

c07a188

Currently translated at 100.0% (8 of 8 strings) Translation: pos-16.0/pos-16.0-pos_partner_firstname Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_firstname/fr/

[IMP] pos_partner_firstname: Black, isort, prettier

b951f8c

cvinh approved these changes Jan 10, 2024

View reviewed changes

cvinh suggested changes Jan 10, 2024

View reviewed changes

etobella force-pushed the 17.0-mig-pos_partner_firstname branch from 46ba113 to f25d6df Compare January 12, 2024 10:16

etobella force-pushed the 17.0-mig-pos_partner_firstname branch from f25d6df to a46a35e Compare January 15, 2024 10:41

cvinh mentioned this pull request Jan 15, 2024

[16.0] pos_partner_firstname: fix string #1074

Closed

cvinh reviewed Jan 15, 2024

View reviewed changes

[MIG] pos_partner_firstname: Migration 17.0

3ba9a89

Refactoring to OWL 2.0 Disabling an extra connection to server

etobella force-pushed the 17.0-mig-pos_partner_firstname branch from a46a35e to 3ba9a89 Compare January 17, 2024 16:41

cvinh approved these changes Jan 17, 2024

View reviewed changes

kluna1998 approved these changes Jan 24, 2024

View reviewed changes

OCA-git-bot added the approved label Jan 24, 2024

OCA-git-bot added the bot is merging ⏳ label Jan 24, 2024

OCA-git-bot merged commit da6e6a6 into OCA:17.0 Jan 24, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] pos_partner_firstname: Migration to 17.0 #1126

[17.0][MIG] pos_partner_firstname: Migration to 17.0 #1126

etobella commented Jan 10, 2024

flotho commented Jan 10, 2024

etobella commented Jan 10, 2024

flotho commented Jan 10, 2024

etobella commented Jan 10, 2024

cvinh left a comment

etobella commented Jan 12, 2024

etobella commented Jan 15, 2024

cvinh commented Jan 15, 2024

robyf70 commented Jan 15, 2024

cvinh Jan 15, 2024

cvinh commented Jan 15, 2024

etobella commented Jan 17, 2024

cvinh left a comment

etobella commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

[17.0][MIG] pos_partner_firstname: Migration to 17.0 #1126

[17.0][MIG] pos_partner_firstname: Migration to 17.0 #1126

Conversation

etobella commented Jan 10, 2024

flotho commented Jan 10, 2024

etobella commented Jan 10, 2024

flotho commented Jan 10, 2024

etobella commented Jan 10, 2024

cvinh left a comment

Choose a reason for hiding this comment

etobella commented Jan 12, 2024

etobella commented Jan 15, 2024

cvinh commented Jan 15, 2024

robyf70 commented Jan 15, 2024

cvinh Jan 15, 2024

Choose a reason for hiding this comment

cvinh commented Jan 15, 2024

etobella commented Jan 17, 2024

cvinh left a comment

Choose a reason for hiding this comment

etobella commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024