[14.0][MIG] pos_payment_terminal #572

alexis-via · 2020-12-17T09:11:23Z

This PR works and has been tested on real Ingenico card reader (for France, with Telium) connected via pywebdriver (master branch).

It is a full re-write of the module, in order to take advantage of the new payment interface JS framework of Odoo POS.

FR translation updated.

…ixing unit_price computation on adding orderLine

PEP8 stuff

…screen

pos_customer_display: FIX JS code and make it more robust

Adapt JS code of pos_payment_terminal Some cleanup

…tion !) Move CSS definition from pos_payment_terminal_view.xml to pos_payment_terminal.xml Small cleanups

…sed with the module pos_pay_invoice

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

… to new API pos_payment_terminal: code cleanup

Move description from __openerp__.py to README.rst Update demo data

…debase to properly get the 'name' of the currency

sbidoul · 2021-02-16T12:09:42Z

@alexis-via this is not finished, right ?

This module needs to support send_payment_cancel and send_payment_request must return a promise that manages the transaction status via the change:status event and the payment transactions list we get in it.

Are you or @PierrickBrun working on this these days ? Shall we coordinate or efforts ?

Have send_payment_request return a promise as requested by the documentation. This open the door to handling the transaction status reported by the terminal driver asynchronously. Also, catch errors when sending the transaction start command.

sbidoul · 2021-02-17T09:44:28Z

@alexis-via I made this PR green in akretion#20 and improved it a little bit.

Now I'll work on handling the transaction statuses from the payment terminal drivers, compatible with pywebdriver.

[14.0] pos_payment_terminal migration improvements

sbidoul · 2021-02-17T10:55:29Z

@ivantodorovich @legalsylvain your review comments have been processed.

sbidoul · 2021-02-17T11:02:51Z

BTW, when the transaction has been sent to the terminal, this is what happens in the POS - I post this so others don't have to research why this is normal :)

This is normal behaviour until we have transaction status from the driver: the user has to manually confirm that the transaction suceeded by clicking "Force done". The "Connection error" message is hard coded in Odoo.

ivantodorovich

LGTM! 👍

Please squash migration commits before merging

sbidoul · 2021-02-17T11:05:25Z

Please squash migration commits before merging

Well, there are two authors and this is more a rewrite than a migration, and the commit history helps understand why things are as they are.

ivantodorovich · 2021-02-17T11:10:26Z

Please squash migration commits before merging

Well, there are two authors and this is more a rewrite than a migration, and the commit history helps understand why things are as they are.

I'd at least clean a bit the commits, whilst keeping the authors

For instance there are commits like

pos_payment_terminal: remove commented lines,
pos_payment_terminal: remove dead code ,
pos_payment_terminal: fix lint issues,
pos_payment_terminal: black, isort and pre-commit stuff

It's also a good opportunity to clean the previous history.
There are things like this that could be squashed:

as well as the usual administrative commits

Squash administrative commits (if any) with the previous commit for reducing commit noise. They are named as "[UPD] README.rst", "[UPD] Update $MODULE.pot", "Update translation files" and similar names, and comes from OCA-git-bot, oca-travis or oca-transbot. IMPORTANT: Don't squash legit translation commits, authored by their translators, with the message "Translated using Weblate (...)".

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

OCA-git-bot · 2021-02-17T12:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sbidoul · 2021-02-17T16:10:34Z

I try to make small commits that are easy to review, and also sufficiently atomic that they are easy to revert. I also strive to not rewrite past history. Anyway, I can't do the squashing myself here as this is not a branch I own.

ivantodorovich · 2021-02-17T16:13:35Z

I'm not blocking in this 👍🏻

alexis-via · 2021-02-18T14:24:20Z

/ocabot merge nobump

OCA-git-bot · 2021-02-18T14:24:30Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-572-by-alexis-via-bump-nobump, awaiting test results.

OCA-git-bot · 2021-02-18T14:52:07Z

Congratulations, your PR was merged at c7e3587. Thanks a lot for contributing to OCA. ❤️

Auélien DUMAINE and others added 30 commits December 16, 2020 22:06

Initial check-in of the module pos_payment_terminal.

2dae345

Add dependancy on currency_iso_numeric.

4f86a06

pos_customer_display bugfix : new massage on deleting orderLine and f…

0ecab88

…ixing unit_price computation on adding orderLine

Fix copyright headers

8306742

PEP8 stuff

pos_payment_terminal : bigger button for start transaction with touch…

2b068bb

…screen

pos_payment_terminal: add missing css file

db2f725

pos_customer_display: FIX JS code and make it more robust

Remove currency_iso_numeric (replaced by pycountry)

f14a00a

Adapt JS code of pos_payment_terminal Some cleanup

Add Spanish translation by Alejandro Amador (thanks for your contribu…

d6f34f1

…tion !) Move CSS definition from pos_payment_terminal_view.xml to pos_payment_terminal.xml Small cleanups

[FIX] Vicious bug that is invisible alone, but becomes visible when u…

a1aaf1f

…sed with the module pos_pay_invoice

PEP8

7196103

Add license key in __openerp__.py

1a2ec15

Add OCA as author of OCA addons

c84df9b

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

pos_payment_terminal: Add POT file, FR translation and demo data

3c8c0fb

Better XML header

0e8aba4

pos_customer_display: Add button "Display Total to Customer" and port…

7da0a55

… to new API pos_payment_terminal: code cleanup

pos_payment_terminal: smiplify JS code

dac5cae

Move description from __openerp__.py to README.rst Update demo data

FIX my previous commit: sent currency to POSbox

aaa100b

[FIX] bug OCA#36 : take advantage of the recent update in the odoo co…

0df197d

…debase to properly get the 'name' of the currency

[UPD] prefix versions with 8.0

48b8662

[MIG] Make modules uninstallable

7d46451

[MIG] Rename manifest files

36aaf76

begin of porting pos_payment_terminal to Odoo 9.0

513dc12

overload render_paymentlines

b848b97

FIX : multiple calls to action on 'start transaction' click event

db109ed

Add static/src/xml/templates.xml

f26da53

FIX crash on demo data

57868e3

Port pos_payment_terminal to v10

6e2c5dc

OCA Transbot updated translations from Transifex

3dbf26c

OCA Transbot updated translations from Transifex

091b5e1

OCA Transbot updated translations from Transifex

5abde4a

sbidoul added 2 commits February 17, 2021 10:33

pos_payment_terminal: fix lint issues

1a50a80

pos_payment_terminal: api conformity

d4f1f02

Have send_payment_request return a promise as requested by the documentation. This open the door to handling the transaction status reported by the terminal driver asynchronously. Also, catch errors when sending the transaction start command.

sbidoul added 2 commits February 17, 2021 10:45

pos_payment_terminal: reject transactions with zero amount

1089241

pos_payment_terminal: remove dead code

8bf0174

sbidoul mentioned this pull request Feb 17, 2021

[14.0] pos_payment_terminal migration improvements akretion/pos#20

Merged

Merge pull request #20 from acsone/14.0-mig-pos-payment-terminal-sbi

50b2d40

[14.0] pos_payment_terminal migration improvements

sbidoul approved these changes Feb 17, 2021

View reviewed changes

ivantodorovich approved these changes Feb 17, 2021

View reviewed changes

OCA-git-bot added the approved label Feb 17, 2021

OCA-git-bot added the ready to merge label Feb 17, 2021

This was referenced Feb 17, 2021

[14.0] pos_payment_terminal: manage terminal transaction status #606

Merged

[13.0] pos_payment_terminal: backport from 14.0 #607

Merged

OCA-git-bot added the bot is merging ⏳ label Feb 18, 2021

OCA-git-bot merged commit aeaf804 into OCA:14.0 Feb 18, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 18, 2021

chienandalu mentioned this pull request Apr 26, 2021

Migration to version 14.0 #543

Open

16 tasks

chienandalu added this to the 14.0 milestone Apr 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] pos_payment_terminal #572

[14.0][MIG] pos_payment_terminal #572

alexis-via commented Dec 17, 2020

sbidoul commented Feb 16, 2021

sbidoul commented Feb 17, 2021

sbidoul commented Feb 17, 2021

sbidoul commented Feb 17, 2021 •

edited

Loading

ivantodorovich left a comment

sbidoul commented Feb 17, 2021

ivantodorovich commented Feb 17, 2021 •

edited

Loading

OCA-git-bot commented Feb 17, 2021

sbidoul commented Feb 17, 2021

ivantodorovich commented Feb 17, 2021

alexis-via commented Feb 18, 2021

OCA-git-bot commented Feb 18, 2021

OCA-git-bot commented Feb 18, 2021

[14.0][MIG] pos_payment_terminal #572

[14.0][MIG] pos_payment_terminal #572

Conversation

alexis-via commented Dec 17, 2020

sbidoul commented Feb 16, 2021

sbidoul commented Feb 17, 2021

sbidoul commented Feb 17, 2021

sbidoul commented Feb 17, 2021 • edited Loading

ivantodorovich left a comment

Choose a reason for hiding this comment

sbidoul commented Feb 17, 2021

ivantodorovich commented Feb 17, 2021 • edited Loading

OCA-git-bot commented Feb 17, 2021

sbidoul commented Feb 17, 2021

ivantodorovich commented Feb 17, 2021

alexis-via commented Feb 18, 2021

OCA-git-bot commented Feb 18, 2021

OCA-git-bot commented Feb 18, 2021

sbidoul commented Feb 17, 2021 •

edited

Loading

ivantodorovich commented Feb 17, 2021 •

edited

Loading