Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] product_cost_security: Migration to 16.0 #1240

Merged
merged 34 commits into from
Apr 27, 2023
Merged

[16.0][MIG] product_cost_security: Migration to 16.0 #1240

merged 34 commits into from
Apr 27, 2023

Conversation

bvanjeelharia
Copy link
Contributor

No description provided.

@bvanjeelharia bvanjeelharia force-pushed the 16.0-mig-product_cost_security branch 9 times, most recently from b212b92 to 1915e00 Compare January 3, 2023 07:29
@astirpe astirpe mentioned this pull request Jan 3, 2023
Closed
@bvanjeelharia bvanjeelharia force-pushed the 16.0-mig-product_cost_security branch 5 times, most recently from 5e219a3 to 0eb5311 Compare January 3, 2023 09:54
@astirpe
Copy link
Member

astirpe commented Jan 3, 2023

You squashed the V16 changes into the pre-commit

sergio-teruel and others added 13 commits January 3, 2023 15:33
@sergio-teruel @bvanjeelharia
[11.0][ADD] product_cost_security: New module to restrict product cos…
b07accd 
…t view
@sergio-teruel @bvanjeelharia
[11.0][ADD] product_cost_security: Fix translate folder name
419c02e
@sergio-teruel @bvanjeelharia
[11.0][IMP] product_cost_security: Avoid use odoo PR 28755
65c0d63 
odoo/odoo#28755
@oca-travis @bvanjeelharia
[UPD] Update product_cost_security.pot
f8f41b3
@OCA-git-bot @bvanjeelharia
[UPD] README.rst
e0f3434
@sergio-teruel @bvanjeelharia
[MIG] product_cost_security: Migration to v12.0
4ffdfc2
@oca-travis @bvanjeelharia
[UPD] Update product_cost_security.pot
ad05e9f
@oca-transbot @bvanjeelharia
Update translation files
ec18904 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_cost_security
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_cost_security/
@sergio-teruel @bvanjeelharia
[IMP] product_cost_security: black, isort
b6b9db4
@sergio-teruel @bvanjeelharia
[MIG] product_cost_security: Migration to v13.0
24a56b6
@oca-travis @bvanjeelharia
[UPD] Update product_cost_security.pot
e089a93
@oca-transbot @bvanjeelharia
Update translation files
109bf10 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-13.0/product-attribute-13.0-product_cost_security
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_cost_security/
@OCA-git-bot @bvanjeelharia
pre-commit update
e990ddc
@bvanjeelharia bvanjeelharia force-pushed the 16.0-mig-product_cost_security branch from 2d38cf5 to 6308845 Compare January 3, 2023 10:34
@bvanjeelharia bvanjeelharia force-pushed the 16.0-mig-product_cost_security branch 3 times, most recently from 87397e6 to ce35317 Compare January 3, 2023 11:50
@bvanjeelharia
Copy link
Contributor Author

Can someone please review and approve this PR?

@rafaelbn
Copy link
Member

Please @bvanjeelharia , could you make a "commit" empty to try un block runboat in order to test it?

@sergio-teruel you could be interested in this PR 😄

@sergio-teruel
Copy link
Contributor

@rafaelbn please give me the task 😄

sergio-teruel
sergio-teruel approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes
Please, can you modify the commit deleting the extra lines?

product_cost_security/tests/test_product_cost_security.py
class TestProductCostSecurity(TransactionCase):
@classmethod
def setUpClass(cls):
super().setUpClass()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create an environment with tracking disable.
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change

product_cost_security/tests/test_product_cost_security.py Outdated
standard_price = sheet_form.standard_price
self.assertEqual(standard_price, 0.0)

def test_1(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use more descriptive names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have made the changes

@bvanjeelharia
[MIG] product_cost_security: Migration to 16.0
e79b382 
[MIG] product_cost_security: Migration to 16.0

[MIG] product_cost_security: Migration to 16.0

[MIG] product_cost_security: Migration to 16.0

[MIG] product_cost_security: Migration to 16.0

Updated test scripts
@bvanjeelharia bvanjeelharia force-pushed the 16.0-mig-product_cost_security branch from ce35317 to e79b382 Compare April 17, 2023 06:44
@CasVissers-360ERP
Copy link

@rafaelbn can be merged?

rafaelbn
rafaelbn approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@bvanjeelharia
Copy link
Contributor Author

Can this be merged now?

@pedrobaeza pedrobaeza changed the title [MIG] product_cost_security: Migration to 16.0 [16.0][MIG] product_cost_security: Migration to 16.0 Apr 27, 2023
@pedrobaeza pedrobaeza mentioned this pull request Apr 27, 2023
Closed
@pedrobaeza
Copy link
Member

/ocabot migration product_cost_security
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 27, 2023
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1240-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 27, 2023
Open
60 tasks
@OCA-git-bot OCA-git-bot merged commit bb4d4ee into OCA:16.0 Apr 27, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 64bc04a. Thanks a lot for contributing to OCA. ❤️

Yadier-Tecnativa
Yadier-Tecnativa reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@Yadier-Tecnativa Yadier-Tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadier-Tecnativa Yadier-Tecnativa Yadier-Tecnativa left review comments

@yajo yajo yajo approved these changes

@astirpe astirpe astirpe approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.