[14.0][IMP] product_tier_validation : force default state on create and improve _state_to #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dreispt, |
Kev-Roche
changed the title
Kev-Roche
force-pushed
the
14.0-imp-force_default_state_on_create
branch
4 times, most recently
from
81a0f82 to
07319a6
Compare
|
Second commit fix it but need to set product_status as rebel module. |
Kev-Roche
force-pushed
the
14.0-imp-force_default_state_on_create
branch
3 times, most recently
from
82d67e1 to
4705e0d
Compare
sebastienbeau
requested changes
Feb 23, 2023
sebastienbeau
requested changes
Feb 23, 2023
Kev-Roche
force-pushed
the
14.0-imp-force_default_state_on_create
branch
from
4705e0d to
f78f00d
Compare
Kev-Roche
changed the title
Kev-Roche
force-pushed
the
14.0-imp-force_default_state_on_create
branch
10 times, most recently
from
264afbb to
1cc46bf
Compare
sebastienbeau
force-pushed
the
14.0-imp-force_default_state_on_create
branch
from
1cc46bf to
d386a14
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sebastienbeau
removed
the
stale
|
@gurneyalex @rousseldenis can you reopen this PR? (I do not have the right to do it) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new product, we can directly set a normal / sellable state on it, without validation. This PR avoid that by forcing the "_state_from" on product creation.
First commit is the failing test, second test fix it.
Last commit purpose is to improve _state_to value for products :
The base module "base_tier_validation" proposes "confirmed" as "_state_to" value, which is not a product state. Furthermore, we can create other product.state. In order to use this module out of the box and to take account of all the states created by users, we propose here to change the _state_to accordingly.