[16.0][MIG] product_secondary_unit #2 #1325

remihb · 2023-04-18T12:06:37Z

Adding changes of #1246

In replacement of #1193

Changes

Reintroduction of product_product part (as it was in version 15.0)
- https://github.com/OCA/product-attribute/tree/15.0/product_secondary_unit
Use of precompute=True for ProductSecondaryUnitMixin.secondary_uom_qty instead of default
- Else if used with modules like sale_order_secondary_unit wich depends on this module, it will raise
  UserWarning: Field sale.order.line.product_uom_qty cannot be precomputed as it depends on non-precomputed field sale.order.line.secondary_uom_qty
Use of TransactionCase instead of SavepointCase
- product_secondary_unit/tests/test_product_second_unit.py#L3
Removal of empty group in view and wrong usage of group_id (groups instead)
- product_secondary_unit/views/product_views.xml#L9

Question

What about the odoo_test_helper needed in manifest ? (not in base odoo requirements)

BT-aleonard · 2023-04-19T08:19:41Z

Hi @remihb ,
Why is #1193 replaced by this PR?
Thanks.

BT-aleonard · 2023-04-20T15:46:59Z

product_secondary_unit/views/product_views.xml

+        <field name="model">product.template</field>
+        <field name="inherit_id" ref="product.product_template_form_view" />
+        <field name="arch" type="xml">
+            <xpath expr="//page[@name='general_information']/group[2]" position="after">


The only thing I'd change here is to use a relative reference.
And set columns for the group and also for the field as well.
<xpath expr="//page[@name='general_information']/group[last()]" position="after" > <group string="Secondary Unit of Measure" col="4" groups="uom.group_uom" > <field name="secondary_uom_ids" colspan="4" nolabel="1">

remihb · 2023-04-26T15:46:35Z

Hi @remihb , Why is #1193 replaced by this PR? Thanks.

As I mentioned, #1193 doesn't include de product variants part, and more important, without precompute=True on ProductSecondaryUnitMixin.secondary_uom_qty, other modules like sale_order_secondary_unit or stock_secondary_unit will fail at install

rousseldenis · 2023-04-27T06:46:31Z

/ocabot migration product_secondary_unit

rousseldenis · 2023-04-27T06:47:44Z

@otmanelagy Do you mind if we swtitch to this ?

OCA-git-bot · 2023-04-27T08:04:13Z

The migration issue (#1157) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1193.
Perhaps you should check that there is no duplicate work.
CC : @otmanelagy

rousseldenis

Code review

OCA-git-bot · 2023-05-16T09:46:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

FrancoMaxime · 2023-05-16T12:32:22Z

product_secondary_unit/tests/test_secondary_unit_mixin.py

-# Copyright 2021 Tecnativa - Sergio Teruel
-# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).


Why did you remove the License?

An error, corrected

FrancoMaxime · 2023-05-16T12:32:51Z

product_secondary_unit/views/product_views.xml

-<!-- Copyright 2018 Tecnativa - Sergio Teruel
-     License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->


Why did you remove the License?

idem, corrected

FrancoMaxime · 2023-05-16T14:32:22Z

requirements.txt

@@ -1,2 +1,3 @@
 # generated from manifests external_dependencies
+odoo_test_helper


see comment in the manifest file

The correct way to add this is in a file test-requirements.txt

FrancoMaxime · 2023-05-16T14:34:00Z

product_secondary_unit/__manifest__.py

@@ -12,6 +12,7 @@
    "application": False,
    "installable": True,
    "depends": ["product"],
+    "external_dependencies": {"python": ["odoo_test_helper"]},


Its a bad idea to add odoo_test_helpder in the external_dependencies key since its only use for the unit test. A better way to do that is to use test-requirements.txt file

BT-aleonard · 2023-05-22T13:43:06Z

If you set precompute=True on the field secondary_uom_qty of the mixin, the models that are not using precompute yet (for example purchase.order.line) will fail when this fields depends on them

BT-aleonard · 2023-06-01T08:10:05Z

Hi,
Can you please check this PR, please?
@sergio-teruel

sergio-teruel · 2023-06-01T09:32:34Z

@BT-aleonard Have you seen this PR (#1336)? About the secondary_uom_qty default?

sergio-teruel · 2023-06-01T09:34:35Z

product_secondary_unit/views/product_views.xml

 <odoo>
    <record id="product_template_form_view" model="ir.ui.view">
        <field name="name">Product template Secondary Unit</field>
        <field name="model">product.template</field>
        <field name="inherit_id" ref="product.product_template_form_view" />
-        <field name="groups_id" eval="[(4, ref('uom.group_uom'))]" />


Why remove the groups? Is the better way to not load the view

Because it will raise this error Inherited view cannot have 'Groups' define on the record. Use 'groups' attributes inside the view definition

sergio-teruel · 2023-06-01T09:35:11Z

product_secondary_unit/views/product_views.xml

@@ -37,7 +41,6 @@
        <field name="name">Product Secondary Unit</field>
        <field name="model">product.product</field>
        <field name="inherit_id" ref="product.product_normal_form_view" />
-        <field name="groups_id" eval="[(4, ref('uom.group_uom'))]" />


BT-aleonard · 2023-06-01T09:46:53Z

@sergio-teruel
I didn't see it before.
But if we implement that PR (default value for secondary_uom_qty), then we can get rid of the precompute=True.
I'll suggest the changes.

TT40323

…ce qty field

…om variants

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_secondary_unit/

FrancoMaxime

LGTM: code review

OCA-git-bot · 2023-06-06T09:05:24Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

john-herholz-dt · 2023-06-06T12:50:43Z

@sergio-teruel , can you merge please? I am working on another migration depending on this module.
Thank you!

sergio-teruel · 2023-06-06T15:43:32Z

ping @pedrobaeza

pedrobaeza · 2023-06-07T07:55:03Z

/ocabot merge nobump

OCA-git-bot · 2023-06-07T07:55:13Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1325-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-06-07T08:01:28Z

Congratulations, your PR was merged at 137afe1. Thanks a lot for contributing to OCA. ❤️

remihb changed the title ~~16.0 mig product secondary unit~~ [16.0][MIG] product_secondary_unit #2 Apr 18, 2023

remihb force-pushed the 16.0-mig-product_secondary_unit branch from 6f73826 to 062a481 Compare April 18, 2023 15:31

remihb mentioned this pull request Apr 18, 2023

[16.0][MIG] sale_order_secondary_unit OCA/sale-workflow#2486

Closed

1 task

BT-aleonard suggested changes Apr 20, 2023

View reviewed changes

remihb force-pushed the 16.0-mig-product_secondary_unit branch from 062a481 to 559f120 Compare April 26, 2023 15:44

remihb force-pushed the 16.0-mig-product_secondary_unit branch from 559f120 to 5c085db Compare April 26, 2023 15:47

remihb mentioned this pull request Apr 26, 2023

[16.0][MIG] stock_secondary_unit OCA/stock-logistics-warehouse#1701

Closed

rousseldenis added needs review migration labels Apr 27, 2023

OCA-git-bot added this to the 16.0 milestone Apr 27, 2023

OCA-git-bot mentioned this pull request Apr 27, 2023

Migration to version 16.0 #1157

Open

60 tasks

rousseldenis approved these changes May 3, 2023

View reviewed changes

BT-aleonard approved these changes May 16, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels May 16, 2023

FrancoMaxime suggested changes May 16, 2023

View reviewed changes

OCA-git-bot removed approved ready to merge labels May 16, 2023

FrancoMaxime suggested changes May 16, 2023

View reviewed changes

sergio-teruel suggested changes Jun 1, 2023

View reviewed changes

oca-ci and others added 10 commits June 1, 2023 14:26

[UPD] Update product_secondary_unit.pot

b954fb9

[FIX] product_secondary_unit: Change SavepointCase to TransactionCase

9723713

product_secondary_unit 15.0.1.0.1

912fc14

[IMP] product_secondary_unit: Compatibility with product variants

dec23b4

TT40323

[FIX] product_secondary_unit: Fix rounding secondary uom

d4a3cf4

[FIX] product_secondary_unit: Apply the default value defined in sour…

5a71b68

…ce qty field

[IMP] product_secondary_unit: Access to template secondary_uom_ids fr…

fe98472

…om variants

[UPD] Update product_secondary_unit.pot

3d656f7

product_secondary_unit 15.0.2.0.0

2095e78

remihb force-pushed the 16.0-mig-product_secondary_unit branch from 5c085db to e49e1e5 Compare June 1, 2023 12:28

[MIG] product_secondary_unit: Migration to 16.0

e18f69c

remihb force-pushed the 16.0-mig-product_secondary_unit branch from e49e1e5 to e18f69c Compare June 1, 2023 12:33

sergio-teruel approved these changes Jun 1, 2023

View reviewed changes

BT-aleonard approved these changes Jun 5, 2023

View reviewed changes

FrancoMaxime approved these changes Jun 6, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 6, 2023

pedrobaeza mentioned this pull request Jun 7, 2023

[16.0][MIG] product_secondary_unit #1193

Closed

OCA-git-bot added the bot is merging ⏳ label Jun 7, 2023

OCA-git-bot merged commit cdbd8ab into OCA:16.0 Jun 7, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 7, 2023

alexey-pelykh mentioned this pull request Apr 16, 2024

[16.0][MIG] sale_order_secondary_unit OCA/sale-workflow#3022

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] product_secondary_unit #2 #1325

[16.0][MIG] product_secondary_unit #2 #1325

remihb commented Apr 18, 2023 •

edited

Loading

BT-aleonard commented Apr 19, 2023 •

edited

Loading

BT-aleonard Apr 20, 2023

remihb Apr 26, 2023

remihb commented Apr 26, 2023

rousseldenis commented Apr 27, 2023

rousseldenis commented Apr 27, 2023

OCA-git-bot commented Apr 27, 2023

rousseldenis left a comment

OCA-git-bot commented May 16, 2023

FrancoMaxime May 16, 2023

remihb Jun 1, 2023

FrancoMaxime May 16, 2023

remihb Jun 1, 2023

FrancoMaxime May 16, 2023

BT-aleonard Jun 1, 2023

FrancoMaxime May 16, 2023

remihb Jun 1, 2023

BT-aleonard commented May 22, 2023 •

edited

Loading

BT-aleonard commented Jun 1, 2023

sergio-teruel commented Jun 1, 2023

sergio-teruel Jun 1, 2023

remihb Jun 1, 2023

sergio-teruel Jun 1, 2023

remihb Jun 1, 2023

BT-aleonard commented Jun 1, 2023 •

edited

Loading

FrancoMaxime left a comment

OCA-git-bot commented Jun 6, 2023

john-herholz-dt commented Jun 6, 2023

sergio-teruel commented Jun 6, 2023

pedrobaeza commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

		# Copyright 2021 Tecnativa - Sergio Teruel
		# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

		<!-- Copyright 2018 Tecnativa - Sergio Teruel
		License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->

		@@ -1,2 +1,3 @@
		# generated from manifests external_dependencies
		odoo_test_helper

[16.0][MIG] product_secondary_unit #2 #1325

[16.0][MIG] product_secondary_unit #2 #1325

Conversation

remihb commented Apr 18, 2023 • edited Loading

Changes

Question

BT-aleonard commented Apr 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

remihb commented Apr 26, 2023

rousseldenis commented Apr 27, 2023

rousseldenis commented Apr 27, 2023

OCA-git-bot commented Apr 27, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BT-aleonard commented May 22, 2023 • edited Loading

BT-aleonard commented Jun 1, 2023

sergio-teruel commented Jun 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BT-aleonard commented Jun 1, 2023 • edited Loading

FrancoMaxime left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jun 6, 2023

john-herholz-dt commented Jun 6, 2023

sergio-teruel commented Jun 6, 2023

pedrobaeza commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

OCA-git-bot commented Jun 7, 2023

remihb commented Apr 18, 2023 •

edited

Loading

BT-aleonard commented Apr 19, 2023 •

edited

Loading

BT-aleonard commented May 22, 2023 •

edited

Loading

BT-aleonard commented Jun 1, 2023 •

edited

Loading