Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] product_state_history: Migration to 16.0 #1396

Closed

Conversation

michaelslade54
Copy link

Standard migration.

@michaelslade54 michaelslade54 force-pushed the 16.0-mig-product_state_history branch from be05ef2 to 57bf679 Compare July 31, 2023 00:19
@michaelslade54 michaelslade54 mentioned this pull request Jul 31, 2023
60 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration product_state_history

@rousseldenis
Copy link
Contributor

@michaelslade54 Could you fix this as it seems you've included another module ?

@michaelslade54
Copy link
Author

Apologies.

It appears this commit 81a5eb6 in the commit history introduced some changes to the extra module, hence it appearing here.

@rousseldenis I'm unsure of the most appropriate way to rectify this, is the preferred method to drop the commit and include any module specific changes in the migration?

Any info appreciated. Thanks.

@rousseldenis
Copy link
Contributor

@michaelslade54 The best solution is to rebase interactively and don't take modifications that are outside this module.

rousseldenis and others added 9 commits August 31, 2023 09:02
Take into account product template status instead of history
one when launching report
Wrong assertion for report as it should include products AFTER
pivot date.

Better view definition
To distinguish the report and the history (all the records),
the action name has been changed
If the same state than the current is written, a duplicate state history
is generated. This prevents that behaviour.
@michaelslade54 michaelslade54 force-pushed the 16.0-mig-product_state_history branch from 57bf679 to 9e14da4 Compare August 31, 2023 00:07
Signed-off-by: michaelslade <48970841+michaelslade54@users.noreply.github.com>
@michaelslade54 michaelslade54 force-pushed the 16.0-mig-product_state_history branch from 9e14da4 to 49b4161 Compare August 31, 2023 00:20
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review and functionnal testing

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 28, 2024
@github-actions github-actions bot closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants