-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] product_state_history: Migration to 16.0 #1396
[16.0] [MIG] product_state_history: Migration to 16.0 #1396
Conversation
be05ef2
to
57bf679
Compare
/ocabot migration product_state_history |
@michaelslade54 Could you fix this as it seems you've included another module ? |
Apologies. It appears this commit 81a5eb6 in the commit history introduced some changes to the extra module, hence it appearing here. @rousseldenis I'm unsure of the most appropriate way to rectify this, is the preferred method to drop the commit and include any module specific changes in the migration? Any info appreciated. Thanks. |
@michaelslade54 The best solution is to rebase interactively and don't take modifications that are outside this module. |
Take into account product template status instead of history one when launching report
Wrong assertion for report as it should include products AFTER pivot date. Better view definition
To distinguish the report and the history (all the records), the action name has been changed
If the same state than the current is written, a duplicate state history is generated. This prevents that behaviour.
57bf679
to
9e14da4
Compare
Signed-off-by: michaelslade <48970841+michaelslade54@users.noreply.github.com>
9e14da4
to
49b4161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: code review and functionnal testing
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Standard migration.