Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] partner_product_price #1408

Closed
wants to merge 2 commits into from
Closed

[16.0][ADD] partner_product_price #1408

wants to merge 2 commits into from

Conversation

norlinhenrik
Copy link

  • Open a contact.
  • Click Actions - Products.
  • In list view, show the fields Contact and Contact's Price.

@norlinhenrik norlinhenrik force-pushed the 16.0-add-partner_product_price branch 3 times, most recently from 52f4332 to cdb6dc6 Compare August 30, 2023 20:12
legalsylvain
legalsylvain requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution !
Some blocking point in line.
could you take a look on pre-commit error also ?

thanks !

partner_product_price/models/product_product.py Show resolved Hide resolved
partner_product_price/data/ir_actions_server.xml Outdated Show resolved Hide resolved
partner_product_price/data/ir_actions_server.xml Outdated Show resolved Hide resolved
@norlinhenrik
Copy link
Author

@legalsylvain Thank you for the input! See the second commit with fixes plus more.

@norlinhenrik
Copy link
Author

Do you think that this module should be here in product-attribute or in partner-contact? I put it here because since other modules related to pricing are here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 4, 2024
@norlinhenrik norlinhenrik mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norlinhenrik @legalsylvain