Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_manufacturer: Migration to 17.0 #1462

Merged
merged 50 commits into from
Nov 25, 2024

Conversation

NICO-SOLUTIONS
Copy link
Member

Standard migration to 17.0

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review November 22, 2023 14:37
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Nov 22, 2023
61 tasks
@pedrobaeza
Copy link
Member

/ocabot migration product_manufacturer

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 22, 2023
Copy link

@smcqueen81 smcqueen81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funcional ok

@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-product_manufacturer branch from f10eee7 to 9df1c55 Compare March 25, 2024 18:36
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-product_manufacturer branch from 9df1c55 to d90ff51 Compare May 16, 2024 14:32
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

product_manufacturer/models/product_template.py Outdated Show resolved Hide resolved
product_manufacturer/models/product_template.py Outdated Show resolved Hide resolved
product_manufacturer/tests/test_product_manufacturer.py Outdated Show resolved Hide resolved
@bizzappdev
Copy link
Contributor

@NICO-SOLUTIONS I have made the review changes NICO-SOLUTIONS#1 to fast-track the process. Please check and proceed with the merge if it feels good.

@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-product_manufacturer branch from d90ff51 to 1e132f5 Compare July 10, 2024 17:34
@HviorForgeFlow
Copy link
Member

@rousseldenis all comments attended

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link

@antoniocanovas antoniocanovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK !!

@Crazor
Copy link

Crazor commented Sep 11, 2024

This one also appears to be stuck.

@aessig
Copy link

aessig commented Sep 25, 2024

Looking forward for it to be merged

@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-product_manufacturer branch from 1e132f5 to c0f83a1 Compare September 25, 2024 16:25
acysos and others added 6 commits September 25, 2024 18:30
* New Field Added to store the URL of the product on the manufacturer page.
* Added field manufacturer product URL to the product view.
* README updated.
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
HviorForgeFlow and others added 15 commits September 25, 2024 18:30
Currently translated at 100.0% (5 of 5 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_manufacturer/ca/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_manufacturer/pl/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_manufacturer/es_AR/
… Rename field manufacturer into manufacturer_id

[UPD] Update product_manufacturer.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_manufacturer/

Translated using Weblate (Italian)

Currently translated at 100.0% (6 of 6 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_manufacturer/it/

Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (6 of 6 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_manufacturer/pt_BR/

Translated using Weblate (Spanish)

Currently translated at 100.0% (6 of 6 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_manufacturer/es/

[UPD] README.rst
…plate instead of compute vals inside the create method
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_manufacturer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_manufacturer/
@NICO-SOLUTIONS NICO-SOLUTIONS force-pushed the 17.0-mig-product_manufacturer branch from c0f83a1 to 0108e7d Compare September 25, 2024 16:31
@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1462-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit df937ef into OCA:17.0 Nov 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6e821e9. Thanks a lot for contributing to OCA. ❤️

@NICO-SOLUTIONS
Copy link
Member Author

@StefanRijnhart thx

@NICO-SOLUTIONS NICO-SOLUTIONS deleted the 17.0-mig-product_manufacturer branch November 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.