Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] product_dimension: Migration to 17.0 #1473

Merged
merged 56 commits into from
Dec 7, 2023
Merged

[17.0][MIG] product_dimension: Migration to 17.0 #1473

merged 56 commits into from
Dec 7, 2023

Conversation

lethuthao2403
Copy link

ref: BSRD-705

lepistone and others added 30 commits December 1, 2023 15:01
@lepistone @thaolt99
rename product_dimensions -> product_dimension
4462243 
osv -> orm

test computation of volume in same UOM

add test with conversion from cm

refactor, new API, generic UOM computation

fix wording in readme

do not use camelcase for Models

put dimensions in their own group

Otherwise they are shown as weights.

fill in placeholders in README

README is actually rst, not md

use a new-api onchange, update tests, refactor

Also, spell "height" correctly.
@yvaucher @thaolt99
Add missing default oca icons
2fc22fd
@sbidoul @thaolt99
[UPD] prefix versions with 8.0
b7b3f95
@pedrobaeza @thaolt99
[MIG] Make modules uninstallable
c0fe19f
@hugosantosred @thaolt99
[FIX] product_dimension: Now domain on dimensional_uom_id is working …
13d4d81 
…also with other languages than english
@bealdav @thaolt99
[FIX] flake 8 error on modules product_dimension, product_gtin, produ…
9de98a4 
…ct_supplierinfo_tree_price_info
@jjscarafia @thaolt99
ADD test case with product template
ac6233a 
REF remove executable permission

ADD missing tag images

Conflicts:
	product_dimension/__openerp__.py
@thaolt99
[ADD] Dimensions fields in product.template
2a4bdd3 
FIX remove oldname in field height

ADD onchange calculate volume on product template
@leemannd @thaolt99
Module structure, views & license headers
21885d6 
[MIG] Make modules uninstallable

[MIG] Rename manifest files
@thaolt99
[MIG] product_dimension: Migration to 11.0
4a3415f
@ivantodorovich @thaolt99
[9.0][product_dimension][FIX] Fix volume being incorrectly calculated…
e6ba3ec 
… due to rounding issues (OCA#284)2
@thaolt99
[MIG]: Adding suggested changes
0116d08
@thaolt99
[MIG] product_dimension: Adding missing po files and improvemnets
2d586ad
@thaolt99
[MIG] product_dimension: Adding lambda to domain function, Update readme
c9e6dee
@thaolt99
[IMP] product_dimension: Code cleanup/improvements during migration t…
a239f7f 
…o 11.0
@thaolt99
[IMP] product_dimension: Reset volume when parameters not valid
b38d1d5
@rvalyi @thaolt99
[MIG] product_dimension: Migration to 12.0
5281d3a
@clementmbr @thaolt99
[IMP] product_dimension: Works with many variants and split Readme
df88626
@oca-transbot @thaolt99
Update translation files
d181925 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/
@Galoperd @thaolt99
Translated using Weblate (Spanish)
1e78060 
Currently translated at 100.0% (8 of 8 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/es/
@emagdalenaC2i @thaolt99
[FIX] rename length to product_length
905730e
@OCA-git-bot @thaolt99
[UPD] README.rst
0d5fa82
@oca-transbot @thaolt99
Update translation files
afe88bc 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/
@pedrocs-exo @thaolt99
Added translation using Weblate (Portuguese)
accce4f
@pedrocs-exo @thaolt99
Translated using Weblate (Portuguese)
7c3c918 
Currently translated at 100.0% (11 of 11 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_dimension/pt/
@EmailsGmails @thaolt99
[IMP] product_dimension: black, isort, prettier
88004ad
@Tatider @thaolt99
[MIG] product_dimension: Migration To 13.0
de2d0b2
@OCA-git-bot @thaolt99
[UPD] README.rst
7ca9084
@didierdonze @thaolt99
Translated using Weblate (German)
d4184a1 
Currently translated at 100.0% (11 of 11 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_dimension/de/
@didierdonze @thaolt99
Translated using Weblate (French)
a79ee52 
Currently translated at 100.0% (11 of 11 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_dimension/fr/
OCA-git-bot and others added 15 commits December 1, 2023 15:58
@OCA-git-bot @thaolt99
product_dimension 15.0.1.0.1
8f36d8c
@Noel000 @thaolt99
Translated using Weblate (Catalan)
4798265 
Currently translated at 100.0% (11 of 11 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_dimension/ca/
@FrancoMaxime @thaolt99
[MIG] product_dimension: Migration to 16.0
9d7ffe5
@OCA-git-bot @thaolt99
[UPD] README.rst
70b7f42
@OCA-git-bot @thaolt99
product_dimension 16.0.1.0.1
88d3185
@rousseldenis @thaolt99
[IMP] product_dimension: Remove onchange method to computed readonly …
6dfd5c5 
…False one
@rousseldenis @thaolt99
[IMP] product_dimension: Allow to create product template with dimens…
7e7e791 
…ions
@OCA-git-bot @thaolt99
product_dimension 16.0.1.1.0
e066a00
@weblate @thaolt99
Update translation files
bb28e75 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_dimension/
@PicchiSeba @thaolt99
Added translation using Weblate (Italian)
ef618d1
@PicchiSeba @thaolt99
Translated using Weblate (Italian)
32824a8 
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_dimension/it/
@Ivorra78 @thaolt99
Translated using Weblate (Spanish)
840f116 
Currently translated at 100.0% (12 of 12 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_dimension/es/
@OCA-git-bot @thaolt99
[UPD] README.rst
51f106e
@weblate @thaolt99
Update translation files
ec3ddaf 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_dimension
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_dimension/
@thaolt99
[IMP] product_dimension: pre-commit auto fixes
2dbe5c9
@lethuthao2403 lethuthao2403 mentioned this pull request Dec 5, 2023
Open
59 tasks
@pedrobaeza
Copy link
Member

/ocabot migration product_dimension

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 5, 2023
smcqueen81
smcqueen81 approved these changes Dec 6, 2023
View reviewed changes
Copy link

@smcqueen81 smcqueen81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Ok

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1473-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2c6979e into OCA:17.0 Dec 7, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 594fe52. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcqueen81 smcqueen81 smcqueen81 approved these changes

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.