Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] product_supplierinfo_for_customer: Migration to 17.0 #1508

Merged
merged 83 commits into from
May 23, 2024
Merged

[17.0][MIG] product_supplierinfo_for_customer: Migration to 17.0 #1508

merged 83 commits into from
May 23, 2024

Conversation

Vang-NguyenPhu
Copy link

No description provided.

oihane and others added 30 commits December 7, 2023 16:03
@oihane @Vang-NguyenPhu
<product_supplierinfo_for_customer>
852a125
@pedrobaeza @Vang-NguyenPhu
product_supplierinfo_for_customer: Views and documentation
93d3e94
@oihane @Vang-NguyenPhu
Related to OCA#638
01025cb
@sysadminmatmoz @Vang-NguyenPhu
Slovene translations of odoomrp modules
4ba72c8
@pedrobaeza @Vang-NguyenPhu
product_supplierinfo_for_customer: Avoid side effects + improve README
5e0a461
@oihane @Vang-NguyenPhu
<product_supplierinfo_for_customer> Create 'customer' type from menu …
223e97f 
…option
@oihane @Vang-NguyenPhu
<product_supplierinfo_for_customer> Added know issue with computed fi…
74ac366 
…elds
@alfredoavanzosc @Vang-NguyenPhu
product_supplierinfo_for_customer: Create "demo" data, and "tests" fo…
7a85e89 
…lder.
@Vang-NguyenPhu
license target link
b001eb9
@Vang-NguyenPhu
OCA as author added
f34ddf8
@ysantiago @Vang-NguyenPhu
product_customer_code: New README. [REF] product_supplierinfo_for_cus…
7247895 
…tomer: Complete README.
@AaronHForgeFlow @Vang-NguyenPhu
product_supplierinfo_for_customer to v9
9d19973
@AaronHForgeFlow @Vang-NguyenPhu
[MIG] product_supplierinfo_for_customer to v10
62772e3
@AaronHForgeFlow @Vang-NguyenPhu
[IMP] Add back the option to import the prices from supplierinfo to PL
4c3de2f
@MiquelRForgeFlow @Vang-NguyenPhu
[FIX] Move some views to product_supplierinfo_for_customer_sale
f0e6a19
@MiquelRForgeFlow @Vang-NguyenPhu
[REF] Don't overwrite views and fix view for customers
b0d203f
@JordiBForgeFlow @Vang-NguyenPhu
fix view field names
df4d4c0
@MiquelRForgeFlow @Vang-NguyenPhu
[IMP] Readem title and optimization
370acfb
@MiquelRForgeFlow @Vang-NguyenPhu
[FIX] Assure partner is passed in the context
a6456c3
@sergio-teruel @Vang-NguyenPhu
[11.0][MIG] product_supplier_info_for_customer: Module migration
c99fa3e
@MiquelRForgeFlow @Vang-NguyenPhu
[IMP] Optimization and fixes from reviews
dc5305b
@MiquelRForgeFlow @Vang-NguyenPhu
[IMP] Use variant one2many introduced in v11 like variant_seller_ids
97d131a
@MiquelRForgeFlow @Vang-NguyenPhu
[IMP] product.supplierinfo: type renamed to supplierinfo_type
acbd97a
@MiquelRForgeFlow @Vang-NguyenPhu
[IMP] Change to SavepointCase some tests
1413104
@sergio-teruel @Vang-NguyenPhu
[11.0][FIX] product_supplierinfo_for_customer: Hide variant suppliers…
e01bc9c 
… in product template
@mvrodriguez @Vang-NguyenPhu
Translated using Weblate (Spanish)
aed6123 
Currently translated at 100.0% (17 of 17 strings)

Translation: product-attribute-11.0/product-attribute-11.0-product_supplierinfo_for_customer
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_supplierinfo_for_customer/es/
@pedrobaeza @Vang-NguyenPhu
[FIX] product_supplierinfo_for_customer: Mistake on act_window defini…
81b8cf3 
…tion

That action window is for showing directly product.supplierinfo, so no
product template source and no `id` field. The rest of modifications on the act_window
are also nonsense.
@pedrobaeza @Vang-NguyenPhu
[FIX] product_supplierinfo_for_customer: visible_product_tmpl_id cont…
7fd68dd 
…ext key is needed in act_window

Or the product template won't be shown there.
@pedrobaeza @Vang-NguyenPhu
[FIX] product_supplierinfo_for_customer: Adapt views to variants hand…
a397186 
…ling

The same way Odoo does.
@renatonlima @Vang-NguyenPhu
[MIGR] product_supplierinfo_for_customer: Migration to 12.0
0830548
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@desdelinux
Copy link

Hi @simahawk this is ready :)

cuongnmtm
cuongnmtm approved these changes Apr 9, 2024
View reviewed changes
Copy link

@cuongnmtm cuongnmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 17.0-mig-product_supplierinfo_for_customer branch 2 times, most recently from ae894c2 to 299a22f Compare April 9, 2024 07:51
@desdelinux
Copy link

Hi @pedrobaeza @simahawk this is ready, please

pedrobaeza
pedrobaeza previously requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .deb file.

@desdelinux
Copy link

@Vang-NguyenPhu Please, you can check the suggestion of @pedrobaeza

@Vang-NguyenPhu
Copy link
Author

@Vang-NguyenPhu Please, you can check the suggestion of @pedrobaeza

Yes sir, but I just found a defect in this module. The price is not applied when we select the variant from pop-up "Configure your product". I will try to fix it soon.

@desdelinux
Copy link

@Vang-NguyenPhu Please, you can check the suggestion of @pedrobaeza

Yes sir, but I just found a defect in this module. The price is not applied when we select the variant from pop-up "Configure your product". I will try to fix it soon.

Friendly Reminder @Vang-NguyenPhu

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 17.0-mig-product_supplierinfo_for_customer branch from 299a22f to 97557b0 Compare May 23, 2024 08:50
@Vang-NguyenPhu
Copy link
Author

@Vang-NguyenPhu Please, you can check the suggestion of @pedrobaeza

Yes sir, but I just found a defect in this module. The price is not applied when we select the variant from pop-up "Configure your product". I will try to fix it soon.

Friendly Reminder @Vang-NguyenPhu

All Done :)

cuongnmtm
cuongnmtm approved these changes May 23, 2024
View reviewed changes
Copy link

@cuongnmtm cuongnmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@pedrobaeza pedrobaeza dismissed their stale review May 23, 2024 09:52

.deb removed

@pedrobaeza
Copy link
Member

Merging as no more blockers, but not reviewed by my part:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1508-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 100fb7f into OCA:17.0 May 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 71b6723. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmglord xmglord xmglord approved these changes

@desdelinux desdelinux desdelinux approved these changes

@cuongnmtm cuongnmtm cuongnmtm approved these changes

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.