[16.0][FIX] product_secondary_unit: use existing value

[alexey-pelykh]

The rec._origin[rec._secondary_unit_fields["qty_field"]] will still be used via https://github.com/odoo/odoo/blob/f9054640f8640d4449df5f7ea5fb7b4e8de4d89a/odoo/fields.py#L1197-L1201:

            elif self.store and record._origin and not (self.compute and self.readonly):
                # new record with origin: fetch from origin
                value = self.convert_to_cache(record._origin[self.name], record, validate=False)
                env.cache.set(record, self, value)

[OCA-git-bot]

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

[alexey-pelykh]

Hi @sergio-teruel, please take a look and share your vision on this - it needs specifically you.

[alexey-pelykh]

@OCA/product-maintainers anyone?

[alexey-pelykh]

@pedrobaeza 🙏 I require help with someone looking into this

[sergio-teruel]

Sorry @alexey-pelykh Now I do not remenber the reasson of that... @pedrobaeza Do you remember it?

[pedrobaeza]

I think this may be related to the record containing NewId references that don't fetch the value correctly in defaults. The commit introducing it was: 5a71b68

[alexey-pelykh]

Hm, yet the tests aren't failing so either they aren't covering that or there's nothing to fix now?

[pedrobaeza]

Maybe the problem doesn't exist in v16. Anyway, why do you want to change it?

[alexey-pelykh]

Because that's what is causing OCA/sale-workflow@589e363 to not work - I did a lot of testing if the OCA/sale-workflow@ad19530 as you can see :)

[alexey-pelykh]

And what's more important - the current code is already there in v16 just as a branch that's going to get executed in .new() cases anyhow.

[pedrobaeza]

OK then, let's fix it and see if there's any side effect:

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1556-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f1c209b. Thanks a lot for contributing to OCA. ❤️