[PORT] product_lot_sequence: #1323 from 15.0 #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening the detailed operations view of a stock move, Odoo is calling stock.production.lot._get_next_serial to set stock.move.next_serial field anytime the product is tracked by serial and the move is assigned. If we use this module with product or global policy, the respective sequence will therefore be called and incremented anytime this view is open, even if the picking is not creating lots (e.g. delivery orders or internal transfers) To avoid incrementing the sequence unnecessarily, we only allow to get the next sequence number the first time this view is opened and if the move has to create new serial numbers. Otherwise, we force the value to be set to stock.move.next_serial field to an empty string if no serial has to be created through this move, or to the next_serial value assigned on the first opening of the view.
vvrossem
force-pushed
the
oca-port-from-15.0-to-16.0-pr-1323
branch
2 times, most recently
from
3b43b2c to
77f3821
Compare
|
@grindtildeath would you mind reviewing this PR? 🙏 |
SilvioC2C
approved these changes
Mar 20, 2024
vvrossem
force-pushed
the
oca-port-from-15.0-to-16.0-pr-1323
branch
from
77f3821 to
8d070b3
Compare
grindtildeath
approved these changes
Mar 21, 2024
|
ping @OCA/product-maintainers |
This comment was marked as resolved.
This comment was marked as resolved.
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Mar 22, 2024
|
@dreispt looks like a merge stuck. |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@dreispt wondering if that will do a trick as https://github.com/OCA/product-attribute/pull/1559/checks?check_run_id=22995777385 is still stuck :-) |
|
Congratulations, your PR was merged at d3e080f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #1323