Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] product_packaging_container_deposit : performance #1583

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[16.0][FIX] product_packaging_container_deposit : performance #1583

merged 1 commit into from
Jul 1, 2024

Conversation

jbaudoux
Copy link
Contributor

When an order is modified, do not recompute container deposit for each line

@jbaudoux
[FIX] product_packaging_container_deposit
32ca7a9 
When an order is modified, do not recompute container deposit for each line
@jbaudoux jbaudoux force-pushed the 16-fix-product_packaging_container_deposit branch from 21452f0 to 32ca7a9 Compare April 17, 2024 21:52
@jbaudoux jbaudoux mentioned this pull request Apr 17, 2024
Merged
4 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux
Copy link
Contributor Author

jbaudoux commented May 2, 2024

@simahawk Can we merge this?

@OCA-git-bot
Copy link
Contributor

Sorry @jbaudoux you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@jbaudoux
Copy link
Contributor Author

ping @simahawk

@simahawk
Copy link
Contributor

simahawk commented Jul 1, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1583-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2b2ab08 into OCA:16.0 Jul 1, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0212ec6. Thanks a lot for contributing to OCA. ❤️

juancarlosonate-tecnativa pushed a commit to Tecnativa/product-attribute that referenced this pull request Feb 28, 2025
@OCA-git-bot
Merge PR OCA#1583 into 16.0
1a7fb86 
Signed-off-by simahawk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@santostelmo santostelmo santostelmo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbaudoux @OCA-git-bot @simahawk @cyrilmanuel @santostelmo