[17.0] [MIG] product_pricelist_supplierinfo: Migration to 17.0 #1632

mdurepos · 2024-06-11T22:22:13Z

No description provided.

suniagajose · 2024-06-12T00:05:20Z

can you review and merge this please?

thanks,

luisg123v · 2024-06-13T01:04:21Z

product_pricelist_supplierinfo/README.rst

@@ -17,23 +17,24 @@ Supplier info prices in sales pricelists
    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
    :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github
-    :target: https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_supplierinfo
+    :target: https://github.com/OCA/product-attribute/tree/17.0/product_pricelist_supplierinfo


This is in the migration commit, but it should be on a separate commit that includes precommit changes. Presentation should be:

Module history from the previous version (several commits

A commit running precommit, named [IMP] module_name: pre-commit auto fixes

The actual migration commit. Here you should remove [17.0], this should only be included in PR's title

@luisg123v thanks for the review. I'll correct and re-push when I get some time.

luisg123v · 2024-06-13T01:05:32Z

product_pricelist_supplierinfo/__manifest__.py

+{
+    "name": "Supplier info prices in sales pricelists",
+    "summary": "Allows to create priceslists based on supplier info",
+    "version": "17.0.1.0.1",


Suggested change

"version": "17.0.1.0.1",

"version": "17.0.1.0.0",

luisg123v · 2024-06-13T01:13:30Z

/ocabot migration product_pricelist_supplierinfo

OCA-git-bot · 2024-06-13T01:14:43Z

Sorry @luisg123v you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

suniagajose · 2024-06-17T16:23:10Z

hi @luisg123v

can you check with someone at OCA why the bot did not allow you to merge it?

thanks,

luisg123v · 2024-06-17T17:02:22Z

@suniagajose I didn't try to merge, I just tried to mark it as a migration PR

suniagajose · 2024-06-17T18:30:01Z

ok @luisg123v

whom can i ask to mark as migration instead?

moylop260 · 2024-06-17T19:09:16Z

/ocabot migration product_pricelist_supplierinfo

luisg123v · 2024-06-17T19:14:00Z

Hi @sbidoul, @pedrobaeza,

I tried to mark this module as a migration one on #1632 (comment), but it failed with a permission error, despite being a maintainer. Besides, I noticed I wasn't notified for review.

Is there any issue with the bot you are aware of?

Regards,

CC @desdelinux

pedrobaeza · 2024-06-18T06:16:34Z

Please split the pre-commit initial changes from the migration commit as stated in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

sbidoul · 2024-06-24T12:18:51Z

@luisg123v

I tried to mark this module as a migration one on #1632 (comment), but it failed with a permission error, despite being a maintainer.

I don't think the ocabot migration command checks for maintainers. Wondering if the bot could detect migration PRs automatically.

Besides, I noticed I wasn't notified for review.

OCA/oca-github-bot#193 Seems there is an open PR, but it's a big diff to review.

pedrobaeza · 2024-06-24T14:33:14Z

I don't think the ocabot migration command checks for maintainers. Wondering if the bot could detect migration PRs automatically.

That's a very difficult task, as there's nothing characteristic that can be used for that. The only thing may be the PR title, and people is not very standard with it... so it will be the same time to ask a contributor to change the PR title (and to detect such changes from the bot), than launching ocabot migrat... command.

suniagajose · 2024-06-24T16:59:30Z

Please split the pre-commit initial changes from the migration commit as stated in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Hi @mdurepos

Can you do it, please?

Regards,

* Don't depend on sales * Extended README * Tests focused on module specific features * Code optimization * Don't mix pricelist info with supplier info on criteria

Date order is passed by context, so we have to take this into account for computing properly available supplierinfo records.

If not, you can twist the order in the form and rules won't be applied according criteria

If you set the value "Based on" for using supplier info, but then you change the computation type to another one (like fixed price or discount), this code is still acting, so we should check both fields.

OCA#436) Previously, only worked fine with product.product.

Currently translated at 93.3% (14 of 15 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_supplierinfo/es/

When having price per qty at the supplier level and if you want to base your pricelist on the supplier price, now you can define a margin on the product.supplierinfo

Currently translated at 59.0% (13 of 22 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_pricelist_supplierinfo/it/

Assertion in tests involving the pricelist field in products were removed, as that field doesn't exist anymore [1], and such assertions were intended only to ensure computed price were propagated correctly to that field. [1] odoo/odoo@9e99a9df

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/

…od in product_pricelist model In version 15.0 the _compute_price_rule method was used to obtain the product price because the price was a computed field, however, in version 16.0 we need to inherit _compute_price from product_pricelist_item because this method is used directly when creating a new sale order line.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/es/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/pt_BR/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_supplierinfo Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_supplierinfo/it/

mdurepos · 2024-06-26T11:00:27Z

@suniagajose I just force pushed with the auto-fix commit and real manual changes separated. I believe I caught everything from the previous comments.

suniagajose · 2024-06-26T13:55:10Z

thanks @mdurepos

@moylop260 @pedrobaeza i think now is ready....

moylop260 · 2024-06-26T16:30:10Z

/ocabot merge nobump

OCA-git-bot · 2024-06-26T16:30:17Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1632-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2024-06-26T16:35:00Z

Congratulations, your PR was merged at cfeb3e1. Thanks a lot for contributing to OCA. ❤️

mdurepos force-pushed the 17.0-mig-product_pricelist_supplierinfo branch from 1436306 to cb8888a Compare June 11, 2024 22:40

mdurepos mentioned this pull request Jun 11, 2024

[17.0] [MIG] product_pricelist_supplierinfo: Migration to 17.0 #1569

Closed

luisg123v suggested changes Jun 13, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Jun 17, 2024

OCA-git-bot mentioned this pull request Jun 17, 2024

Migration to version 17.0 #1446

Open

59 tasks

BT-pkosnik mentioned this pull request Jun 24, 2024

[MIG] Not yet merged in OCA: 17.0 mig product pricelist supplierinfo brain-tec/product-attribute#1112

Merged

cubells and others added 12 commits June 26, 2024 06:30

product_pricelist_supplierinfo: priceslists based in supplier info

fa654b6

product_pricelist_supplierinfo: Several enhancements + concept fixing

4b6a7fd

* Don't depend on sales * Extended README * Tests focused on module specific features * Code optimization * Don't mix pricelist info with supplier info on criteria

product_pricelist_supplierinfo: Take into account sales order date

4c491ab

Date order is passed by context, so we have to take this into account for computing properly available supplierinfo records.

product_pricelist_supplierinfo: Give more priority in order to min_qty

13de655

If not, you can twist the order in the form and rules won't be applied according criteria

[MIG] product_pricelist_supplierinfo v11 to v12

3a47de5

[FIX] product_pricelist_supplierinfo: Proper URL

abff1b9

[FIX] product_pricelist_supplierinfo: Avoid false computations

e2ac643

If you set the value "Based on" for using supplier info, but then you change the computation type to another one (like fixed price or discount), this code is still acting, so we should check both fields.

[11.0][FIX] product_pricelist_supplierinfo: Add template compatibility (

eac3ddb

OCA#436) Previously, only worked fine with product.product.

Added translation using Weblate (Italian)

d51d95b

Added translation using Weblate (Portuguese (Brazil))

2f05db6

[IMP] add margin on supplier info to configure the sale price

5e2ce97

When having price per qty at the supplier level and if you want to base your pricelist on the supplier price, now you can define a margin on the product.supplierinfo

francesco-ooops and others added 16 commits June 26, 2024 06:30

[FIX]product_pricelist_supplierinfo: fix tests

0c9b666

product_pricelist_supplierinfo 15.0.1.0.2

4ffc54e

[UPD] Update product_pricelist_supplierinfo.pot

f9b6b6d

[UPD] README.rst

af872c6

[UPD] Update product_pricelist_supplierinfo.pot

fbfbdf9

product_pricelist_supplierinfo 16.0.1.0.1

7056f8a

[UPD] README.rst

11dad1e

[IMP] product_pricelist_supplierinfo: pre-commit auto fixes

1a57fd5

mdurepos force-pushed the 17.0-mig-product_pricelist_supplierinfo branch 3 times, most recently from ef8cdac to 5cd2fab Compare June 26, 2024 10:52

[MIG] product_pricelist_supplierinfo: Migration to 17.0

126f0bc

mdurepos force-pushed the 17.0-mig-product_pricelist_supplierinfo branch from 5cd2fab to 126f0bc Compare June 26, 2024 10:55

OCA-git-bot added the bot is merging ⏳ label Jun 26, 2024

OCA-git-bot merged commit 57076fa into OCA:17.0 Jun 26, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0] [MIG] product_pricelist_supplierinfo: Migration to 17.0 #1632

[17.0] [MIG] product_pricelist_supplierinfo: Migration to 17.0 #1632

mdurepos commented Jun 11, 2024

suniagajose commented Jun 12, 2024

luisg123v Jun 13, 2024

mdurepos Jun 13, 2024

luisg123v Jun 13, 2024

luisg123v commented Jun 13, 2024

OCA-git-bot commented Jun 13, 2024

suniagajose commented Jun 17, 2024

luisg123v commented Jun 17, 2024

suniagajose commented Jun 17, 2024

moylop260 commented Jun 17, 2024

luisg123v commented Jun 17, 2024

pedrobaeza commented Jun 18, 2024

sbidoul commented Jun 24, 2024

pedrobaeza commented Jun 24, 2024

suniagajose commented Jun 24, 2024

mdurepos commented Jun 26, 2024

suniagajose commented Jun 26, 2024

moylop260 commented Jun 26, 2024

OCA-git-bot commented Jun 26, 2024

OCA-git-bot commented Jun 26, 2024

[17.0] [MIG] product_pricelist_supplierinfo: Migration to 17.0 #1632

[17.0] [MIG] product_pricelist_supplierinfo: Migration to 17.0 #1632

Conversation

mdurepos commented Jun 11, 2024

suniagajose commented Jun 12, 2024

luisg123v Jun 13, 2024

Choose a reason for hiding this comment

mdurepos Jun 13, 2024

Choose a reason for hiding this comment

luisg123v Jun 13, 2024

Choose a reason for hiding this comment

luisg123v commented Jun 13, 2024

OCA-git-bot commented Jun 13, 2024

suniagajose commented Jun 17, 2024

luisg123v commented Jun 17, 2024

suniagajose commented Jun 17, 2024

moylop260 commented Jun 17, 2024

luisg123v commented Jun 17, 2024

pedrobaeza commented Jun 18, 2024

sbidoul commented Jun 24, 2024

pedrobaeza commented Jun 24, 2024

suniagajose commented Jun 24, 2024

mdurepos commented Jun 26, 2024

suniagajose commented Jun 26, 2024

moylop260 commented Jun 26, 2024

OCA-git-bot commented Jun 26, 2024

OCA-git-bot commented Jun 26, 2024