Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] product_product_template_link #1674

Merged
merged 7 commits into from
Jan 13, 2025
Merged

[17.0][MIG] product_product_template_link #1674

merged 7 commits into from
Jan 13, 2025

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jul 1, 2024

No description provided.

@astirpe astirpe marked this pull request as ready for review July 1, 2024 07:14
@astirpe astirpe mentioned this pull request Jul 1, 2024
Open
61 tasks
bizzappdev
bizzappdev approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM
Functional Test: Works perfect

sanderlienaerts
sanderlienaerts approved these changes Jul 30, 2024
View reviewed changes
Copy link

@sanderlienaerts sanderlienaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module functions well and code seems fine, one small suggestion for the xpath selector

product_product_template_link/views/product_product_views.xml Outdated Show resolved Hide resolved
@PCatinean
Copy link

Other than what @sanderlienaerts mentioned in his review LGTM 👍

@sanderlienaerts
Copy link

Thanks @astirpe! LGTM

@PCatinean
Copy link

@pedrobaeza do you think you could help out with a review/merge on this PR as well please?

@pedrobaeza
Copy link
Member

Yes, the current reviewers seem enough for triggering the merge.

/ocabot migration product_product_template_link
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 31, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1674-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 31, 2024
@OCA-git-bot
Merge PR #1674 into 17.0
9df7e76 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1674-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Uhm, can you please rebase to check the CI?

@PCatinean
Copy link

@astirpe can you do a rebase when you have some time?

renda-dev and others added 7 commits January 12, 2025 21:18
@renda-dev @astirpe
[MIG] product_product_template_link: rename module
d3d029d
@astirpe
[UPD] Update product_product_template_link.pot
49a61a3
@mymage @astirpe
Translated using Weblate (Italian)
6c3d0e5 
Currently translated at 100.0% (2 of 2 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_product_template_link
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_product_template_link/it/
@Ivorra78 @astirpe
Translated using Weblate (Spanish)
8efd58b 
Currently translated at 100.0% (2 of 2 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_product_template_link
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_product_template_link/es/
@astirpe
[MIG] product_product_template_link: pre-commit
1b15d5a
@astirpe
[MIG] product_product_template_link: migrate to V17
ec67106
@astirpe
[MIG] product_product_template_link: code review
2e0cbc5
@astirpe astirpe force-pushed the 17_mig_product_product_template_link branch from e60bb8f to 2e0cbc5 Compare January 12, 2025 20:18
@astirpe
Copy link
Member Author

astirpe commented Jan 12, 2025

Rebased

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@PCatinean
Copy link

@pedrobaeza could you please trigger the merge once more?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1674-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 448b4ee. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit fec132b into OCA:17.0 Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderlienaerts sanderlienaerts sanderlienaerts approved these changes

@bizzappdev bizzappdev bizzappdev approved these changes

@PCatinean PCatinean PCatinean approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@astirpe @PCatinean @sanderlienaerts @pedrobaeza @OCA-git-bot @bizzappdev @renda-dev @mymage @Ivorra78