Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_abc_classification: Migration to 17.0 #1686

Open
wants to merge 24 commits into
base: 17.0
Choose a base branch
from

Conversation

fgaviiria
Copy link

No description provided.

MiquelRForgeFlow and others added 22 commits July 13, 2024 16:09
Currently translated at 8.0% (6 of 75 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/es/
Currently translated at 100.0% (75 of 75 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/
Currently translated at 100.0% (74 of 74 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/it/
The test on unicity constraint is passing but the error log from the ORM
must be muted to not get a false negative.
@fgaviiria fgaviiria force-pushed the 17.0-mig-product_abc_classification branch from cdee06b to 958aa35 Compare July 17, 2024 23:47
@fgaviiria fgaviiria force-pushed the 17.0-mig-product_abc_classification branch 3 times, most recently from e74083b to 0bf3ec5 Compare July 18, 2024 00:37
@fgaviiria fgaviiria force-pushed the 17.0-mig-product_abc_classification branch from 0bf3ec5 to d8e3c8b Compare July 18, 2024 00:43
@fgaviiria fgaviiria mentioned this pull request Jul 18, 2024
59 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration product_abc_classification

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

)
)

@api.onchange("product_tmpl_id")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to convert this onchange to a computed field on the product_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.