-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_abc_classification: Migration to 17.0 #1686
Open
fgaviiria
wants to merge
24
commits into
OCA:17.0
Choose a base branch
from
fgaviiria:17.0-mig-product_abc_classification
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] product_abc_classification: Migration to 17.0 #1686
fgaviiria
wants to merge
24
commits into
OCA:17.0
from
fgaviiria:17.0-mig-product_abc_classification
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n logic pluggable
Currently translated at 8.0% (6 of 75 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/es/
Currently translated at 100.0% (75 of 75 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/
Currently translated at 100.0% (74 of 74 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_abc_classification Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_abc_classification/it/
The test on unicity constraint is passing but the error log from the ORM must be muted to not get a false negative.
fgaviiria
force-pushed
the
17.0-mig-product_abc_classification
branch
from
July 17, 2024 23:47
cdee06b
to
958aa35
Compare
fgaviiria
force-pushed
the
17.0-mig-product_abc_classification
branch
3 times, most recently
from
July 18, 2024 00:37
e74083b
to
0bf3ec5
Compare
fgaviiria
force-pushed
the
17.0-mig-product_abc_classification
branch
from
July 18, 2024 00:43
0bf3ec5
to
d8e3c8b
Compare
jeer2234
approved these changes
Jul 18, 2024
/ocabot migration product_abc_classification |
rousseldenis
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
gbrito
suggested changes
Aug 15, 2024
) | ||
) | ||
|
||
@api.onchange("product_tmpl_id") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to convert this onchange to a computed field on the product_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.