-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_pricelist_fixed_currency_rate: Migration to 17.0 #1706
[17.0][MIG] product_pricelist_fixed_currency_rate: Migration to 17.0 #1706
Conversation
Currently translated at 100.0% (12 of 12 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/it/
Currently translated at 100.0% (12 of 12 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_fixed_currency_rate Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_fixed_currency_rate/es/
5ea899a
to
06287dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kobros-tech
Thanks for contributing. It looks good. One question though, any reason to covert all readme fragments to markdown?
@LoisRForgeFlow I don't know why but this is what happens. |
d13a31a
to
06287dc
Compare
I didn't realize that this was automated until now... thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
16afa63
to
6dd4a8c
Compare
@mymage I have added some tests for the new 17.0 version that were not covered in the previous 16.0 version. |
6dd4a8c
to
68a99f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functionally on runboat
@LoisRForgeFlow /ocabot merge patch |
Sorry @kobros-tech you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
/ocabot migration product_pricelist_fixed_currency_rate |
@kobros-tech For next time, it is better to put improvements in separate commits than migration one. That allows to easily backport or forwardport. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 0b97b84. Thanks a lot for contributing to OCA. ❤️ |
Thanks for notification, I promise I will put this into my account. |
I had to troubleshoot many bugs and they are not from my side.
I installed pandoc manually.
I modified a wrong code which is written in the documentation that describes how to use hooks.