Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_pricelist_fixed_currency_rate: Migration to 17.0 #1706

Conversation

kobros-tech
Copy link

I had to troubleshoot many bugs and they are not from my side.

I installed pandoc manually.
I modified a wrong code which is written in the documentation that describes how to use hooks.

@kobros-tech kobros-tech force-pushed the 17.0-mig-product_pricelist_fixed_currency_rate branch from 5ea899a to 06287dc Compare August 8, 2024 22:41
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kobros-tech

Thanks for contributing. It looks good. One question though, any reason to covert all readme fragments to markdown?

@kobros-tech
Copy link
Author

kobros-tech commented Aug 9, 2024

Hi @kobros-tech

Thanks for contributing. It looks good. One question though, any reason to covert all readme fragments to markdown?

@LoisRForgeFlow
when I run precommit command it converts marked down file like contributers file to be marked down then it gets deleted when I commit.

I don't know why but this is what happens.

@kobros-tech kobros-tech force-pushed the 17.0-mig-product_pricelist_fixed_currency_rate branch from d13a31a to 06287dc Compare August 9, 2024 09:03
@kobros-tech
Copy link
Author

@LoisRForgeFlow
Copy link
Contributor

Hi @kobros-tech
Thanks for contributing. It looks good. One question though, any reason to covert all readme fragments to markdown?

@LoisRForgeFlow when I run precommit command it converts marked down file like contributers file to be marked down then it gets deleted when I commit.

I don't know why but this is what happens.

I didn't realize that this was automated until now... thanks!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobros-tech kobros-tech force-pushed the 17.0-mig-product_pricelist_fixed_currency_rate branch from 16afa63 to 6dd4a8c Compare October 13, 2024 16:31
@kobros-tech
Copy link
Author

@mymage
@LoisRForgeFlow
@OCA-git-bot

I have added some tests for the new 17.0 version that were not covered in the previous 16.0 version.
There was a red flag asked me to test some values and I made the update on the commit for this reason.

@kobros-tech kobros-tech force-pushed the 17.0-mig-product_pricelist_fixed_currency_rate branch from 6dd4a8c to 68a99f0 Compare October 13, 2024 17:59
Copy link
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally on runboat

@kobros-tech
Copy link
Author

kobros-tech commented Nov 19, 2024

@LoisRForgeFlow
@mymage
Can we merge the pull request?

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @kobros-tech you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@rousseldenis
Copy link
Contributor

/ocabot migration product_pricelist_fixed_currency_rate

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 19, 2024
@rousseldenis
Copy link
Contributor

@kobros-tech For next time, it is better to put improvements in separate commits than migration one. That allows to easily backport or forwardport.

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1706-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7192a12 into OCA:17.0 Nov 19, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b97b84. Thanks a lot for contributing to OCA. ❤️

@kobros-tech
Copy link
Author

@kobros-tech For next time, it is better to put improvements in separate commits than migration one. That allows to easily backport or forwardport.

Thanks for notification, I promise I will put this into my account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants