[16.0][mig] product_multi_image #1707

IJOL · 2024-08-09T11:06:58Z

No description provided.

IJOL · 2024-08-09T11:34:24Z

Waiting for a merge in server-tools

thomaspaulb · 2024-09-07T08:40:59Z

@IJOL Can you rebase to see what this now does

IJOL · 2024-09-11T15:55:37Z

Green Green, needs review thought

AurelijaNorvaisaite · 2024-09-26T10:51:34Z

@jacekmichalski @rousseldenis @thomaspaulb maybe you could review the code?

product_multi_image/tests/test_product_multi_image.py

bosd

Thanks for your work on this. Please remove the new introduced comments in the migration commit.

product_multi_image/__manifest__.py

…r icon

* Upgrade product_multi_image to v9 * Add server-tools to oca_dependencies

* Migrate product_multi_image to v10 * Remove old api from `product.product` * Add test coverage for hooks and variant count * Fix oca depends * Add uninstall hook

multi to single mode

when saved from single image

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_multi_image Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_multi_image/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_multi_image Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_multi_image/es/

Currently translated at 100.0% (14 of 14 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_multi_image Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_multi_image/it/

IJOL · 2024-09-30T13:38:04Z

Thanks for your work on this. Please remove the new introduced comments in the migration commit.

I dont think I fully understand this remark..

bosd

To clarify this is what I was pointing at.

product_multi_image/tests/test_product_multi_image.py

yvaucher · 2024-09-30T14:03:24Z

/ocabot migration product_multi_image

yvaucher

LGTM

Code review

psugne · 2024-10-10T14:09:53Z

@bosd @yvaucher How is going here? Any timeline when changes will be merged to 16.0 version?

bosd

Thanks for all your work on this module. 👍
I have found some warnings in the log to call deprecated flush method.Added code suggestions to fix it.
I noticed there is some leftover from previous migration.

I have found some things that didn't work during functional tests.

On product variants incorrect values are shown in the variants section.

To reproduce....
Add an image from the product variant.Go to a product variant,
On Images tab click ADD.
In the screen that opens there is a "Visible in these Variants" section.
When clicking on the dropdown.
You can select another totally unrelated product (variant).
Which is actually quite confusing.
It should be restricted automatically to the variant you are editing.
But when you click save.
It actually does restrict the image to the variant you are editing.

First image is not saved when creating a new product.

To reproduce....
Create a new product.
Add one image, click save and new,
Add the second product image.
Hit the save button (The cloud symbol) Then you will notice the content of the first image is deleted.

Image is not saved on a newly created product

To reproduce....
Create a new product.
Go to images tab. Click add. select a image.Click "Save & Close".
You will see a preview of the image on the images tab.
Once you click the save button (The cloud symbol).
The image preview is deleted.

Image is deleted when changing the sequence.

To reproduce....
Create or select an existing product.
click on save button (The cloud icon).
Click the add button to add a image.
Upload an image click save and close.
Back in the product click on save button (The cloud icon).
Upload another image click save and close.
Back in the product click on save button (The cloud icon).
Click on the image you last uploaded to edit it.
Change sequence from 10 to a lower number.. e.g. 9
Click save
Now it is ok. Earlier my test was failling. Likely when not pressing the cloud icon.

It is possible to add an empty image

Rather more a "feature then a big bug"
To reproduce....
Create or select an existing product.
On Images tab click ADD.
Fill nothing in... Leave all empty. Click on save button.You have just added an empty picture to your product.

Adding an image from url results in an error.

Use the url field when adding an image.

``` Traceback (most recent call last): File "/opt/odoo/odoo/http.py", line 1651, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "/opt/odoo/odoo/service/model.py", line 133, in retrying result = func() File "/opt/odoo/odoo/http.py", line 1678, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "/opt/odoo/odoo/http.py", line 1882, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "/opt/odoo/addons/website/models/ir_http.py", line 237, in _dispatch response = super()._dispatch(endpoint) File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch result = endpoint(**request.params) File "/opt/odoo/odoo/http.py", line 734, in route_wrapper result = endpoint(self, *args, **params_ok) File "/opt/odoo/addons/web/controllers/dataset.py", line 42, in call_kw return self._call_kw(model, method, args, kwargs) File "/opt/odoo/addons/web/controllers/dataset.py", line 33, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "/opt/odoo/odoo/api.py", line 468, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "/opt/odoo/odoo/api.py", line 453, in _call_kw_multi result = method(recs, *args, **kwargs) File "/opt/odoo/odoo/models.py", line 6614, in onchange record._onchange_eval(name, field_onchange[name], result) File "/opt/odoo/odoo/models.py", line 6325, in _onchange_eval method_res = method(self) File "/opt/odoo-venv/lib/python3.10/site-packages/odoo/addons/base_multi_image/models/image.py", line 91, in _onchange_load_from self.name, self.extension = os.path.splitext(filename) AttributeError: 'base_multi_image.image' object has no attribute 'extension'

The above server error caused the following client error:
null

</details>

These 2 commits should be squashed:
![image](https://github.com/user-attachments/assets/4cfd9984-61dd-4dae-bdaa-c0975dde8dda)

bosd · 2024-10-10T17:24:44Z

product_multi_image/tests/test_product_multi_image.py

+                {"image_1920": self.grey_image},
+            )
+        ]
+        self.product_template.refresh()


Suggested change

self.product_template.refresh()

self.product_template.invalidate_cache()

bosd · 2024-10-10T17:25:02Z

product_multi_image/tests/test_product_multi_image.py

+    def test_edit_image_variant(self):
+        text = "Test name changed"
+        self.product_1.image_ids[0].name = text
+        self.product_template.refresh()


Suggested change

self.product_template.refresh()

self.product_template.invalidate_cache()

bosd · 2024-10-10T17:25:48Z

product_multi_image/tests/test_product_multi_image.py

+    def test_remove_image_all_variants(self):
+        self.product_1.image_ids = [(3, self.product_1.image_ids[0].id)]
+        self.product_2.image_ids = [(3, self.product_2.image_ids[0].id)]
+        self.product_template.refresh()


Suggested change

self.product_template.refresh()

self.product_template.invalidate_cache()

bosd · 2024-10-10T17:26:21Z

product_multi_image/tests/test_product_multi_image.py

+
+    def test_remove_image_variant(self):
+        self.product_1.image_ids = [(3, self.product_1.image_ids[0].id)]
+        self.product_template.refresh()


Suggested change

self.product_template.refresh()

self.product_template.invalidate_cache()

bosd · 2024-10-10T18:18:51Z

product_multi_image/readme/ROADMAP.rst

+* When you change the image on the product variant, the preview image of the
+  *Images* tab doesn't get refreshed until you refresh the browser, or if you
+  go to its template, but the image has been actually saved!


Suggested change

* When you change the image on the product variant, the preview image of the

*Images* tab doesn't get refreshed until you refresh the browser, or if you

go to its template, but the image has been actually saved!

This actually has been fixed. So can be removed from the roadmap.

bosd · 2024-10-10T19:38:04Z

product_multi_image/readme/CONFIGURE.rst

+#. If you add an image here, the image is actually added to the product
+   template, and restricted to this variant.
+#. When editing an existing image, the image is changed generally for all
+   the variants where is enabled, not only for this variant.


Suggested change

the variants where is enabled, not only for this variant.

the variants where it is enabled, not only for this variant.

bosd · 2024-10-10T19:39:22Z

product_multi_image/readme/CONFIGURE.rst

+   the variants where is enabled, not only for this variant.
+#. When removing an image from this form, if the image is only in this variant,
+   the image is removed. Otherwise, the image gets restricted to the rest of
+   the variants where is available.


Suggested change

the variants where is available.

the variants where it is used.

bosd · 2024-10-10T19:40:21Z

product_multi_image/readme/CONFIGURE.rst

+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/135/9.0


Suggested change

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas

:alt: Try me on Runbot

:target: https://runbot.odoo-community.org/runbot/135/9.0

Runbot 9 is no longer there. Better remove this section.

bosd · 2024-10-10T19:44:42Z

product_multi_image/tests/test_product_multi_image.py

+            image.product_variant_count,
+            1,
+        )
+


Maybe add an test to import image from url. As it is failling with an error currently.

Maybe add an test to import image from url. As it is failling with an error currently.

@bosd I think this issue has been fixed in this PR - OCA/server-tools#3168

product_multi_image/models/product_product.py

Co-authored-by: bosd <c5e2fd43-d292-4c90-9d1f-74ff3436329a@anonaddy.me>

AurelijaNorvaisaite · 2025-01-29T07:41:02Z

@IJOL How is going here?

IJOL force-pushed the 16.0-mig-product_multi_image branch 2 times, most recently from 05b9819 to b0ab882 Compare August 9, 2024 14:00

IJOL force-pushed the 16.0-mig-product_multi_image branch from f884ced to e4b0c54 Compare August 19, 2024 14:43

thomaspaulb mentioned this pull request Sep 7, 2024

[16.0][MIG] base_multi_image OCA/server-tools#3010

Merged

IJOL force-pushed the 16.0-mig-product_multi_image branch 4 times, most recently from d3286f3 to 57044a6 Compare September 11, 2024 15:49

IJOL force-pushed the 16.0-mig-product_multi_image branch 4 times, most recently from 71234e0 to 2373ea9 Compare September 19, 2024 14:33

AurelijaNorvaisaite reviewed Sep 26, 2024

View reviewed changes

product_multi_image/tests/test_product_multi_image.py Outdated Show resolved Hide resolved

bosd suggested changes Sep 30, 2024

View reviewed changes

product_multi_image/__manifest__.py Outdated Show resolved Hide resolved

pedrobaeza and others added 12 commits September 30, 2024 15:25

product_multi_image: Module totally redone from old product_images

8c2dd00

[IMP] product_multi_image: Split model in abstract & concrete + bette…

b1e9b1e

…r icon

Fix bugs found in review time, improve README.

832d5b5

product_multi_image: Handle images in variants

f62bf4e

[MIG] product_multi_image: Upgrade to v9

6e4097a

* Upgrade product_multi_image to v9 * Add server-tools to oca_dependencies

[MIG] product_multi_image: Upgrade to v10

84135af

* Migrate product_multi_image to v10 * Remove old api from `product.product` * Add test coverage for hooks and variant count * Fix oca depends * Add uninstall hook

[fix] prod image update broken w/ no image on template OCA#228

ed2262c

[IMP] product_multi_image: Improve uninstall hook to move images from

af99129

multi to single mode

[FIX] product_multi_image: Do not resize large image to small/medium

6a79763

when saved from single image

[FIX] product_multi_image: Fix image removal from variants

34ea152

[MIG] product_multi_image: Migration to 12.0

03613f3

[IMP] product_multi_image: black, isort, prettier

9363b36

hailangvn and others added 10 commits September 30, 2024 15:25

[MIG] product_multi_image: Migration to 14.0

afe1bf2

[IMP] product_multi_image: show images in product variant easy edit view

dc92ee4

[MIG] product_multi_image 15.0

f47815d

[UPD] Update product_multi_image.pot

fa3631a

[UPD] README.rst

91ded8f

[UPD] README.rst

acaa786

Added translation using Weblate (Italian)

c8abffa

IJOL force-pushed the 16.0-mig-product_multi_image branch from 7d33f46 to 6317125 Compare September 30, 2024 13:32

IJOL force-pushed the 16.0-mig-product_multi_image branch from 6317125 to 91a12df Compare September 30, 2024 13:44

bosd suggested changes Sep 30, 2024

View reviewed changes

product_multi_image/tests/test_product_multi_image.py Outdated Show resolved Hide resolved

product_multi_image/tests/test_product_multi_image.py Outdated Show resolved Hide resolved

product_multi_image/tests/test_product_multi_image.py Outdated Show resolved Hide resolved

IJOL force-pushed the 16.0-mig-product_multi_image branch from 91a12df to 2cc4f89 Compare September 30, 2024 13:47

[MIG] product_multi_image: Migration to 16.0

12e3233

IJOL force-pushed the 16.0-mig-product_multi_image branch from a9e1dc3 to 12e3233 Compare September 30, 2024 13:55

OCA-git-bot added this to the 16.0 milestone Sep 30, 2024

OCA-git-bot mentioned this pull request Sep 30, 2024

Migration to version 16.0 #1157

Open

60 tasks

yvaucher reviewed Sep 30, 2024

View reviewed changes

yvaucher approved these changes Sep 30, 2024

View reviewed changes

bosd suggested changes Oct 10, 2024

View reviewed changes

AurelijaNorvaisaite mentioned this pull request Oct 16, 2024

[17.0][MIG] product_multi_image: Migration to 17.0 #1748

Open

Update product_multi_image/models/product_product.py

71fd3bb

Co-authored-by: bosd <c5e2fd43-d292-4c90-9d1f-74ff3436329a@anonaddy.me>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][mig] product_multi_image #1707

[16.0][mig] product_multi_image #1707

IJOL commented Aug 9, 2024

IJOL commented Aug 9, 2024

thomaspaulb commented Sep 7, 2024

IJOL commented Sep 11, 2024

AurelijaNorvaisaite commented Sep 26, 2024

bosd left a comment

IJOL commented Sep 30, 2024

bosd left a comment

yvaucher commented Sep 30, 2024

yvaucher left a comment

psugne commented Oct 10, 2024

bosd left a comment •

edited

Loading

bosd Oct 10, 2024

bosd Oct 10, 2024

bosd Oct 10, 2024

bosd Oct 10, 2024

bosd Oct 10, 2024

bosd Oct 10, 2024

bosd Oct 10, 2024

bosd Oct 10, 2024

bosd Oct 10, 2024

Aldeigja Jan 17, 2025

AurelijaNorvaisaite commented Jan 29, 2025

	self.product_template.refresh()
	self.product_template.invalidate_cache()

	* When you change the image on the product variant, the preview image of the
	Images tab doesn't get refreshed until you refresh the browser, or if you
	go to its template, but the image has been actually saved!

	the variants where is enabled, not only for this variant.
	the variants where it is enabled, not only for this variant.

	the variants where is available.
	the variants where it is used.

	.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
	:alt: Try me on Runbot
	:target: https://runbot.odoo-community.org/runbot/135/9.0

[16.0][mig] product_multi_image #1707

Are you sure you want to change the base?

[16.0][mig] product_multi_image #1707

Conversation

IJOL commented Aug 9, 2024

IJOL commented Aug 9, 2024

thomaspaulb commented Sep 7, 2024

IJOL commented Sep 11, 2024

AurelijaNorvaisaite commented Sep 26, 2024

bosd left a comment

Choose a reason for hiding this comment

IJOL commented Sep 30, 2024

bosd left a comment

Choose a reason for hiding this comment

yvaucher commented Sep 30, 2024

yvaucher left a comment

Choose a reason for hiding this comment

psugne commented Oct 10, 2024

bosd left a comment • edited Loading

Choose a reason for hiding this comment

On product variants incorrect values are shown in the variants section.

First image is not saved when creating a new product.

Image is not saved on a newly created product

Image is deleted when changing the sequence.

It is possible to add an empty image

Adding an image from url results in an error.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AurelijaNorvaisaite commented Jan 29, 2025

bosd left a comment •

edited

Loading