[16.0][IMP] product_pricelist_direct_print add hooks #1782
Conversation
|
Hi @legalsylvain, @CarlosRoca13, |
mmequignon
force-pushed
the
16.0-product_pricelist_direct_print-add_hooks
branch
2 times, most recently
from
6600a87 to
bcf594a
Compare
mmequignon
force-pushed
the
16.0-product_pricelist_direct_print-add_hooks
branch
from
bcf594a to
049b53f
Compare
|
@legalsylvain @CarlosRoca13 |
| @@ -95,6 +96,20 @@ def _compute_product_price(self): | |||
| else: | |||
| self.product_price = price | |||
|
|
|||
| def get_price_for_pricelist(self, pricelist, product): | |||
| # TODO enable this instead | |||
There was a problem hiding this comment.
More like an open question for reviewers.
Is there a benefit for using a computed field depending on the context rather than using a method?
There was a problem hiding this comment.
I think your right. I'm not sure to understand the current design.
however, changing the code could break possible module overloading this module. Not sure what to think here.
In all cases, if you want to introduce questions, please add better a note in the ROADMAP.rst file that mention "replace computed function xxx by yyy when porting this module". i think it's better than adding commented code with TODO.
What do you think ?
There was a problem hiding this comment.
I agree with @legalsylvain, adding these changes to the module at this stage could cause inheritance issues in other modules that rely on them.
This pull requests add hooks to the following modules:
This is meant to make overrides of the reports easier.