Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] product_net_weight #1787

Merged
merged 30 commits into from
Dec 28, 2024
Merged

[18.0][MIG] product_net_weight #1787

merged 30 commits into from
Dec 28, 2024

Conversation

alexis-via
Copy link

No description provided.

legalsylvain and others added 30 commits November 27, 2024 17:26
@legalsylvain @alexis-via
[ADD][12.0] new module product_net_weight.
8a3d268 
- Add new net_weight field on product models;
- Rename weight field with 'Gross Weight' string;
@OCA-git-bot @alexis-via
[ADD] icon.png
a646dac
@manuelregidor @alexis-via
[IMP]product_net_weight: black, isort, prettier
6828dea
@manuelregidor @alexis-via
[MIG]product_net_weight: Migration to 14.0
8f8bee5
@flachica @alexis-via
[MIG][15.0] Standard migration product_net_weight
30d3d37
@alexis-via
[UPD] Update product_net_weight.pot
cb784c2
@OCA-git-bot @alexis-via
[UPD] README.rst
232aefd
@OCA-git-bot @alexis-via
product_net_weight 15.0.1.0.1
c9bcb1d
@alexis-via
[UPD] Update product_net_weight.pot
0784762
@weblate @alexis-via
Update translation files
6b122a9 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-15.0/product-attribute-15.0-product_net_weight
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_net_weight/
@victoralmau @alexis-via
[FIX] product_net_weight: Fix digits parameter.
8d5dde0
@OCA-git-bot @alexis-via
product_net_weight 15.0.1.0.2
c250316
@carlosdauden @alexis-via
Added translation using Weblate (Spanish)
fd6d724
@carlosdauden @alexis-via
Translated using Weblate (Spanish)
99714b2 
Currently translated at 88.8% (8 of 9 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_net_weight
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_net_weight/es/
@RabbitJon-S73 @alexis-via
[MIG] product_net_weight: Migration to 16.0
c22dc8a
@sergio-teruel @alexis-via
[IMP] product_net_weight: Adapt module like Odoo manage weight field …
5d95ff6 
…with multiple variants
@alexis-via
[UPD] Update product_net_weight.pot
0fe1910
@OCA-git-bot @alexis-via
[UPD] README.rst
9a416f1
@weblate @alexis-via
Update translation files
3abe999 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_net_weight
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_net_weight/
@Ivorra78 @alexis-via
Translated using Weblate (Spanish)
f9a5f48 
Currently translated at 100.0% (7 of 7 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_net_weight
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_net_weight/es/
@OCA-git-bot @alexis-via
[UPD] README.rst
fca0aad
@mymage @alexis-via
Added translation using Weblate (Italian)
ea43a37
@mymage @alexis-via
Translated using Weblate (Italian)
8f06c79 
Currently translated at 100.0% (7 of 7 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_net_weight
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_net_weight/it/
@remihb @alexis-via
[IMP] product_net_weight: pre-commit auto fixes
25c34a5
@remihb @alexis-via
[MIG] product_net_weight: Migration to 17.0
13e6d4e
@rf-ife @alexis-via
[MIG] product_net_weight: adjust form layout
b257451
@alexis-via
[UPD] Update product_net_weight.pot
8297987
@OCA-git-bot @alexis-via
[BOT] post-merge updates
e087790
@alexis-via
[IMP] product_net_weight: pre-commit auto fixes for v18 migration
f4929ca
@alexis-via
[MIG] product_net_weight to v18
72a552b
@alexis-via
Copy link
Author

/ocabot migrate minor

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via. Your command failed:

Invalid command: migrate.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@legalsylvain
Copy link
Contributor

/ocabot migration product_net_weight

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 27, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 27, 2024
Open
35 tasks
luc-adhoc
luc-adhoc approved these changes Dec 4, 2024
View reviewed changes
Copy link

@luc-adhoc luc-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis
rousseldenis requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little change

product_net_weight/models/product_product.py
raise ValidationError(
_("The net weight of product must be lower than gross weight.")
_("The net weight of product '%s' must be lower than gross weight.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use translation function arguments instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not required when you have a single variable term

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, there are no warning. Merging this...

@rvalyi
Copy link
Member

rvalyi commented Dec 28, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1787-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bf5ed84 into OCA:18.0 Dec 28, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b9cd96e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@rousseldenis rousseldenis rousseldenis requested changes

@luc-adhoc luc-adhoc luc-adhoc approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.