Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] product_variant_configurator_manual_creation: faster has_pending_variants computation for products with huge number of variant combinations #319

Closed
wants to merge 1 commit into from

Conversation

giarve
Copy link
Contributor

@giarve giarve commented Nov 12, 2023

A huge number of attribute lines and values creates an infinite loading screen for product template because it calculates a huge amount of combinations. The calculation for this can be skipped for this type of products as they will never be manually created.

The calculation function is similar to the one used by the product module.

Should be forward ported to 15.0!

@OCA-git-bot
Copy link
Contributor

Hi @ChrisOForgeFlow,
some modules you are maintaining are being modified, check this out!

…g_variants computation for products with huge number of variant combinations
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@github-actions github-actions bot closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants