[FIX] product_variant_configurator: returning domains in onchange doesn't work anymore #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdoutreloux
force-pushed
the
16.0-can_t_return_domain_in_onchange
branch
from
f6dbc01 to
364269d
Compare
ThomasBinsfeld
suggested changes
Mar 7, 2024
| for rec in self: | ||
| if not rec.product_tmpl_id._origin: | ||
| # no product template: allow any product | ||
| rec.product_id_configurator_domain = [] |
There was a problem hiding this comment.
Suggested change
| rec.product_id_configurator_domain = [] | |
| rec.product_id_configurator_domain = TRUE_DOMAIN |
from odoo.osv.expression
| # no product template: allow any product | ||
| rec.product_id_configurator_domain = [] | ||
| else: | ||
| domain, cont = product_obj._build_attributes_domain( |
There was a problem hiding this comment.
Suggested change
| domain, cont = product_obj._build_attributes_domain( | |
| domain, _cont = product_obj._build_attributes_domain( |
Prefix unused variable with _
| product = self.product_product.new( | ||
| {"name": "Test product", "product_tmpl_id": self.product_template_yes.id} | ||
| ) | ||
| product.product_tmpl_id = self.product_template_empty_yes | ||
| res = product._onchange_product_tmpl_id_configurator() | ||
| # res = product._onchange_product_tmpl_id_configurator() |
There was a problem hiding this comment.
Remove or restore commented code.
jdoutreloux
force-pushed
the
16.0-can_t_return_domain_in_onchange
branch
from
364269d to
f3b4572
Compare
ThomasBinsfeld
approved these changes
Mar 7, 2024
jdoutreloux
added a commit
to acsone/product-variant
that referenced
this pull request
Mar 7, 2024
jdoutreloux
force-pushed
the
16.0-can_t_return_domain_in_onchange
branch
from
f3b4572 to
f0826c6
Compare
…sn't work anymore
jdoutreloux
force-pushed
the
16.0-can_t_return_domain_in_onchange
branch
from
f0826c6 to
c0cb2a2
Compare
FrancoMaxime
approved these changes
Mar 12, 2024
victoralmau
approved these changes
Apr 2, 2024
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 329134e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.