-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 mig project task default stage #1014
16.0 mig project task default stage #1014
Conversation
Currently translated at 100,0% (16 of 16 strings) Translation: project-11.0/project-11.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_BR/
Currently translated at 100,0% (16 of 16 strings) Translation: project-11.0/project-11.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_PT/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/gl/
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/es/
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/de/
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/pt_BR/
Currently translated at 94.1% (16 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/it/
Currently translated at 100.0% (17 of 17 strings) Translation: project-13.0/project-13.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_default_stage/ca/
Currently translated at 100.0% (20 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/es_AR/
Currently translated at 80.0% (16 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr_FR/
Currently translated at 100.0% (17 of 17 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function review: It worked as expected.
/ocabot migration project_task_default_stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
It looks like something changed on |
Congratulations, your PR was merged at 354132a. Thanks a lot for contributing to OCA. ❤️ |
<?xml version="1.0" encoding="utf-8" ?> | ||
<odoo noupdate="1"> | ||
<!-- Task Stages --> | ||
<record id="project_tt_analysis" model="project.task.type"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look demo data. Why it is in the data folder ?
Analysis / Specification / Merge are IT stages, it's not universal.
Don't you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been this way for ages, following Odoo's inheritance that included this on old versions. They can be removed, but I find them useful as initial stage set. They can be put as not default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been this way for ages, following Odoo's inheritance that included this on old versions.
Yes, you're right, the code comes from Odoo code since V9.
They can be removed
Well, the problem I see is that when we install modules, we expect that there are no "functional data". Only technical one that should not be dropped. the question I asked myself was, "if I delete this data, will it make the application crash? like base.main_company
, product.product_category_all
.
but I find them useful as initial stage set
well, I'm in favor to remove that data from the "data". 2 options :
- we move data into demo folder.
- we create a trivial
project_task_it_task_data
that just load data. after all, this data can be useful, even outside the context of the current module?
I can make a PR if you are agree with one of the solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't consider them demo data, and also an extra module is overkilled. Let's remove them if others agree.
No description provided.