Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig project task default stage #1014

Merged
merged 41 commits into from
Nov 10, 2022

Conversation

uncannycs
Copy link

No description provided.

sergio-teruel and others added 30 commits November 2, 2022 19:34
Currently translated at 100,0% (16 of 16 strings)

Translation: project-11.0/project-11.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_BR/
Currently translated at 100,0% (16 of 16 strings)

Translation: project-11.0/project-11.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_PT/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (17 of 17 strings)

Translation: project-12.0/project-12.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/gl/
Currently translated at 100.0% (17 of 17 strings)

Translation: project-12.0/project-12.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: project-12.0/project-12.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/de/
Currently translated at 100.0% (17 of 17 strings)

Translation: project-12.0/project-12.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/pt_BR/
Currently translated at 94.1% (16 of 17 strings)

Translation: project-12.0/project-12.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/it/
Currently translated at 100.0% (17 of 17 strings)

Translation: project-13.0/project-13.0-project_task_default_stage
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_default_stage/ca/
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function review: It worked as expected.

@leemannd
Copy link

leemannd commented Nov 9, 2022

/ocabot migration project_task_default_stage

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 9, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 9, 2022
38 tasks
Copy link
Contributor

@emagdalenaC2i emagdalenaC2i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@leemannd
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1014-by-leemannd-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 10, 2022
Signed-off-by leemannd
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-1014-by-leemannd-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8b05c82 into OCA:16.0 Nov 10, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 354132a. Thanks a lot for contributing to OCA. ❤️

<?xml version="1.0" encoding="utf-8" ?>
<odoo noupdate="1">
<!-- Task Stages -->
<record id="project_tt_analysis" model="project.task.type">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look demo data. Why it is in the data folder ?
Analysis / Specification / Merge are IT stages, it's not universal.

Don't you think ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been this way for ages, following Odoo's inheritance that included this on old versions. They can be removed, but I find them useful as initial stage set. They can be put as not default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been this way for ages, following Odoo's inheritance that included this on old versions.

Yes, you're right, the code comes from Odoo code since V9.

They can be removed

Well, the problem I see is that when we install modules, we expect that there are no "functional data". Only technical one that should not be dropped. the question I asked myself was, "if I delete this data, will it make the application crash? like base.main_company, product.product_category_all.

but I find them useful as initial stage set

well, I'm in favor to remove that data from the "data". 2 options :

  • we move data into demo folder.
  • we create a trivial project_task_it_task_datathat just load data. after all, this data can be useful, even outside the context of the current module?

I can make a PR if you are agree with one of the solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't consider them demo data, and also an extra module is overkilled. Let's remove them if others agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.