[16.0][MIG] project_timesheet_time_control: Migration to version 16.0 #1148

stefan-tecnativa · 2023-07-06T14:18:45Z

cc @Tecnativa TT43239

@Yadier-Tecnativa @CarlosRoca13 please review!

this PR superseeds #1133

Yadier-Tecnativa

the code LGTM

ygol · 2023-07-08T07:34:18Z

getting error on runbot

click on "Start work" in a task
add a description
click on "Start New Timer"
getting following error

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1584, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1611, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 1815, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 48, in call_button
    return clean_action(action, env=request.env)
  File "/opt/odoo/addons/web/controllers/utils.py", line 35, in clean_action
    readable_fields = env[action['type']]._get_readable_fields()
  File "/opt/odoo/odoo/api.py", line 537, in __getitem__
    return self.registry[model_name](self, (), ())
  File "/opt/odoo/odoo/modules/registry.py", line 190, in __getitem__
    return self.models[model_name]
KeyError: 'ir.actions.act_multi'

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
    at makeErrorFromResponse (http://oca-project-16-0-pr1148-5eae6387e809.runboat.odoo-community.org/web/assets/627-1bdd447/web.assets_backend.min.js:985:163)
    at XMLHttpRequest.<anonymous> (http://oca-project-16-0-pr1148-5eae6387e809.runboat.odoo-community.org/web/assets/627-1bdd447/web.assets_backend.min.js:993:13)

pedrobaeza · 2023-07-10T07:27:46Z

/ocabot migration project_timesheet_time_control

@stefan-tecnativa please remove the code that is doing reference to the removed dependencies, like the one with the action ir.actions.act_multi.

stefan-tecnativa · 2023-07-10T08:47:50Z

I closed it by mistake 😅
@ygol corrected, you can try again now.

project_timesheet_time_control/__manifest__.py

ygol · 2023-07-10T10:48:25Z

I closed it by mistake sweat_smile @ygol corrected, you can try again now.

Not getting the error anymore.

CarlosRoca13

Code and functional review 👍

DorianMAG

Hi @stefan-tecnativa.
Thx for this work !
Tested on ruboat.
LGTM

project_timesheet_time_control/views/account_analytic_line_view.xml

project_timesheet_time_control/views/project_project_view.xml

project_timesheet_time_control/wizards/hr_timesheet_switch_view.xml

AntoniRomera · 2023-07-31T09:04:24Z

@pedrobaeza Is this already correct?

* Decorate methods correctly + README imp * Add tests * Add button on tasks * Better README * open/close behaviour

… as False (OCA#321)

Update README Adapt tests Redefine the new kanban and form view of account.analytic.line to add 'Close/Open task' button and 'Stop' button

We need to override standard onchange, as it resets the previously introduced task.

Currently translated at 100.0% (67 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/es_AR/

Currently translated at 88.0% (59 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/nl/

Currently translated at 95.5% (64 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/fr/

Currently translated at 14.9% (10 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/it/

Currently translated at 100.0% (76 of 76 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/es_AR/

Currently translated at 96.0% (73 of 76 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/fi/

Some modules that add new fields dynamically, as analytic_tag_dimension, will cause an error when trying to read the fields to get them from cache. With this change we avoid that read and we make a copy of the analytic line if the wizard is opened from its and we create a new analytic line if don't.

Since v14, `string` attribute of <button> elements are directly shown in the views as text instead of being a tooltip, and thus, it takes a lot of space in screen. And it was not the intended visualization when the modules was conceived, just a side effect. Thus, we restore what we expect, moving `string` to `title` for having the tooltips again. TT40169

Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/es_AR/

Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/es/

Error: AttributeError: type object 'expression' has no attribute AND

That way, we don't have an error coming from the previous version

Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/

…oup to company_id field from wizard

Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/

Co-Authored-By: Stefan Ungureanu <stefan.ungureanu@tecnativa.com> Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2023-08-01T18:02:08Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1148-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2023-08-01T18:08:36Z

Congratulations, your PR was merged at 75ea46e. Thanks a lot for contributing to OCA. ❤️

stefan-tecnativa force-pushed the 16.0-mig-project_timesheet_time_control branch from b7d4495 to 5eae638 Compare July 6, 2023 14:23

Yadier-Tecnativa approved these changes Jul 6, 2023

View reviewed changes

pedrobaeza mentioned this pull request Jul 10, 2023

[16.0][mig] project_timesheet_time_control #1133

Closed

OCA-git-bot added this to the 16.0 milestone Jul 10, 2023

OCA-git-bot mentioned this pull request Jul 10, 2023

Migration to version 16.0 #988

Open

38 tasks

stefan-tecnativa force-pushed the 16.0-mig-project_timesheet_time_control branch from 5eae638 to b9010d2 Compare July 10, 2023 08:43

stefan-tecnativa closed this Jul 10, 2023

stefan-tecnativa reopened this Jul 10, 2023

pedrobaeza reviewed Jul 10, 2023

View reviewed changes

project_timesheet_time_control/__manifest__.py Outdated Show resolved Hide resolved

stefan-tecnativa force-pushed the 16.0-mig-project_timesheet_time_control branch from b9010d2 to d0b5283 Compare July 10, 2023 10:39

AntoniRomera mentioned this pull request Jul 10, 2023

[16.0][MIG] helpdesk_mgmt_timesheet: Migration 16.0 OCA/helpdesk#483

Merged

AntoniRomera approved these changes Jul 12, 2023

View reviewed changes

OCA-git-bot added the approved label Jul 12, 2023

CarlosRoca13 approved these changes Jul 12, 2023

View reviewed changes

DorianMAG approved these changes Jul 20, 2023

View reviewed changes

pedrobaeza requested changes Jul 20, 2023

View reviewed changes

OCA-git-bot removed approved labels Jul 20, 2023

stefan-tecnativa force-pushed the 16.0-mig-project_timesheet_time_control branch from d0b5283 to 3f9662a Compare July 21, 2023 05:47

sergio-teruel and others added 6 commits August 1, 2023 19:58

project_timesheet_time_control: Module rename and fixes

31913d5

project_timesheet_time_control

7bcc8fe

* Decorate methods correctly + README imp * Add tests * Add button on tasks * Better README * open/close behaviour

[MIG] project_timesheet_time_control: Migrated to 10.0

7e5a49f

[FIX] project_timesheet_time_control: Condition always gets evaluated…

7edb4a1

… as False (OCA#321)

[MIG] project_timesheet_time_control: Migration to 11.0

bc6fb9f

Update README Adapt tests Redefine the new kanban and form view of account.analytic.line to add 'Close/Open task' button and 'Stop' button

[FIX] project_timesheet_time_control: Don't reset task

6a90344

We need to override standard onchange, as it resets the previously introduced task.

ibuioli and others added 20 commits August 1, 2023 19:59

[project_timesheet_time_control] 14.0 fix warning

5aac562

Translated using Weblate (Dutch)

82e6c72

Currently translated at 88.0% (59 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/nl/

Translated using Weblate (French)

46f8729

Currently translated at 95.5% (64 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/fr/

Translated using Weblate (Italian)

5f0e132

Currently translated at 14.9% (10 of 67 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/it/

[DCK] Remove development_status to project_timesheet_time_control.

b611eb4

Translated using Weblate (Finnish)

e777b39

Currently translated at 96.0% (73 of 76 strings) Translation: project-14.0/project-14.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_timesheet_time_control/fi/

[MIG] project_timesheet_time_control: Migration to 15.0

f413ce4

Translated using Weblate (Spanish)

4b54eaf

Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/es/

[15.0][FIX][project_timesheet_time_control]

3e73772

Error: AttributeError: type object 'expression' has no attribute AND

[OU-ADD] project_timesheet_time_control: Reset view inheritance

f8248fd

That way, we don't have an error coming from the previous version

Translated using Weblate (Italian)

686ac50

Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/

[IMP] project_timesheet_time_control: Add base.group_multi_company gr…

e7d660c

…oup to company_id field from wizard

Translated using Weblate (Italian)

14fdd4f

Currently translated at 100.0% (49 of 49 strings) Translation: project-15.0/project-15.0-project_timesheet_time_control Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_timesheet_time_control/it/

[IMP] project_timesheet_time_control: black, isort, prettier

932a026

[MIG] project_timesheet_time_control: Migration to 16.0

d11d992

Co-Authored-By: Stefan Ungureanu <stefan.ungureanu@tecnativa.com> Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>

pedrobaeza force-pushed the 16.0-mig-project_timesheet_time_control branch from 3f9662a to d11d992 Compare August 1, 2023 18:00

pedrobaeza approved these changes Aug 1, 2023

View reviewed changes

OCA-git-bot added the approved label Aug 1, 2023

OCA-git-bot added the bot is merging ⏳ label Aug 1, 2023

OCA-git-bot added a commit that referenced this pull request Aug 1, 2023

Merge PR #1148 into 16.0

a2daa2d

Signed-off-by pedrobaeza

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 1, 2023

OCA-git-bot closed this Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] project_timesheet_time_control: Migration to version 16.0 #1148

[16.0][MIG] project_timesheet_time_control: Migration to version 16.0 #1148

stefan-tecnativa commented Jul 6, 2023

Yadier-Tecnativa left a comment

ygol commented Jul 8, 2023

pedrobaeza commented Jul 10, 2023

stefan-tecnativa commented Jul 10, 2023

ygol commented Jul 10, 2023 •

edited

Loading

CarlosRoca13 left a comment

DorianMAG left a comment

AntoniRomera commented Jul 31, 2023

pedrobaeza left a comment

OCA-git-bot commented Aug 1, 2023

OCA-git-bot commented Aug 1, 2023

[16.0][MIG] project_timesheet_time_control: Migration to version 16.0 #1148

[16.0][MIG] project_timesheet_time_control: Migration to version 16.0 #1148

Conversation

stefan-tecnativa commented Jul 6, 2023

Yadier-Tecnativa left a comment

Choose a reason for hiding this comment

ygol commented Jul 8, 2023

pedrobaeza commented Jul 10, 2023

stefan-tecnativa commented Jul 10, 2023

ygol commented Jul 10, 2023 • edited Loading

CarlosRoca13 left a comment

Choose a reason for hiding this comment

DorianMAG left a comment

Choose a reason for hiding this comment

AntoniRomera commented Jul 31, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 1, 2023

OCA-git-bot commented Aug 1, 2023

ygol commented Jul 10, 2023 •

edited

Loading