[16.0][MIG] project_sequence: Migration to version 16.0 #1155
Conversation
NICO-SOLUTIONS
force-pushed
the
16.0-mig-project_sequence
branch
13 times, most recently
from
91f9466 to
d106bb4
Compare
|
This PR has the |
|
/ocabot migration project_sequence |
|
Hello @NICO-SOLUTIONS , Thank you for your contribution. |
|
translations into the IMP pre-commit stuff commit? |
|
Into this wiki, you'll find all main point to be done during migration, especially a full (long) explanation on the squashing of commits -> https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate |
NICO-SOLUTIONS
force-pushed
the
16.0-mig-project_sequence
branch
from
d106bb4 to
34244c0
Compare
|
@leemannd |
NICO-SOLUTIONS
force-pushed
the
16.0-mig-project_sequence
branch
2 times, most recently
from
9641d8d to
1e5ca90
Compare
|
Hello, it seems something went wrong with rebase. There are a lot of commits that aren't related to this migration |
That's because my translation commits do not refer to the migration of this module. Translations referring to other modules of this repo. That's why I was confused by squashing suggestion. |
When a project has a name, still the sequence is a very important field to be displayed. I move it below the project name. @moduon MT-1506
`hr_timesheet` creates an analytic account by default. The method it uses to create it expects a preexisting name. But since we're making name not required, we're breaking other module's expectations. To fix this problem, now the name sync is done before writing or creating records, and not after. To make sure the problem doesn't happen anymore, we keep the `NOT NULL` requirement on project names. We just do it with a manual SQL constraint. This extra protection ensures compatibility with any other modules that expect always a value on the name. Any possibly misconfigured sequence could produce sequence duplicates. I also add protection against that. In tests, the project sequence was wrongly reset to 11 only once. Turns out that it survives the test savepoint, so I now reset it before each test instead. Tests are more reliable now. Besides, I added some more. @moduon MT-1506 wip wip
NICO-SOLUTIONS
force-pushed
the
16.0-mig-project_sequence
branch
from
1e5ca90 to
b516b82
Compare
@leemannd If there is anything unclear to me, please open my eyes. Sorry for the hassle... Still improving my git skills. Learned a lot about interactive rebasing now ;P |
|
Let me show you graphically the expected squashing:
|
These projects shouldn't display "False - Project name" in their display names. @moduon MT-1506 [UPD] Update project_sequence.pot [UPD] README.rst project_sequence 14.0.0.1.1
To change the project display name pattern, follow these steps: 1. Go to *Project > Configuration > Settings*. 2. Edit the *Project display name pattern* field. The default format is ``%(sequence_code)s - %(name)s``. You can use those same placeholders to customize the pattern. @moduon MT-1506 [UPD] Update project_sequence.pot [UPD] README.rst project_sequence 14.0.0.2.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-14.0/project-14.0-project_sequence Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_sequence/
@moduon MT-2822 [UPD] Update project_sequence.pot [UPD] README.rst project_sequence 15.0.0.2.1
Translated using Weblate (Italian) Currently translated at 100.0% (9 of 9 strings) Translation: project-15.0/project-15.0-project_sequence Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_sequence/it/
NICO-SOLUTIONS
force-pushed
the
16.0-mig-project_sequence
branch
from
b516b82 to
a941264
Compare
|
@pedrobaeza @leemannd |
|
@NICO-SOLUTIONS Thank you for the work |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 00ae9c6. Thanks a lot for contributing to OCA. ❤️ |
standard migration