Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] project_key #1210

Merged
merged 36 commits into from
Mar 28, 2024
Merged

[16.0][MIG] project_key #1210

merged 36 commits into from
Mar 28, 2024

Conversation

vincent-hatakeyama
Copy link

Supersedes #1169 with multi create.

@bhaveshselarka
Copy link

@vincent-hatakeyama thanks for the migration. @dreispt tested works okay, I think we can merge this.

@vincent-hatakeyama vincent-hatakeyama mentioned this pull request Jan 23, 2024
Closed
@dreispt
Copy link
Member

dreispt commented Mar 22, 2024

Superseded by #1210

@dreispt dreispt closed this Mar 22, 2024
@dreispt dreispt reopened this Mar 22, 2024
@dreispt dreispt mentioned this pull request Mar 22, 2024
Closed
@dreispt
Copy link
Member

dreispt commented Mar 22, 2024

/ocabot merge nobump
/ocabot migration project_key

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 22, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 22, 2024
Open
38 tasks
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1210-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 22, 2024
@OCA-git-bot
Merge PR #1210 into 16.0
7c10eea 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1210-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

petrus-v and others added 11 commits March 26, 2024 16:47
@petrus-v @vincent-hatakeyama
try fixing CI
2ba3645
@yweng8111 @vincent-hatakeyama
[IMP] add function to generate unique project key automatically.
21a7c1f
@primes2h @vincent-hatakeyama
Added translation using Weblate (Italian)
3a287e6
@vincent-hatakeyama
[UPD] Update project_key.pot
8d7357f
@weblate @vincent-hatakeyama
Update translation files
d1269ed 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-14.0/project-14.0-project_key
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_key/
@ibuioli @vincent-hatakeyama
Translated using Weblate (Spanish (Argentina))
7e77040 
Currently translated at 100.0% (12 of 12 strings)

Translation: project-14.0/project-14.0-project_key
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_key/es_AR/
@mymage @vincent-hatakeyama
Translated using Weblate (Italian)
6788deb 
Currently translated at 83.3% (10 of 12 strings)

Translation: project-14.0/project-14.0-project_key
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_key/it/
@eferriere @vincent-hatakeyama
[IMP] project_key: black, isort, prettier
1152e1d
@eferriere @vincent-hatakeyama
[MIG] project_key: Migration to 15.0
9229ecf
@eferriere @vincent-hatakeyama
The key sequences to create stories and tasks with keys, created with
eb18510 
a project, must be linked to the project company to avoid security
issues.
@vincent-hatakeyama
[IMP] project_key: pre-commit stuff
d0d69b9
@vincent-hatakeyama
Copy link
Author

I’ve rebased and will try to fix the failing tests. It seems to be an incompatibility between this module and another.

@vincent-hatakeyama vincent-hatakeyama force-pushed the 16.0-mig-project_key branch 2 times, most recently from 52f1549 to dc11464 Compare March 27, 2024 09:25
@vincent-hatakeyama
[MIG] project_key: Migration to 16.0
a4df33f 
aronabencherif.diatta@xcg.africa: Update with 'model_create_multi'
decorator to allow several records to be taken at once

vincent.hatakeyama@xcg-consulting.fr: Fix _rec_names_search on project by
including 'name'. Fix task creation.
@vincent-hatakeyama
Copy link
Author

I’ve fixed the issues in the migration that made other modules tests fail.

@vincent-hatakeyama
Copy link
Author

@dreispt You should be able to ask the bot to resume merging now that the tests are running correctly.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Mar 28, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1210-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a53642b into OCA:16.0 Mar 28, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5df9b07. Thanks a lot for contributing to OCA. ❤️

@vincent-hatakeyama vincent-hatakeyama deleted the 16.0-mig-project_key branch March 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@hspl-priva hspl-priva hspl-priva approved these changes

@hspl-niharika hspl-niharika hspl-niharika approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.