Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] purchase_merge: Migration to 16.0 #1887

Merged
merged 6 commits into from
Jun 5, 2023
Merged

[16.0][MIG] purchase_merge: Migration to 16.0 #1887

merged 6 commits into from
Jun 5, 2023

Conversation

flalexg
Copy link
Contributor

@flalexg flalexg commented Jun 5, 2023

No description provided.

@flalexg flalexg mentioned this pull request Jun 5, 2023
Open
53 tasks
@HviorForgeFlow
Copy link
Member

It would be nice to increase code coverage during this migration, forcing to raise all _check_content Validation errors

@flalexg flalexg force-pushed the 16.0-mig-purchase_merge branch from a7a08c5 to daa677d Compare June 5, 2023 14:42
@flalexg flalexg force-pushed the 16.0-mig-purchase_merge branch from daa677d to e196284 Compare June 5, 2023 14:46
HviorForgeFlow
HviorForgeFlow approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for increasing the test coverage

AaronHForgeFlow
AaronHForgeFlow approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1887-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 39d444c into OCA:16.0 Jun 5, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2ec0586. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flalexg @HviorForgeFlow @OCA-git-bot @AaronHForgeFlow @MiquelRForgeFlow @BojanOD