Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] purchase_partner_selectable_option #1893

Merged

Conversation

jaenbox
Copy link
Contributor

@jaenbox jaenbox commented Jun 5, 2023

Migration to v16.0. Changed the method "fields_view_get()" to "get_view()"

@jaenbox jaenbox force-pushed the 16.0-mig-purchase_partner_selectable_option branch from a0caba7 to da126e7 Compare June 5, 2023 18:55
@jaenbox jaenbox mentioned this pull request Jun 6, 2023
53 tasks
Copy link

@navarrorico navarrorico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link
Contributor

@flalexg flalexg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM!

Copy link
Contributor

@ChristianSantamaria ChristianSantamaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functional review 👍

The first commit must be renamed:
[IMP] : pre-commit stuff
to
[IMP] purchase_partner_selectable_option: pre-commit stuff

Copy link
Contributor

@hugo-cordoba hugo-cordoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Code + Functional Review)

Captura de pantalla de 2023-06-06 13-34-01

Captura desde 2023-06-06 13-33-49

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1893-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 023917a into OCA:16.0 Jun 7, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 66a984c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants