Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] procurement_purchase_no_grouping: Migration to 16.0 #2186

Merged

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 28, 2024

Superseed #1877

Migration to 16.0

Please @pedrobaeza and @sergio-teruel can you review it?

@Tecnativa TT46588

@pedrobaeza
Copy link
Member

/ocabot migration procurement_purchase_no_grouping

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 4, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 4, 2024
53 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both migration commits can be joined and put co-authorship in the resulting one, as it doesn't add too much value separated.

procurement_purchase_no_grouping/models/stock_rule.py Outdated Show resolved Hide resolved
alfredoavanzosc and others added 25 commits March 4, 2024 13:48
…ion to avoid problems on other searches made on same method
Currently translated at 100.0% (8 of 8 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-procurement_purchase_no_grouping/zh_CN/
When purchase grouping is set to no order grouping, the previously returned domain
ensured no other PO is found, but being the same domain for all will make that they
are grouped together in a batch operation, like the creation of all procurements
from a confirmed sales order.

Steps to reproduce:

* Create 2 products with MTO and different vendors.
* Add both in a sales order.
* Confirm the sales order.
* One purchase order is created for both products instead of 2, more even in this
  case that they have different vendors.

Fixes OCA#975
procurement_purchase_no_grouping 13.0.2.0.0
…red_purchase_grouping field

procurement_purchase_no_grouping 13.0.3.0.0
Steps to reproduce:

- Create a product with MTO route and "No line grouping" product
  category.
- Create an SO with such product and quantity = 1.
- Confirm it.
- A purchase order is created with such product and qty = 1.
- Edit the sales order, and change quantity = 2.

Current behavior:

A new purchase line is created with quantity = 2, having ordered 3 units
instead of 2.

Expected behavior:

The same existing purchase line is updated with quantity = 2.

------

For solving this problem, we are going to group by procurement group
instead of simply discarding any possible line grouping.

NOTE: This makes that if you manually assign the same procurement group
to several different sales orders, the grouping will be done no matter
the grouping criteria, but this is the only way to do it without having
to put a lot of glue modules, and on standard operation mode,
procurement groups are not reused between sales orders.

TT33031
[UPD] Update procurement_purchase_no_grouping.pot

[UPD] README.rst
Currently translated at 5.8% (1 of 17 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-procurement_purchase_no_grouping/pt_BR/
procurement_purchase_no_grouping 15.0.1.0.1
Currently translated at 5.8% (1 of 17 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-procurement_purchase_no_grouping/it/
Currently translated at 100.0% (17 of 17 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-procurement_purchase_no_grouping/es/

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-15.0/purchase-workflow-15.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-procurement_purchase_no_grouping/
josep-tecnativa and others added 6 commits March 4, 2024 13:48
- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates
Currently translated at 100.0% (17 of 17 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-procurement_purchase_no_grouping/es/
[UPD] Update procurement_purchase_no_grouping.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-15.0/purchase-workflow-15.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-procurement_purchase_no_grouping/
Currently translated at 100.0% (16 of 16 strings)

Translation: purchase-workflow-15.0/purchase-workflow-15.0-procurement_purchase_no_grouping
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-procurement_purchase_no_grouping/es/
@victoralmau victoralmau force-pushed the 16.0-mig-procurement_purchase_no_grouping branch from 9b5e820 to f17d99d Compare March 4, 2024 12:51
@victoralmau
Copy link
Member Author

Changes done.

@pedrobaeza pedrobaeza requested a review from sergio-teruel March 4, 2024 15:38
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2186-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b49c8d2 into OCA:16.0 Mar 5, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40a5c79. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-procurement_purchase_no_grouping branch March 5, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.