Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] purchase_triple_discount #930

Closed

Conversation

benwillig
Copy link
Contributor

Duplicate of #912 but based on OCA/account-invoicing#733

chienandalu and others added 18 commits June 16, 2020 09:14
- remove dependency to obsolete module product_supplierinfo_discount
- rename procurement.rule into stock.rule
- Use new hook introduced in purchase_discount V12 to add discount2 and discount3
- Introduce discount2 and discount3 in purchase.report model
* Lighter algorithm when synchronizing PO line info to product.supplierinfo.
* Use new create multi method for performance.
* Better SQL expresion in purchase report for decreasing the number of operations.
* Add test for purchase report.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/
Currently translated at 100.0% (15 of 15 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/
Currently translated at 100.0% (15 of 15 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_triple_discount
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_triple_discount/it/
@legalsylvain
Copy link
Contributor

Hi @benwillig. could you cherry pick recent commit : #929

@benwillig
Copy link
Contributor Author

Hi @legalsylvain, I already fixed the view during the migration. Do you want the v12 commit to appear in the history? Just asking to be sure

@legalsylvain
Copy link
Contributor

Hi @legalsylvain, I already fixed the view during the migration. Do you want the v12 commit to appear in the history? Just asking to be sure

No, it's ok ! Thanks for porting this module.

@HviorForgeFlow HviorForgeFlow mentioned this pull request Nov 11, 2020
61 tasks
@chusamo
Copy link

chusamo commented Dec 11, 2020

@benwillig Hello, do you need help in order to merge this? I can help to you if you want

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add account-invoicing to oca_dependencies.txt

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 25, 2022
@github-actions github-actions bot closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.