[17.0] [IMP] queue_job: HA job runner using session level advisory lock #673
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @guewen, |
guewen
approved these changes
Aug 6, 2024
gurneyalex
approved these changes
Sep 30, 2024
|
We deployed this on a 17.0 odoo.sh instance. It works and nobody yelled at us :) Now this is not a high volume deployment. I'm quite confident this PR is good, but we are going to deploy this on a couple of more intensive instances (not odoo.sh) to confirm. I would encourage others to to the same. |
Without this, we leak connections to Databases that don't have queue_job installed.
Without this we risk connection leaks in case of exceptions in the constructor.
sbidoul
force-pushed
the
17.0-forwardport-ha_runner-qgr
branch
from
918a966 to
992bc9b
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #668