Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][REF] queue_job: Use set.discard(...) instead of SafeSet #722

Merged
merged 1 commit into from
Dec 21, 2024
Merged

[18.0][REF] queue_job: Use set.discard(...) instead of SafeSet #722

merged 1 commit into from
Dec 21, 2024

Conversation

florentx
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

amh-mw
amh-mw suggested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@amh-mw amh-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the code coverage different on this pull request versus the other ones?

@sbidoul
Copy link
Member

sbidoul commented Dec 21, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-722-by-sbidoul-bump-patch, awaiting test results.

@sbidoul
Copy link
Member

sbidoul commented Dec 21, 2024

Why is the code coverage different on this pull request versus the other ones?

Maybe the doc tests are not running anymore?

@OCA-git-bot OCA-git-bot merged commit ade985d into OCA:18.0 Dec 21, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 96ea979. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amh-mw amh-mw amh-mw requested changes

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florentx @OCA-git-bot @sbidoul @amh-mw