[14.0] Add printing_auto_base + stock_picking_auto_print #310

jbaudoux · 2022-12-12T13:26:43Z

When a picking is done, automatically trigger the printing of some documents.
This can be used to print a delivery slip (report) or labels received from the carrier (attachment).

cc @sebalix @mt-software-de

stock_picking_auto_print/tests/test_stock_auto_printing.py

stock_picking_auto_print/models/stock_auto_printing.py

jbaudoux · 2022-12-16T13:05:02Z

@mt-software-de I finished the refactor. Looks better now.

mt-software-de

The attachment field must be changed in the view and test to attachment_domain :-)

stock_picking_auto_print/tests/test_stock_auto_printing.py

stock_picking_auto_print/views/stock_auto_printing_views.xml

jbaudoux · 2022-12-16T13:51:50Z

Merged do_automated_printing and _do_automated_printing at https://github.com/OCA/report-print-send/pull/310/files#diff-ff122f5756c8074c5db95d9f9fcd541f871d3b6e312a3033b0e2304a50356676R57
Replaced Warning in favor of UserError

jbaudoux · 2022-12-16T15:21:44Z

Changes:

split into base & stock picking modules
added error logging
added button to redo the printing

mt-software-de · 2022-12-16T15:25:57Z

Changes:

* split into base & stock picking modules

* added error logging

* added button to redo the printing

Could you let me know when your are done with your changes?

jbaudoux · 2023-06-20T15:40:08Z

rebased

simahawk · 2023-06-21T05:35:34Z

@jbaudoux pls split commits by module 🙏

jbaudoux · 2023-06-21T08:04:52Z

@simahawk done

simahawk · 2023-06-21T10:36:05Z

printing_auto_base/models/printing_auto.py

+ help="Give a domain that must be valid for printing this",
+ )
+ record_change = fields.Char(
+ "Record change", help="Select on which document the report must be executed"


This help msg must be improved, is not clear what it's used for and how it should be valued.

simahawk · 2023-06-21T10:41:11Z

printing_auto_stock_picking/security/ir.model.access.csv

@@ -0,0 +1,3 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_manager,stock_picking_auto_print - manager,printing_auto_base.model_printing_auto,stock.group_stock_manager,1,1,1,1


Don't we need a record rule so that they can see auto-printing records only for stock models?

Done. I had to add a model field to bound the config to it

simahawk · 2023-06-21T10:42:03Z

printing_auto_stock_picking/tests/test_printing_auto_stock.py

+
+
+@mock.patch.object(PrintingPrinter, "print_document", print_document)
+@mock.patch.object(logging.Logger, "exception", exception)


why do you mock the exception? If you expect an exception to be logged it should be tested w/ assertLogs

printing_auto_base/models/printing_auto.py

jbaudoux · 2023-09-15T10:04:55Z

This module should maybe depend on OCA/web#2614

Select on printing.auto to log or raise errors

Fix same record printed multiple times

And add security rule

github-actions · 2024-01-21T12:08:12Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

jbaudoux force-pushed the 14-stock_picking_auto_print branch 3 times, most recently from 0e4357b to 0202c43 Compare December 12, 2022 13:49

mt-software-de reviewed Dec 12, 2022

View reviewed changes

jbaudoux force-pushed the 14-stock_picking_auto_print branch 4 times, most recently from 4f0bba8 to 58bb18d Compare December 16, 2022 13:03

jbaudoux force-pushed the 14-stock_picking_auto_print branch from 58bb18d to 9f047d5 Compare December 16, 2022 13:05

sebalix added this to the 14.0 milestone Dec 16, 2022

jbaudoux force-pushed the 14-stock_picking_auto_print branch from 9f047d5 to 4ba3297 Compare December 16, 2022 13:11

mt-software-de suggested changes Dec 16, 2022

View reviewed changes

stock_picking_auto_print/tests/test_stock_auto_printing.py Outdated Show resolved Hide resolved

stock_picking_auto_print/views/stock_auto_printing_views.xml Outdated Show resolved Hide resolved

stock_picking_auto_print/views/stock_auto_printing_views.xml Outdated Show resolved Hide resolved

jbaudoux force-pushed the 14-stock_picking_auto_print branch 3 times, most recently from 55daad4 to 9d3afab Compare December 16, 2022 13:50

jbaudoux force-pushed the 14-stock_picking_auto_print branch 10 times, most recently from 629569b to fdb2477 Compare December 16, 2022 15:20

jbaudoux force-pushed the 14-stock_picking_auto_print branch from e0be80e to c14ee68 Compare December 16, 2022 15:31

jbaudoux force-pushed the 14-stock_picking_auto_print branch from 0938ffb to 69e710e Compare March 3, 2023 12:29

jbaudoux force-pushed the 14-stock_picking_auto_print branch from 69e710e to c9f1e5e Compare June 20, 2023 15:40

jbaudoux mentioned this pull request Jun 20, 2023

Improve printing from shopfloor OCA/wms#659

Closed

jbaudoux force-pushed the 14-stock_picking_auto_print branch from c9f1e5e to 5265abc Compare June 21, 2023 08:04

simahawk reviewed Jun 21, 2023

View reviewed changes

jbaudoux force-pushed the 14-stock_picking_auto_print branch from b63537c to b731511 Compare August 23, 2023 06:33

mt-software-de suggested changes Sep 7, 2023

View reviewed changes

printing_auto_base/models/printing_auto.py Outdated Show resolved Hide resolved

jbaudoux force-pushed the 14-stock_picking_auto_print branch 2 times, most recently from 011c517 to 9cc9676 Compare September 14, 2023 14:35

base_report_to_(label_)printer: author & copyright

9d0996c

jbaudoux force-pushed the 14-stock_picking_auto_print branch 2 times, most recently from fd51a2a to 6b29ae7 Compare September 19, 2023 15:47

jbaudoux and others added 6 commits September 19, 2023 18:22

[ADD] printing_auto_base

68e3566

[ADD] printing_auto_label_printer

1503f5e

[ADD] printing_auto_stock_picking

15963b9

[IMP] printing_auto_base: log or raise

dd85c24

Select on printing.auto to log or raise errors

[FIX] printing_auto_base: don't print twice

0e100aa

Fix same record printed multiple times

[FIX] printing_auto_base: collect all attachments

1b0dc61

jbaudoux force-pushed the 14-stock_picking_auto_print branch 3 times, most recently from 2b6d127 to cc45b96 Compare September 19, 2023 20:10

[FIX] printing_auto*: bound to model

f6623df

And add security rule

jbaudoux force-pushed the 14-stock_picking_auto_print branch from cc45b96 to f6623df Compare September 19, 2023 20:19

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 21, 2024

github-actions bot closed this Feb 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] Add printing_auto_base + stock_picking_auto_print #310

[14.0] Add printing_auto_base + stock_picking_auto_print #310

jbaudoux commented Dec 12, 2022 •

edited

Loading

jbaudoux commented Dec 16, 2022

mt-software-de left a comment

jbaudoux commented Dec 16, 2022 •

edited

Loading

jbaudoux commented Dec 16, 2022

mt-software-de commented Dec 16, 2022

jbaudoux commented Jun 20, 2023

simahawk commented Jun 21, 2023

jbaudoux commented Jun 21, 2023

simahawk Jun 21, 2023

jbaudoux Sep 19, 2023

simahawk Jun 21, 2023

jbaudoux Sep 20, 2023

simahawk Jun 21, 2023

jbaudoux commented Sep 15, 2023

github-actions bot commented Jan 21, 2024

		@@ -0,0 +1,3 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		access_manager,stock_picking_auto_print - manager,printing_auto_base.model_printing_auto,stock.group_stock_manager,1,1,1,1



		@mock.patch.object(PrintingPrinter, "print_document", print_document)
		@mock.patch.object(logging.Logger, "exception", exception)

[14.0] Add printing_auto_base + stock_picking_auto_print #310

[14.0] Add printing_auto_base + stock_picking_auto_print #310

Conversation

jbaudoux commented Dec 12, 2022 • edited Loading

jbaudoux commented Dec 16, 2022

mt-software-de left a comment

Choose a reason for hiding this comment

jbaudoux commented Dec 16, 2022 • edited Loading

jbaudoux commented Dec 16, 2022

mt-software-de commented Dec 16, 2022

jbaudoux commented Jun 20, 2023

simahawk commented Jun 21, 2023

jbaudoux commented Jun 21, 2023

simahawk Jun 21, 2023

Choose a reason for hiding this comment

jbaudoux Sep 19, 2023

Choose a reason for hiding this comment

simahawk Jun 21, 2023

Choose a reason for hiding this comment

jbaudoux Sep 20, 2023

Choose a reason for hiding this comment

simahawk Jun 21, 2023

Choose a reason for hiding this comment

jbaudoux commented Sep 15, 2023

github-actions bot commented Jan 21, 2024

jbaudoux commented Dec 12, 2022 •

edited

Loading

jbaudoux commented Dec 16, 2022 •

edited

Loading