Skip to content

[15.0][MIG] base_rest_demo: Migration to 15.0 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Dec 4, 2021
Merged

[15.0][MIG] base_rest_demo: Migration to 15.0 #229

OCA-git-bot merged 1 commit into from
Dec 4, 2021

Conversation

@yankinmax
Copy link
Contributor

@yankinmax yankinmax commented Dec 1, 2021 •
edited
Loading

@yankinmax yankinmax force-pushed the 15.0-mig-base_rest_demo branch from cb1b6ef to a102df2 Compare December 1, 2021 12:52
simahawk
simahawk reviewed Dec 1, 2021
View reviewed changes
@yankinmax yankinmax force-pushed the 15.0-mig-base_rest_demo branch 2 times, most recently from c308e1c to 0404de7 Compare December 1, 2021 14:15
@yankinmax
Copy link
Contributor Author

yankinmax commented Dec 1, 2021

@lmignon Can you pls take a look here?

@yankinmax yankinmax force-pushed the 15.0-mig-base_rest_demo branch from 0404de7 to 036a22f Compare December 1, 2021 17:07
@lmignon lmignon mentioned this pull request Dec 2, 2021
Closed
10 tasks
simahawk
simahawk reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@yankinmax yankinmax force-pushed the 15.0-mig-base_rest_demo branch from 036a22f to b109eb8 Compare December 2, 2021 10:11
@yankinmax yankinmax force-pushed the 15.0-mig-base_rest_demo branch from b109eb8 to 4816006 Compare December 3, 2021 10:59
@yankinmax
Copy link
Contributor Author

yankinmax commented Dec 3, 2021

@simahawk @lmignon can you pls take a look?
This module stays mostly unchanged.
But what is strange for me that runboat/build here continue staying in pending for two days
build
.

@simahawk
Copy link
Contributor

simahawk commented Dec 3, 2021

@yankinmax not blocking ATM. Worth to notify @sbidoul tho. See https://runboat.odoo-community.org/webui/build.html?name=b02276cb9-bec3-4b6a-ad7f-e9434a2b0b8f

marcos-mendez
marcos-mendez approved these changes Dec 3, 2021
View reviewed changes
Copy link

@marcos-mendez marcos-mendez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM testes on local LXC

@simahawk
Copy link
Contributor

simahawk commented Dec 4, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 4, 2021

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-229-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2006579 into OCA:15.0 Dec 4, 2021
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 4, 2021

Congratulations, your PR was merged at 274cfb5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

+1 more reviewer

@marcos-mendez marcos-mendez marcos-mendez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yankinmax @simahawk @OCA-git-bot @marcos-mendez