Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] queue_job_chunk: add module #20

Closed
wants to merge 40 commits into from
Closed

[16.0][ADD] queue_job_chunk: add module #20

wants to merge 40 commits into from

Conversation

clementmbr
Copy link
Member

Adds the notion of queue job chunks, essentially a queue job with some metadata.
Useful to store the JSON received by an API request before their treatment in odoo.

cc @florian-dacosta @kevinkhao @bealdav @sebastienbeau

kevinkhao and others added 30 commits May 23, 2024 12:11
@kevinkhao @clementmbr
[ADD] queue_job_chunk
9bf893f
@kevinkhao @clementmbr
[IMP] Creation logic and saving record state/id/model
99ebf1d
@kevinkhao @clementmbr
[IMP][WIP] Tests
9dce6c0
@kevinkhao @clementmbr
[IMP] Improved form view
25c22c6
@kevinkhao @clementmbr
[IMP] Logic on queue.job.chunk, company_ids, tests, and component sep…
a047460 
…aration
@kevinkhao @clementmbr
[IMP] Improve views
77c29a0
@kevinkhao @clementmbr
[IMP] cleanup
ac78ad2
@kevinkhao @clementmbr
[IMP] Add reference test
c9c5ae0
@kevinkhao @clementmbr
[IMP] Rename reference_company_id to company_id, add company calculat…
0f12570 
…ion according to user, modify tests
@kevinkhao @clementmbr
[IMP] Change logic for company_id calculation
aefd039
@kevinkhao @clementmbr
[FIX] Logic on company_id attribution
f1147f1
@kevinkhao @clementmbr
[FIX] Fix reference field type to Reference
7e759b6
@kevinkhao @clementmbr
[IMP] Feedback changes
0da3768
@kevinkhao @clementmbr
wip
cf0709c
@kevinkhao @clementmbr
wip
adee22a
@kevinkhao @clementmbr
wip
a2db84a
@kevinkhao @clementmbr
Cleanup/README
255da15
@kevinkhao @clementmbr
[IMP] Minor add readme to queue_job_chunk
0778361
@kevinkhao @clementmbr
Make travis happy
e99c5a0
@kevinkhao @clementmbr
[IMP] run pre-commit
3ad877b
@kevinkhao @clementmbr
[14.0] 14.0 Branch: Initial commit with no installable modules
b8076c3
@kevinkhao @clementmbr
[14.0][MIG] Migration to 14.0
e7f83cc
@sebastienbeau @clementmbr
[IMP] copier update
ecd301b
@sebastienbeau @clementmbr
[IMP] concurrent update should be retry
41a45f9
@florian-dacosta @clementmbr
[FIX] tests and ci
0a2c553
@github-grap-bot @clementmbr
[UPD] README.rst
aa03cd5
@sebastienbeau @clementmbr
Fix copyright header licence is AGPL3 in manifest
7a74238
@matthieu1611 @clementmbr
new field stack trace to help failed chunk job
9350879
@sebastienbeau @clementmbr
Make module uninstallable
de9ce81
@sebastienbeau @clementmbr
queue_job_chunk: Migration to 16.0
d2a7153
@clementmbr clementmbr mentioned this pull request May 23, 2024
Closed
bealdav
bealdav approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , unit tests are there

@rvalyi
Copy link
Member

rvalyi commented May 27, 2024

what about squashing a few commits like the "wip" ones or some of the README adjustments? Nowadays people try to have a clean and meaningful module history in the OCA, this is useful when using git blame to hunt for an explanation or when porting modules from serie to serie...

kevinkhao
kevinkhao reviewed May 28, 2024
View reviewed changes
queue_job_chunk/models/queue_job_chunk.py
except RetryableJobError:
raise
except Exception as e:
if DEBUG_MODE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be replaced with something like

    if "pdb" in config.get("dev_mode"):

Instead of hardcoded constant

kevinkhao
kevinkhao approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@kevinkhao kevinkhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review LGTM cleaner without component

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bealdav
Copy link
Member

bealdav commented Jun 11, 2024

Probably need to go to queue-job repository ? !!

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@github-actions github-actions bot closed this Nov 17, 2024
@sebastienbeau sebastienbeau reopened this Jan 17, 2025
@clementmbr clementmbr mentioned this pull request Jan 17, 2025
Open
@clementmbr
Copy link
Member Author

PR moved to OCA/queue#737

@clementmbr clementmbr closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinkhao kevinkhao kevinkhao approved these changes

@bealdav bealdav bealdav approved these changes

Assignees
No one assigned
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@clementmbr @rvalyi @OCA-git-bot @bealdav @kevinkhao @sebastienbeau @florian-dacosta @github-grap-bot @matthieu1611 @hparfr