Add module sale_cutoff_time_weekday_delivery

sale_cutoff_time_weekday_delivery/__init__.py

@@ -0,0 +1,2 @@
+# Copyright 2020 Camptocamp SA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)

sale_cutoff_time_weekday_delivery/__manifest__.py

@@ -0,0 +1,16 @@
+# Copyright 2020 Camptocamp SA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+{
+    "name": "Sale Cutoff Time Weekday Delivery",
+    "summary": "Schedule delivery orders according to cutoff and weekday preferences",
+    "version": "13.0.1.0.0",
+    "development_status": "Alpha",
+    "category": "Warehouse Management",
+    "website": "https://github.com/OCA/sale-workflow",
+    "author": "Camptocamp, Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "application": False,
+    "installable": True,
+    "depends": ["sale_zcutoff_time_delivery", "sale_weekday_delivery"],
+    "auto-install": True,
+}

sale_cutoff_time_weekday_delivery/readme/CONTRIBUTORS.rst

@@ -0,0 +1 @@
+* Akim Juillerat <akim.juillerat@camptocamp.com>

sale_cutoff_time_weekday_delivery/readme/DESCRIPTION.rst

@@ -0,0 +1,2 @@
+This module adds some unittests to ensure Method Resolution Order for modules
+sale_cutoff_time_delivery and sale_weekday_delivery is correct.

sale_cutoff_time_weekday_delivery/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_cutoff_weekday_delivery

sale_cutoff_time_weekday_delivery/tests/test_cutoff_weekday_delivery.py

@@ -0,0 +1,225 @@
+# Copyright 2020 Camptocamp SA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+from freezegun import freeze_time
+
+from odoo import fields
+from odoo.tests import SavepointCase
+
+
+class TestSaleCutoffWeekdayDelivery(SavepointCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
+        cls.customer_partner = cls.env["res.partner"].create(
+            {
+                "name": "Partner cutoff",
+                "order_delivery_cutoff_preference": "partner_cutoff",
+                "order_delivery_cutoff_hours": "09",
+                "order_delivery_cutoff_minutes": "00",
+                "delivery_schedule_preference": "fix_weekdays",
+                "delivery_schedule_monday": True,
+                "delivery_schedule_tuesday": False,
+                "delivery_schedule_wednesday": False,
+                "delivery_schedule_thursday": False,
+                "delivery_schedule_friday": True,
+                "delivery_schedule_saturday": False,
+                "delivery_schedule_sunday": False,
+            }
+        )
+        cls.customer_warehouse = cls.env["res.partner"].create(
+            {
+                "name": "Partner warehouse cutoff",
+                "order_delivery_cutoff_preference": "warehouse_cutoff",
+                "order_delivery_cutoff_hours": "09",
+                "order_delivery_cutoff_minutes": "00",
+                "delivery_schedule_preference": "fix_weekdays",
+                "delivery_schedule_monday": True,
+                "delivery_schedule_tuesday": False,
+                "delivery_schedule_wednesday": False,
+                "delivery_schedule_thursday": False,
+                "delivery_schedule_friday": True,
+                "delivery_schedule_saturday": False,
+                "delivery_schedule_sunday": False,
+            }
+        )
+        cls.warehouse = cls.env.ref("stock.warehouse0")
+        cls.warehouse.write(
+            {
+                "order_delivery_cutoff_hours": "10",
+                "order_delivery_cutoff_minutes": "00",
+            }
+        )
+        cls.product = cls.env.ref("product.product_product_9")
+
+    def _create_order(self, partner=None):
+        order = self.env["sale.order"].create(
+            {
+                "partner_id": partner.id,
+                "partner_shipping_id": partner.id,
+                "order_line": [
+                    (
+                        0,
+                        0,
+                        {
+                            "name": self.product.name,
+                            "product_id": self.product.id,
+                            "product_uom_qty": 1,
+                            "product_uom": self.product.uom_id.id,
+                            "price_unit": self.product.list_price,
+                        },
+                    )
+                ],
+            }
+        )
+        # Play onchange manually to ensure customer_lead is set on the line
+        order.order_line._onchange_product_id_set_customer_lead()
+        return order
+
+    @freeze_time("2020-03-26 18:00:00")  # thursday evening
+    def test_after_cutoff_preferred_weekday(self):
+        # After partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-27 09:00:00"))
+        # Before warehouse cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-27 10:00:00"))
+
+    @freeze_time("2020-03-27 08:00:00")  # friday morning
+    def test_before_cutoff_preferred_weekday(self):
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date, fields.Datetime.to_datetime("2020-03-27 09:00:00"))
+        # Before warehouse cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-27 10:00:00"))
+
+    @freeze_time("2020-03-27 18:00:00")  # friday evening
+    def test_after_cutoff_other_weekday(self):
+        # After partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-30 09:00:00"))
+        # After warehouse cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-30 10:00:00"))
+
+    @freeze_time("2020-03-28 08:00:00")  # saturday morning
+    def test_before_cutoff_other_weekday(self):
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date, fields.Datetime.to_datetime(
+            "2020-03-30 09:00:00"))
+        # Before warehouse cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-30 10:00:00"))
+
+    @freeze_time("2020-03-23 08:00:00")  # monday morning
+    def test_before_cutoff_lead_time_preferred_weekday(self):
+        self.product.sale_delay = 4
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime(
+                             "2020-03-27 09:00:00"))
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-27 10:00:00"))
+
+    @freeze_time("2020-03-23 18:00:00")  # monday evening
+    def test_after_cutoff_lead_time_preferred_weekday(self):
+        # THIS IS PROBABLY THE MOST IMPORTANT TEST HERE:
+        #  This test ensures that cutoff is applied before weekday because both
+        #  sale_cutoff_delivery and sale_weekday_delivery have the same
+        #  dependencies.
+        #  /!\ It seems to work because sale_cutoff_delivery is alphabetically
+        #  before sale_weekday_delivery /!\
+        #  Anyway, here we want the computation to happen as follows:
+        #  confirmation time: 2020-03-23 18:00:00
+        #  application of lead time: 2020-03-27 18:00:00
+        #  application of cutoff: 2020-03-28 09:00:00
+        #  application of weekday: 2020-03-30 09:00:00
+        # what matches both cutoff and weekday preference
+
+        # If somehow the MRO of _prepare_procurement_values is WRONG we'd have:
+        #  confirmation time: 2020-03-23 18:00:00
+        #  application of lead time: 2020-03-27 18:00:00
+        #  application of weekday: 2020-03-27 18:00:00
+        #  application of cutoff: 2020-03-28 09:00:00
+        # what doesn't match the weekday preference!
+        self.product.sale_delay = 4
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime(
+                             "2020-03-30 09:00:00"))
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime(
+                             "2020-03-30 10:00:00"))
+
+    @freeze_time("2020-03-24 08:00:00")  # tuesday morning
+    def test_before_cutoff_lead_time_other_weekday(self):
+        self.product.sale_delay = 4
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime(
+                             "2020-03-30 09:00:00"))
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime("2020-03-30 10:00:00"))
+
+    @freeze_time("2020-03-24 18:00:00")  # tuesday evening
+    def test_after_cutoff_lead_time_other_weekday(self):
+        self.product.sale_delay = 4
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_partner)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime(
+                             "2020-03-30 09:00:00"))
+        # Before partner cutoff
+        order = self._create_order(partner=self.customer_warehouse)
+        order.action_confirm()
+        picking = order.picking_ids
+        self.assertEqual(picking.scheduled_date,
+                         fields.Datetime.to_datetime(
+                             "2020-03-30 10:00:00"))